14 Commits

Author SHA1 Message Date
William Woodruff
649a630826
utils/fork: Check if error pipe is closed
Document special interrupt case.
2018-09-18 22:21:12 -04:00
William Woodruff
367629d289
utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-04 11:03:32 -04:00
Mike McQuaid
7df5b7057e
Revert "Use JSON to marshal errors from children" 2018-08-18 08:20:13 +01:00
William Woodruff
5c90833f0a
Use JSON to marshal errors from children 2018-08-17 15:23:08 -04:00
Markus Reiter
e2d8e3c6ee Remove unneeded RuboCop comment. 2018-08-01 04:12:31 +02:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Shaun Jackman
7b96fd008e safe_fork: Improve the error message 2017-08-25 12:43:07 -07:00
Mike McQuaid
021cef4b2b Autocorrect Rubocop Style/SpecialGlobalVars. 2017-06-12 09:11:42 +01:00
BrewTestBot
13d544e11e Core files style updates.
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Jack Nagel
ff11789933 Close the socket after sending the file descriptor to the child
Fixes Homebrew/homebrew#39691.
2015-05-12 21:53:04 -04:00
Jack Nagel
c07da9485f The forked build process should never run at_exit handlers
We don't use at_exit anywhere that matters, but the test framework does.
2015-04-28 01:39:28 -04:00
Jack Nagel
913c12fd43 Keep subprocess code inside begin block 2015-04-25 23:22:58 -04:00
Jack Nagel
f7ded45bc7 Clean up socket and filesystem resources separately 2015-04-25 23:17:13 -04:00
Xu Cheng
06f72ab38f move safe_fork into a standalone method 2015-04-15 19:51:54 +08:00