2828 Commits

Author SHA1 Message Date
Carlo Cabrera
909b8d078e
dev-cmd/update-maintainers: write JSON of maintainers
This will be needed for Homebrew/homebrew-test-bot#933.
2023-05-29 21:30:47 +08:00
Markus Reiter
7cc1b6191e
Clean up brew audit output. 2023-05-19 19:40:37 +02:00
Markus Reiter
e9bfcb9296
Merge pull request #15225 from reitermarkus/audit-os-arch
Add `--os=all` and `--arch=all` options for `brew audit`.
2023-05-19 15:03:32 +02:00
Carlo Cabrera
d7870bb24d
Move artifact download code to separate file
This will help avoid mutually-recursive `require`s.
2023-05-17 23:48:58 +08:00
Markus Reiter
486c3765ce
Add --os=all and --arch=all options. 2023-05-17 15:26:46 +02:00
Carlo Cabrera
d372eb86ca
utils/github: remove unnecessary chdir call
The only existing caller already has the requested directory as the
workign directory, so this is currently not needed.
2023-05-17 21:11:15 +08:00
Carlo Cabrera
05337cbb79
Refactor GitHub artifact downloads out of dev-cmd/pr-pull
I plan to use these in `test-bot` to download built bottles from
previous CI runs.
2023-05-17 21:11:15 +08:00
apainintheneck
358a2ce788 dev-cmd/generate-*-api: add dry run option
There are two reasons for this:
- Makes it easier to run this command as a sanity check without
  having to create a temporary directory
- Is somewhat faster since you don't have to write thousands of files
2023-05-15 18:29:49 -07:00
Markus Reiter
0d56b97b07
Add SimulateSystem::with. 2023-05-14 01:45:04 +02:00
Markus Reiter
c5926241a8
Don't fail auditing empty tap. 2023-05-11 21:52:36 +02:00
Markus Reiter
8274920217
Rename OS::Mac::Version to MacOSVersion. 2023-05-09 05:08:38 +02:00
Dawid Dziurla
a341f4346c
bump-formula-pr: fix method argument type 2023-05-05 13:51:14 +02:00
Carlo Cabrera
50df7fab28
determine-test-runners: add debug output
The extra timeout on Intel Big Sur doesn't seem to be set, so I'm adding
this so I can have a closer look.
2023-04-29 11:03:27 +08:00
Bo Anderson
44f058edb5
Refactor formula, cask and Ruby source downloads to use shared code 2023-04-27 23:23:07 +01:00
Razvan Azamfirei
33ddc2d818
modify bump logic 2023-04-26 19:53:10 -04:00
Markus Reiter
9f21d378cd
Merge pull request #15310 from EricFromCanada/bump-cask-url-string
bump-cask-pr: convert URL back to string
2023-04-26 13:14:43 +02:00
Eric Knibbe
5f6b626880
bump-cask-pr: convert URL back to string 2023-04-25 18:11:36 -04:00
Douglas Eichelberger
08af78a2a5 brew style --fix 2023-04-25 09:26:24 -07:00
Mike McQuaid
67c118009b
Merge pull request #15308 from ZhongRuoyu/workflows-macos-13
workflows: run on `macos-13`
2023-04-25 15:10:37 +01:00
Douglas Eichelberger
24cf6076e8 brew style --fix 2023-04-24 20:42:39 -07:00
Ruoyu Zhong
6eaa0b2940
dev-cmd/tap-new: run brew test-bot on macos-13 2023-04-25 11:24:00 +08:00
Carlo Cabrera
4f179c54a3
Merge pull request #15300 from carlocab/git-repo-str
git_repository: implement `#to_s`
2023-04-24 22:48:47 +08:00
Carlo Cabrera
2f37877858
git_repository: implement #to_s instead 2023-04-24 22:34:09 +08:00
Douglas Eichelberger
f52cbbb9da
Vendor mechanize gem outside Gemfile
We only need a single file and it avoids pulling in e.g. `nokogiri`
which is vulnerable.

Allow updating it using `brew vendor-gems`.
2023-04-24 14:03:55 +01:00
Carlo Cabrera
f4692ddb40
dev-cmd/audit: fix audit annotations
Emitting annotations currently produces:

    Error: no implicit conversion of Symbol into Integer

The issue is that `problem` is an `Array` of problems which we need to
handle individually.
2023-04-22 15:13:35 +08:00
Ruoyu Zhong
209a9fe2ff
dev-cmd/pr-automerge: skip PRs with pre-release label
PRs with the `pre-release` label are always not ready for merge, so
let's skip them by default.

See also: Homebrew/homebrew-core#128906.

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-21 03:30:10 +08:00
Mike McQuaid
71de574285
Merge pull request #15269 from MikeMcQuaid/audit_no_warnings
dev-cmd/audit: remove unused warnings key.
2023-04-19 16:22:13 +01:00
Mike McQuaid
2ca3f73078
dev-cmd/audit: remove unused warnings key.
These are now all errors so the code can be simplified.
2023-04-19 16:09:45 +01:00
Mike McQuaid
d0d9894963
Merge pull request #15266 from razvanazamfirei/bump-bug-fix
Fix bump-cask-pr handling of sha256 :no_check
2023-04-19 15:56:41 +01:00
Mike McQuaid
0b4c0350c2
Merge pull request #15201 from hyuraku/remove_cask/cmd/audit
remove `cask/cmd/audit`
2023-04-19 10:01:06 +01:00
Razvan Azamfirei
3d5c4aaf50
add check that hash is a string 2023-04-18 23:14:48 -04:00
Razvan Azamfirei
063324a116
fix bump-cask-pr handling of sha256 :no_check 2023-04-18 19:49:02 -04:00
Razvan Azamfirei
a2b80e4ec2
fix origin_branch_name 2023-04-17 09:57:06 -04:00
Douglas Eichelberger
403f08db8b Remove delegation 2023-04-16 09:30:21 -07:00
Douglas Eichelberger
b90897e280 Create git_repo attr 2023-04-15 19:35:13 -07:00
Douglas Eichelberger
a6fbf5f1ac brew style --fix 2023-04-15 19:35:13 -07:00
Douglas Eichelberger
1ffb77f821 cleanup 2023-04-15 19:35:13 -07:00
Douglas Eichelberger
8307255ce8 Update call sites 2023-04-15 19:35:13 -07:00
Douglas Eichelberger
429f23dcc6 Create GitRepoPath 2023-04-15 19:35:12 -07:00
hyuraku
54ce31e0fe remove auditing = true 2023-04-15 10:05:58 +09:00
hyuraku
98ec60c15e remove nil param 2023-04-13 19:02:20 +09:00
Markus Reiter
66d80cb114
Allow running audit for different architecture. 2023-04-12 21:46:48 +02:00
hyuraku
b8f18309c3 repair variable 2023-04-12 22:23:08 +09:00
hyuraku
acca57a2d8 repair cask_results query 2023-04-12 21:59:28 +09:00
hyuraku
f7b51d8cd1 pass opitions as named parameters 2023-04-12 20:16:10 +09:00
Ruiyang Wu
73a1380055 dev-cmd/bottle: Refactor setup_tar_and_args! to extend/os 2023-04-11 11:00:47 -04:00
Ruiyang Wu
d7427ab762 Don't save mac metadata/extended attributes for brew bottle
This commit includes `--no-mac-metadata` `--no-acls` and `--no-xattrs`
in `default_tar_args` for `brew bottle` command.

Although `default_tar_args` is only active when `--only-json-tab` is
not passed, in which case we don't require reproducible bottles, it is
nonetheless beneficial to "regularize" tarball creation. In
particular, this resolves a sporadic `brew tests
--only=dev-cmd/bottle:20` failure (see
https://github.com/orgs/Homebrew/discussions/4376 and
https://github.com/Homebrew/brew/pull/14997).

Furthermore, with `gnu tar`, `--no-acls` and `--no-xattrs` are default
flags. As for "mac metadata", although I couldn't find official
documentation, this post (https://superuser.com/a/61188) shares some
info:
- Resource forks (resource forks have been extended attributes since 10.4)
  - Custom icons set in Finder and the images of Icon\r files
  - Metadata in PSD files
  - Objects stored in scpt files, AppleScript Editor window state, descriptions of scripts
- Information about aliases (aliases stop working if extended attributes are removed)
- Quarantine status or source URLs of files downloaded from the internet
- Spotlight comments
- Encoding of files saved with TextEdit
- Caret position of files opened with TextMate
- Skim notes

None of these is supposed to be in the bottle I believe.
2023-04-11 11:00:47 -04:00
Bo Anderson
448bf1a49c
Merge pull request #15183 from Bo98/prof-group2
Revert "Revert "Split prof gems into their own group""
2023-04-11 15:11:57 +01:00
hyuraku
4999639140 - remove cask/cmd/audit
- repair cmd/audit
2023-04-11 23:06:01 +09:00
Mike McQuaid
294ea23397
Merge pull request #15192 from ZhongRuoyu/update-maintainers-slice
dev-cmd/update-maintainers: fix undefined method
2023-04-11 10:32:32 +01:00