Douglas Eichelberger
09c679e75f
Refactor module_function to reduce rbi need
2023-04-17 10:37:59 -07:00
Douglas Eichelberger
9446db7720
Typecheck some utils
2023-03-09 21:46:35 -08:00
Issy Long
2814d2285a
Make str variable names longer
...
- Three characters is the RuboCop limit for parameter names, but more
descriptive is good.
- Requested in
https://github.com/Homebrew/brew/pull/14922#pullrequestreview-1330848594 ,
but the automerge was too quick for me to get to it.
2023-03-08 15:30:25 +00:00
Issy Long
89fb8c78e8
rubocop: Drop "s" from Naming/MethodParameterName allowlist
...
- Most usages of this were in the `pretty_duration` method, where "s"
is better described as "seconds" since we're calculating a duration.
- I also took the executive decision to do the same to "m" which refers
to "minutes".
2023-03-08 14:42:53 +00:00
Rylan Polster
feb93167ad
Rename and fix Formatter:wrap to Formatter.format_help_text
2022-01-08 23:13:08 -05:00
Mike McQuaid
41e94afda5
Fix brew style
...
Fixes for https://github.com/Homebrew/brew/pull/12152 .
Extracted into a separate PR so this can be merged immediately.
2021-09-30 10:13:53 +01:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Markus Reiter
843f2a19e4
Document Formatter.
2020-08-26 03:13:59 +02:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks.
2020-08-19 17:12:32 +01:00
EricFromCanada
0acfb4b819
Add line break and indent to subcommand descriptions
2020-04-19 11:50:28 -04:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
...
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
EricFromCanada
560ccddb69
help: rewrap output to 80 columns
...
Accounts for paragraph breaks and option descriptions. Also fixes some help text nits.
2019-03-11 12:52:07 -04:00
Markus Reiter
16618d0fc7
Use ActiveSupport’s #pluralize and #to_sentence.
2018-10-07 23:10:56 +02:00
Gautham Goli
c7bf79407a
Better man page formatting
2018-10-03 19:20:26 +05:30
Markus Reiter
9d79cf1e9d
Reference RuboCop issue.
2018-07-01 18:48:28 +02:00
Markus Reiter
71a79e7e04
Ignore false RuboCop positive.
2018-07-01 18:48:28 +02:00
Markus Reiter
c6c1eacc18
Rename enumeration to comma_and.
2018-07-01 18:48:28 +02:00
Markus Reiter
7671606ddc
Add Formatter::enumeration.
2018-07-01 18:48:28 +02:00
Markus Reiter
b2c85ad945
Refactor search.
2018-06-07 13:48:35 +02:00
Markus Reiter
d700a5ba18
Use Formatter::pluralize where possible.
2017-05-29 17:50:13 +02:00
Markus Reiter
44d367edca
Deprecate #plural.
2017-03-11 21:16:37 +01:00
Markus Reiter
c594ffefbc
Add Formatter::pluralize.
2017-03-11 21:12:51 +01:00
Mike McQuaid
1f963267b6
Update Rubocop style.
...
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed.
2016-10-22 13:32:46 +01:00
Andrew Janke
e72f1139ad
Formatter: identifier: only reset color, not full styling
2016-10-17 00:45:37 -04:00
Markus Reiter
581a1245bf
Move Formatter.columns into utils/formatter.
2016-10-15 17:22:10 +02:00
Markus Reiter
198bf4d3bd
Convert puts_columns to puts Formatter.columns.
2016-10-15 17:13:38 +02:00
Markus Reiter
75e8b59aad
Add Formatter module.
2016-10-01 20:00:49 +02:00
