14069 Commits

Author SHA1 Message Date
Mike McQuaid
61a8c4d1fb
Merge pull request #4300 from apjanke/new-rubocop-version
Upgrade to Rubocop 0.57.2
2018-07-01 09:08:16 +01:00
Markus Reiter
ad82cd888e Remove unneeded RuboCop comment. 2018-07-01 01:43:04 +02:00
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
Andrew Janke
f99d7b29ef upgrade to Rubocop 0.57.1 2018-06-30 16:27:19 -04:00
Gautham Goli
fac11c2f16
Merge pull request #4396 from Homebrew/dep-order-cop-fix
DependencyOrder: Fix var initialization bug
2018-06-30 19:02:04 +05:30
Gautham Goli
ffb4fe7041 DependencyOrder: Fix var initialization bug 2018-06-30 15:24:53 +05:30
Markus Reiter
20b990a19f Remove Cask#qualified_token. 2018-06-30 06:03:51 +02:00
Markus Reiter
df3d017739 Fix Cask#full_name. 2018-06-30 06:01:01 +02:00
Markus Reiter
e3bb004ad7
Merge pull request #4372 from reitermarkus/cask-search
Readd functionality to list all casks.
2018-06-30 02:40:39 +02:00
Mike McQuaid
376f67bf2c
Merge pull request #4390 from MikeMcQuaid/linkage-cache-default
linkage: enable cache by default.
2018-06-29 20:35:13 +01:00
Mike McQuaid
d3968fc327
Merge pull request #4391 from MikeMcQuaid/remove-unused-var
brew.sh: remove unused variable.
2018-06-29 20:34:57 +01:00
Mike McQuaid
ec6420229e brew.sh: remove unused variable.
As of #4377 this is no longer used.
2018-06-29 20:12:22 +01:00
Mike McQuaid
1bf3aacc79
Merge pull request #4389 from MikeMcQuaid/bintray-portable-ruby
portable-ruby: respect HOMEBREW_BOTTLE_DOMAIN variable.
2018-06-29 20:07:11 +01:00
Mike McQuaid
6f5c8b8509 linkage: enable cache by default.
This has not been causing any issues in CI or for `master` users so
let's now enable it by default for everyone.
2018-06-29 19:57:39 +01:00
Mike McQuaid
facd76bc51 portable-ruby: respect HOMEBREW_BOTTLE_DOMAIN variable.
This was requested in:
https://discourse.brew.sh/t/adding-additional-download-sources-to-homebrew/2446

With this change you can use e.g. Artifactory for Homebrew's portable
ruby.
2018-06-29 19:51:18 +01:00
Mike McQuaid
0d33aba0b7
Merge pull request #4377 from jacktose/force-brewed-git
Implement HOMEBREW_FORCE_BREWED_GIT
2018-06-26 19:34:44 +01:00
Jack Haden-Enneking
e63feb79f9
Simplify check before git install
No need to check for both variables, because they're always set together.
Also, this harmonizes with the CURL equivalent just above.
2018-06-26 11:14:32 -07:00
Jack Haden-Enneking
9fd5a92ff6 Implement HOMEBREW_FORCE_BREWED_GIT
Because of this messing with the user's path:
https://github.com/Homebrew/brew/blob/
    efc02899c851c62c9ce0d15dea9a231575d7d774/bin/brew#L68
brew uses /usr/bin/git over brewed git, even when the former is
problematically old.
There may also be other reasons a user prefers to use brewed git.

There was already a HOMEBREW_FORCE_BREWED_CURL option and a
HOMEBREW_SYSTEM_CURL_TOO_OLD check to set it. This mostly copies those
to implement HOMEBREW_FORCE_BREWED_GIT & HOMEBREW_SYSTEM_GIT_TOO_OLD.

See also: https://github.com/Linuxbrew/brew/issues/736
2018-06-25 23:36:12 -07:00
Mike McQuaid
c101a82c5b
Revert "Fix SVN downloads of versioned formula by munging directory names" 2018-06-26 07:10:36 +01:00
ilovezfs
3b46736820 mirror: use curl_executable instead of curl function 2018-06-25 06:33:44 -07:00
ilovezfs
49157dbf17 mirror: invoke correct curl
Remove remaining use of `system "curl"` in favor of the `curl` function.
2018-06-25 05:21:55 -07:00
Mike McQuaid
7506abe5be
Merge pull request #4358 from apjanke/fix-subversion-download-of-versioned-formulae
Fix SVN downloads of versioned formula by munging directory names
2018-06-25 08:58:24 +01:00
Andrew Janke
b72c4e3248 Fix SVN downloads of versioned formula by munging directory names 2018-06-25 03:21:36 -04:00
ilovezfs
78757bf56e
Merge pull request #4328 from woodruffw/install-check-dev-tools
[WIP] formula_installer: Don't check devtools if pouring
2018-06-24 18:20:34 -07:00
Markus Reiter
6a44c529e5 Readd functionality to list all casks. 2018-06-23 01:54:07 +02:00
Mike McQuaid
512073ad38 cache_store: create HOMEBREW_CACHE when needed.
Fixes #4366.
2018-06-21 13:59:07 +01:00
commitay
41e27928c4
Merge pull request #4232 from commitay/cask-caveats
cask fetch and upgrade: print caveats
2018-06-21 11:51:29 +10:00
Markus Reiter
fcd75877c5 Update brew search help. 2018-06-19 13:48:23 +02:00
Markus Reiter
ccbbe6756f Remove brew cask search from documentation. 2018-06-19 13:40:25 +02:00
Markus Reiter
25542d7398
Merge pull request #4316 from reitermarkus/merge-search
Merge `brew cask search` into `brew search`.
2018-06-18 21:31:33 +02:00
Markus Reiter
c814199a79
Merge pull request #4320 from lucafavatella/brew-cask-doctor
Fix `brew cask doctor` for non-standard installation location
2018-06-18 16:30:23 +02:00
Markus Reiter
b265d870ed Allow searching Casks by name. 2018-06-18 16:23:36 +02:00
Markus Reiter
b21430b13c Use extend/os pattern. 2018-06-18 16:23:36 +02:00
Markus Reiter
18e46b3ec2 Fix usage of HOMEBREW_LOAD_PATH. 2018-06-18 16:23:35 +02:00
Markus Reiter
1d629c6978 Don’t show Casks on Linux. 2018-06-18 16:23:35 +02:00
Markus Reiter
a8bfe09c49 Remove tests for brew cask search. 2018-06-18 16:23:35 +02:00
Markus Reiter
8c620d8b97 Redirect brew cask search to brew search. 2018-06-18 16:23:35 +02:00
Markus Reiter
da193d2f7e Merge brew cask search into brew search. 2018-06-18 16:23:35 +02:00
Mike McQuaid
f7d0c89c21
Merge pull request #4348 from errordeveloper/master
Ignore any version of Go, when it is a dependency of a bottle
2018-06-18 14:56:14 +01:00
Mike McQuaid
5e6c40e28f Make versioned formulae regex more consistent.
Share the regex where possible and otherwise ensure they are identical.
2018-06-18 14:36:51 +01:00
Mike McQuaid
60e6b5114b
Merge pull request #4349 from apjanke/audit-head-only-error
brew audit: avoid error on head-only formulae
2018-06-18 13:51:59 +01:00
Vítor Galvão
9831e67452
Merge pull request #4346 from commitay/version-minor_patch
cask dsl versions: add minor_patch
2018-06-16 13:18:21 +01:00
Andrew Janke
97c12b4bbf brew audit: avoid error on head-only formulae 2018-06-15 20:07:02 -04:00
Ilya Dmitrichenko
22d88821c3
Ignore any version of Go, when it is a dependency of a bottle 2018-06-15 11:36:41 -07:00
commitay
c5bbf28dd6 cask dsl versions: add minor_patch 2018-06-15 22:40:33 +10:00
Markus Reiter
44f56a0773 Refactor join("") to join. 2018-06-15 13:56:08 +02:00
Markus Reiter
13d9305fad Cache Tty.width, since it is used heavily because of ohai. 2018-06-15 13:56:08 +02:00
Luca Favatella
ece34dbe26 cask doctor: fix for non-standard installation location in ~
Symptom (relevant portions):
```
$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.6.7-56-g9ebcef7
Homebrew/homebrew-cask (git revision fc24e; last commit 2018-06-09)
==> macOS
10.13.5
==> SIP
Enabled
...
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
~/homebrew/Caskroom
...
==> Environment Variables
HOMEBREW_CASK_OPTS="--appdir=~/Applications"
LC_ALL="en_US.UTF-8"
PATH="/usr/bin:/bin:/usr/sbin:/sbin:~/homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"
Cask's Doctor Checkup: failed
 - The staging path ~/homebrew/Caskroom does not exist.
Error: There are some problems with your setup.
```

Analysis:

* The source code is
  [this](9ebcef785e/Library/Homebrew/cask/lib/hbc/cli/doctor.rb (L63-L66)).

* The issue is reproducible in `brew irb`:

```
$ ls -dl ~/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ ( cd ~ && pwd; )
/Users/luca
$ ls -dl /Users/luca/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ brew irb
==> Interactive Homebrew Shell
Example commands available with: brew irb --examples
irb(main):001:0> Pathname.new("~/homebrew/Caskroom").exist?
=> false
irb(main):002:0> Pathname.new("/Users/luca/homebrew/Caskroom").exist?
=> true
```
2018-06-14 23:58:03 +01:00
Luca Favatella
cac30f6186 cask doctor: delete unused render_* methods 2018-06-14 23:56:35 +01:00
Markus Reiter
502b393d66 Fix tests. 2018-06-14 22:45:20 +02:00