15 Commits

Author SHA1 Message Date
Claudia
fbd526ffe6 Unshadow allow_untrusted option for pkg artifact
The pkg stanza has an option called `allow_untrusted`, which is
supposed to cause `/usr/sbin/installer` to be called with the
`-allowUntrusted` switch.

PR #3141 seems to have renamed the `pkg_install_opts` field to
`options`. At the same time, it introduces an `options` parameter for
the `run_installer` method, which shadows the `options` getter
method, causing the `allow_untrusted` option to be silently ignored.

The issue affects just the `pkg` stanza because `Hbc::Artifact::Pkg`
is the only artifact class that has an `options` method.

This commit removes the shadowing by renaming the field to
`stanza_options`; in one case, it uses `_options` for a parameter
name (instead of the more canonical `_`) for the sake of clarity.
2017-10-02 13:34:57 +02:00
Markus Reiter
53ecdd843f Treat every Artifact instance as a single artifact. 2017-09-10 23:12:32 +02:00
Markus Reiter
df1864ee43 Add CLI::Options DSL. 2017-05-22 02:51:17 +02:00
Mike McQuaid
57db2e539e Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing
changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
2017-05-07 17:28:39 +01:00
Mike McQuaid
ee253e465b Vendor all Homebrew's gems.
Homebrew's actually ended up using a fair few gems. While we want to
avoid Bundler at runtime (and this PR still does that, in fact uses
Bundler even less at runtime than it did before) writing our own version
to use at build-time seems redundant.
2017-05-07 13:52:57 +01:00
Markus Reiter
3b8524d770 Refactor CLI options. 2017-03-07 00:06:34 +01:00
Markus Reiter
e1ea7bb721 Refactor Cask Artifacts. 2017-02-05 07:47:54 +01:00
Kaito Udagawa
df635c8259 cask: compact the code 2016-11-21 04:13:29 +09:00
Kaito Udagawa
0c22cc45e6 cask: Call Tempfile#close(true) with the choices file to ensure it deleted 2016-11-20 14:23:55 +09:00
Kaito Udagawa
2807202103 cask: use Tempfile and some style fixes 2016-11-19 14:52:38 +09:00
Kaito Udagawa
f4a3bc100b cask: add the choices option to pkg stanza
installer command accepts -applyChoiceChangesXML option to change
customize options on the GUI installer from the commandline.
(`man installer` for more detailed information)

The introduced option `choice` enables the choice changes to be supplied
via pkg stanza without tricks in preflight code.
2016-11-19 04:41:21 +09:00
Markus Reiter
ad8ae33c1f Fix spacing and indentation. 2016-10-23 14:32:04 +02:00
Markus Reiter
ddf5583208 Refactor Cask’s extensions. 2016-10-04 15:43:58 +02:00
Markus Reiter
b86c8efb79 Cask: Use nested classes and modules. 2016-09-24 16:00:58 +02:00
AnastasiaSulyagina
e81f4ab7de init 2016-08-19 14:50:14 +03:00