249 Commits

Author SHA1 Message Date
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
commitay
41e27928c4
Merge pull request #4232 from commitay/cask-caveats
cask fetch and upgrade: print caveats
2018-06-21 11:51:29 +10:00
Markus Reiter
25542d7398
Merge pull request #4316 from reitermarkus/merge-search
Merge `brew cask search` into `brew search`.
2018-06-18 21:31:33 +02:00
Markus Reiter
8c620d8b97 Redirect brew cask search to brew search. 2018-06-18 16:23:35 +02:00
Luca Favatella
ece34dbe26 cask doctor: fix for non-standard installation location in ~
Symptom (relevant portions):
```
$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.6.7-56-g9ebcef7
Homebrew/homebrew-cask (git revision fc24e; last commit 2018-06-09)
==> macOS
10.13.5
==> SIP
Enabled
...
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
~/homebrew/Caskroom
...
==> Environment Variables
HOMEBREW_CASK_OPTS="--appdir=~/Applications"
LC_ALL="en_US.UTF-8"
PATH="/usr/bin:/bin:/usr/sbin:/sbin:~/homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"
Cask's Doctor Checkup: failed
 - The staging path ~/homebrew/Caskroom does not exist.
Error: There are some problems with your setup.
```

Analysis:

* The source code is
  [this](9ebcef785e/Library/Homebrew/cask/lib/hbc/cli/doctor.rb (L63-L66)).

* The issue is reproducible in `brew irb`:

```
$ ls -dl ~/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ ( cd ~ && pwd; )
/Users/luca
$ ls -dl /Users/luca/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ brew irb
==> Interactive Homebrew Shell
Example commands available with: brew irb --examples
irb(main):001:0> Pathname.new("~/homebrew/Caskroom").exist?
=> false
irb(main):002:0> Pathname.new("/Users/luca/homebrew/Caskroom").exist?
=> true
```
2018-06-14 23:58:03 +01:00
Luca Favatella
cac30f6186 cask doctor: delete unused render_* methods 2018-06-14 23:56:35 +01:00
commitay
7a48e04d07 internal_audit_modified_casks: remove appcast 2018-06-11 13:15:32 +10:00
commitay
0980de4cb0 _appcast_checkpoint: remove 2018-06-11 13:15:30 +10:00
Markus Reiter
1d27c5f79a Don't create Caskroom.path for tests. 2018-06-09 11:32:49 +02:00
Markus Reiter
767ebe6ab6 Fail brew cask upgrade early if Cask is not installed. 2018-06-09 11:27:44 +02:00
Markus Reiter
488149242b Remove Hbc.init. 2018-06-09 11:18:40 +02:00
Markus Reiter
b2f67c6d77 Remove the need for ensure_cache_exists. 2018-06-09 11:13:37 +02:00
Markus Reiter
12ab263784 Remove Hbc.default_tap. 2018-06-09 10:13:28 +02:00
Markus Reiter
3d423b0587 Add path method to Caskroom and Cache. 2018-06-09 09:52:48 +02:00
Markus Reiter
cb7f25ceb8 Refactor brew cask search. 2018-06-07 18:42:30 +02:00
Markus Reiter
cc93997fb7 Refactor search_taps. 2018-06-07 14:02:31 +02:00
Markus Reiter
dd8370a9fa Move shared search logic into Homebrew::Search module. 2018-06-07 13:50:10 +02:00
Markus Reiter
14b3b82fca Remove exact match from brew cask search. 2018-06-07 13:48:35 +02:00
Markus Reiter
e786bb08c9 Use search_taps in brew cask search. 2018-06-07 13:48:35 +02:00
commitay
a48e42e9dd cask fetch and upgrade: print caveats 2018-06-02 11:31:38 +10:00
Markus Reiter
de246cc528 Update Homebrew-Cask references. 2018-05-25 18:20:02 +02:00
Markus Reiter
c4222141ac Revert "Update Homebrew-Cask references."
This reverts commit 4475651b548afdcf15c4cf7a7cb57baca1885186.
2018-05-25 17:57:32 +02:00
Markus Reiter
4475651b54 Update Homebrew-Cask references. 2018-05-25 17:56:16 +02:00
Markus Reiter
b4de801a01 Support both Homebrew and caskroom for now. 2018-05-21 01:43:49 +02:00
commitay
f2feb326f9 cask upgrade: ensure cache exists 2018-05-18 08:18:39 +10:00
commitay
18cd7b7b4b zap: CaskNotInstalledError 2018-04-29 08:49:02 +10:00
Markus Reiter
19317760da Remove Hbc::Scopes. 2018-04-14 11:45:51 +02:00
Markus Reiter
8d0d5eb6d9 Remove QualifiedToken. 2018-04-14 11:44:19 +02:00
Markus Reiter
8c116f9507 Fix Cask search not showing remote matches. 2018-04-11 16:53:32 +02:00
commitay
9a25ea8ae0 cask doctor: add homebrew_cask_opts 2018-03-23 11:41:46 +10:00
commitay
8d458fa443 cask doctor: check_cached_downloads 2018-02-13 21:03:06 +10:00
Mike McQuaid
918f1b775b
Merge pull request #3631 from amyspark/doctor
Let cask doctor exit with 1
2018-02-12 08:54:47 +00:00
L. E. Segovia
4c5e3d04e1 Fix @reitermarkus's comments 2018-01-29 13:43:21 +00:00
commitay
aa8003103e cask style: fix --fix 2018-01-29 07:45:34 +10:00
Markus Reiter
884c57f9f4 Fix brew cask style on Travis. 2018-01-28 07:00:20 +01:00
commitay
e870c1783f cask doctor: sip status 2018-01-13 08:47:10 +10:00
L. E. Segovia
691caf4b54 Refactor Cask's doctor command
- Remove :failed
- Use Checkable to store the status and warnings/errors
- Refactor the methods using audit as basis
2017-12-02 00:53:54 +00:00
L. E. Segovia
84e41194cb Let Cask doctor exit with 1 via a CaskError 2017-11-30 13:07:58 +00:00
Markus Reiter
3f7e63a24c
Merge pull request #3492 from amyspark/fix-latest-casks
Properly upgrade Casks with version :latest
2017-11-29 15:00:57 +01:00
L. E. Segovia
f3355b2a2c Stage to a different directory if upgrading Casks w/version :latest 2017-11-28 13:03:16 +00:00
Markus Reiter
89845e7f76 Fix _stanza test. 2017-11-28 00:20:29 +01:00
Markus Reiter
f50ae44980
Merge pull request #3396 from amyspark/hacktoberfest-upgrade
Implement `brew cask upgrade`
2017-11-27 23:41:03 +01:00
L. E. Segovia
e0be066f8b Load Casks only once (and fix style issues) 2017-11-24 01:21:30 +00:00
L. E. Segovia
7ee98eb421 Implement more of @reitermarkus's comments
- Simplify outdated Casks checks
- Make use of RSpec's let(:) and .and syntax
2017-11-24 00:48:14 +00:00
Shaun Jackman
0a2bfa66fd Installing casks is supported only on macOS 2017-11-22 10:38:06 -08:00
L. E. Segovia
7ce4319012 Upgrade an outdated Cask just by name, no need for --greedy 2017-11-22 16:27:13 +00:00
Markus Reiter
a869ce0143
Merge pull request #3371 from commitay/cask-doctor
Cask doctor: add macOS & Java versions
2017-11-22 10:32:17 +01:00
L. E. Segovia
c9b5de4cab Output message if no Casks are outdated 2017-11-22 00:45:29 +00:00
L. E. Segovia
8ee6ac2613 Implement @reitermarkus's comments
- Split move into a move_back (and clarify when it is used)
- Remove unused flags
- Raise error if installed Caskfile not found
- Error out if an upgrade fails
- Remove some defensive programming checks
2017-11-16 10:40:32 -03:00
L. E. Segovia
36fe355159 Add tests for upgrade recovery 2017-11-13 08:46:08 -03:00