76 Commits

Author SHA1 Message Date
Markus Reiter
488149242b Remove Hbc.init. 2018-06-09 11:18:40 +02:00
Markus Reiter
458a1e7903 Remove Locations module. 2018-06-09 09:01:09 +02:00
Chayoung You
b05d69f600
Format identifiers in oh1 2018-02-09 18:00:29 +09:00
Markus Reiter
3f7e63a24c
Merge pull request #3492 from amyspark/fix-latest-casks
Properly upgrade Casks with version :latest
2017-11-29 15:00:57 +01:00
L. E. Segovia
96187ade92 Leftover of @reitermarkus's comments
Simplify a condition
2017-11-29 01:11:30 +00:00
L. E. Segovia
ab62be5345 Implement @reitermarkus's comments
Leftover && and remove xattr "copy"
2017-11-29 01:02:50 +00:00
L. E. Segovia
657d4eaee9 Remove unused backup and metadata logic 2017-11-28 23:55:05 +00:00
L. E. Segovia
63961ac465 Fully separate purge_versioned_files 2017-11-28 21:00:16 +00:00
L. E. Segovia
5840b2fa68 Rename purge_backed_versioned_files to purge_backed_up_versioned_files 2017-11-28 20:36:36 +00:00
L. E. Segovia
9227c8fe3c Try #2 at handling backed up Casks
Avoid using variables altogether; fork out the purge into two
specialized + one common function
2017-11-28 18:03:57 +00:00
L. E. Segovia
9458e985b7 Always backup the old Cask prior to upgrade
(and if doing so, correctly set the staged_path when purging it)
2017-11-28 17:37:36 +00:00
L. E. Segovia
2ff114bc32 Use the proper path when purging metadata 2017-11-28 14:29:53 +00:00
L. E. Segovia
8386b9384c Solve styling and metadata issues 2017-11-28 13:34:50 +00:00
L. E. Segovia
f3355b2a2c Stage to a different directory if upgrading Casks w/version :latest 2017-11-28 13:03:16 +00:00
Markus Reiter
1948729ec8 Refactor caveats and add kext caveat. 2017-11-28 00:20:29 +01:00
L. E. Segovia
8ee6ac2613 Implement @reitermarkus's comments
- Split move into a move_back (and clarify when it is used)
- Remove unused flags
- Raise error if installed Caskfile not found
- Error out if an upgrade fails
- Remove some defensive programming checks
2017-11-16 10:40:32 -03:00
L. E. Segovia
8cc1aea5f0 Implement @reitermarkus's upgrade flow 2017-11-11 17:21:13 -03:00
L. E. Segovia
72e673afae Fix reinstall/uninstall tests 2017-11-10 11:33:44 -03:00
L. E. Segovia
522a229dbb Fix upgrade tests and some upgrade? leftovers 2017-11-08 08:33:33 -03:00
L. E. Segovia
94d266e2d6 Rework uninstallation step
Now the artifacts get re-staged, and upon an uninstall/finalize_upgrade
they are deleted by purge_versioned_files instead
2017-11-06 21:27:02 -03:00
L. E. Segovia
84c128411f Fix style issues 2017-11-06 18:33:29 -03:00
L. E. Segovia
7f2e4f583a Finalize metadata handling and uninstall logic 2017-10-30 23:29:00 -03:00
L. E. Segovia
55727b7895 Hack a first working version of upgrade 2017-10-29 17:34:53 -03:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Markus Reiter
5cbf8bdaa7 Merge pull request #3283 from reitermarkus/cask-loader
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 18:30:32 +02:00
Markus Reiter
97333df4cb Add helper method for Cask fixture paths and refactor CaskLoader. 2017-10-07 16:11:25 +02:00
Markus Reiter
51a0de6368 Directly save artifacts in DSL. 2017-10-04 18:47:55 +02:00
Mike McQuaid
01e9ec9a9f Rubocop: automatic rule fixes. 2017-09-24 21:23:59 +01:00
Markus Reiter
53ecdd843f Treat every Artifact instance as a single artifact. 2017-09-10 23:12:32 +02:00
Markus Reiter
67327c75b5 Implement conflicts_with :cask. 2017-08-05 16:19:50 +02:00
Markus Reiter
eb110e94f0 Merge pull request #2772 from reitermarkus/dmg-eula
Fix DMG mounting.
2017-07-02 02:04:07 +02:00
Markus Reiter
6a1fa87191 Refactor Formula/Cask dependencies. 2017-06-30 02:20:50 +02:00
Markus Reiter
3b4ee58c49 Refactor using Forwardable and DelegateClass. 2017-06-28 09:25:31 +02:00
Markus Reiter
80f827e926 Print DMG EULA when --verbose. 2017-06-14 02:06:25 +02:00
Markus Reiter
66ce575301 🔨 Refactor Cask exceptions. 2017-06-13 17:14:28 +02:00
Markus Reiter
38b5e4254b Fix uninstall order. 2017-05-23 15:37:55 +02:00
Markus Reiter
df1864ee43 Add CLI::Options DSL. 2017-05-22 02:51:17 +02:00
Markus Reiter
9e821863d0 Pass along CLI::Binaries. 2017-05-22 02:51:16 +02:00
Markus Reiter
cb17a80577 Merge pull request #2362 from joshka/install-uninstall-messages
Install uninstall messages
2017-04-23 02:40:52 +02:00
Markus Reiter
1cd125e7e7 Refactor cask metadata directory methods. 2017-04-21 01:28:21 +02:00
Joshua McKinney
cb28ab640e Refactor uninstall existing cask 2017-04-18 01:49:54 -07:00
Joshua McKinney
a90d1e1699 Installer#reinstall instead of #install :reinstall
Call an explicit method on Installer to reinstall rather than using a
flag to indicate when we're reinstalling a cask
2017-03-27 01:32:53 -05:00
Joshua McKinney
3703ef1885 Show messages when (un)installing Casks
Addresses an issue where it can be unclear at times exactly which part
of the (un|re)installation processes is reporting an error. See
https://github.com/caskroom/homebrew-cask/issues/30968
2017-03-19 13:14:16 -05:00
Joshua McKinney
367fdb9718 Refactor brew cask reinstall
The implementation of the reinstall command was the same as
Installer#install, aside from the uninstall of the existing cask.
Moved this within the class to DRY up the implementation.
2017-03-19 13:14:16 -05:00
Markus Reiter
ed10135da4 Replace Hbc.load with CaskLoader.load. 2017-03-16 19:16:42 +01:00
Markus Reiter
31d7d6e5f3 Remove old metadata when installing with --force. 2017-03-11 21:09:13 +01:00
Markus Reiter
2a21991b1f Make sure uninstall is called before artifacts are removed. 2017-02-16 17:12:38 +01:00
Markus Reiter
486fa0bf19 Fix uninstall also running zap. 2017-02-10 07:49:21 +01:00
Markus Reiter
4a4a162223 Let Artifact::for_cask return artifact instances. 2017-02-07 00:07:59 +01:00
Markus Reiter
e1ea7bb721 Refactor Cask Artifacts. 2017-02-05 07:47:54 +01:00