108 Commits

Author SHA1 Message Date
Mike McQuaid
9fca172d03 Fix HOMEBREW_RUBY_WARNINGS="-w"
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Shaun Jackman
5500c3b25e unzip_dep_if_needed: Needs unzip not zip [Linux] (#632) 2018-03-05 11:51:08 -08:00
Maxim Belkin
f8874004c2 Make 'xz' and 'cvs' dependencies conditional 2018-02-21 14:11:35 +00:00
Maxim Belkin
306c19061e Code refactoring v2.0 2018-02-19 09:58:30 +00:00
Maxim Belkin
d25fc5ce50 Code refactoring 2018-02-19 09:54:36 +00:00
Maxim Belkin
b084a2581f Making zip and bzip2 dependecies conditional
Here, we are adding `unless which("zip")` and `unless which("bzip2")`
and, thus, make `zip` and `bzip2` dependencies conditional.
2018-02-19 07:21:34 +00:00
Maxim Belkin
3dabebbd16 Refactoring based on suggestions
Defaulting zip_dep_if_needed(tags) and bzip2_dep_if_needed(tags)
methods to those on Linux and overriding them on macOS.
2018-02-19 06:49:42 +00:00
Maxim Belkin
5a92976120
Fixing brew-style offenses 2018-02-16 10:49:43 -06:00
Maxim Belkin
444b292df9
zip and bzip2 dependencies when needed
On some systems identified as Linux, zip and bzip2 might
not be available. Therefore, on such platforms we add them
unconditionally as dependencies when required. On Mac, these
dependencies are always satisfied.
2018-02-16 10:41:14 -06:00
Mike McQuaid
27be33b245 Deprecate Git, Subversion requirements.
These rely on `default_formula` to be useful and are better following
the `*_dep_if_needed` pattern.
2018-01-10 13:19:50 +00:00
Shaun Jackman
5d9149a4b9 LD64Dependency is needed on macOS only
Move ld64_dependency.rb to os/mac/.
2018-01-03 10:52:12 -08:00
Mike McQuaid
d54e670a64 requirements: move more to compat. 2017-12-30 20:56:55 +00:00
Mike McQuaid
05329fc08d dependency_collector: don't use hg alias. 2017-12-29 17:51:02 +00:00
Mike McQuaid
38ce994007 Deprecate more requirements.
These are ones that were either already deprecated due to audit rules
or are just a simple `which` with a `default_formula` so should just
be a dependency.
2017-12-23 16:53:25 +00:00
Mike McQuaid
5b178c2892 dependency_collector: cleanup optional system deps 2017-12-23 16:36:33 +00:00
Shaun Jackman
baa3d187d6 Add CVSRequirement and SubversionRequirement
Use these two requirements in DependencyCollector.
Remove the unused function MacOS::Xcode.provides_cvs?
2017-11-25 09:45:08 -08:00
Shaun Jackman
230c87aff0 Rename MinimumMacOSRequirement to MacOSRequirement
Move MinimumMacOSRequirement to compat.
2017-10-17 16:16:44 -07:00
Shaun Jackman
95e144a1c8 Add depends_on :linux and :macos 2017-10-17 16:16:12 -07:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Bob W. Hogg
227e69048a dependency_collector: Make ant_dep and xz_dep public
They were already public on macOS, but they were made
private by mistake on all other platforms.
DependencyCollector.tar_needs_xz_dependency? depends
on xz_dep being public, so there's no turning back now :(
2016-11-28 03:09:34 +00:00
Mike McQuaid
b1a16deb19 Use BSD tar's libarchive LZMA support if available
Avoid using an unnecessary `xz` dependency when it's not needed.
2016-10-15 13:10:37 +01:00
Mike McQuaid
26e4899fde Deprecate apr requirement.
It's not used on enough configurations now that there's little point in
keeping it around. See e.g. `:autoconf` for prior art.
2016-10-12 15:37:33 +01:00
Markus Reiter
58e36c7319 Fix Style/GuardClause. 2016-09-24 12:24:35 +02:00
Markus Reiter
42efb44e7d Fix Lint/EndAlignment. 2016-09-23 15:30:06 +02:00
Markus Reiter
52ff988530 Fix RuboCop CaseEquality. 2016-09-23 15:30:06 +02:00
Bob W. Hogg
1de9f3baf3 make linux behaviour the default. override only for macos 2016-09-22 17:47:50 -04:00
Bob W. Hogg
01b93117cd move os checks to extend/os 2016-09-22 08:31:50 -04:00
Bob W. Hogg
f65217f61e Oops, forgot to rename it in-code 2016-09-22 08:31:50 -04:00
Bob W. Hogg
0a4bc8494d switch to using extend pattern 2016-09-22 08:31:50 -04:00
Bob W. Hogg
54a086e2fe dependency_collector: Fix ant_dep for Linux.
Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2016-09-22 08:31:50 -04:00
Mike McQuaid
6693915399 rubocop --auto-correct all remaining files.
But remove some manual `.freeze`s on constants that shouldn't be
constants.
2016-09-17 16:14:13 +01:00
Dominyk Tiller
e02ad2242a
gpg_requirement: rename to gpg2_requirement 2016-08-13 03:33:33 +01:00
Dominyk Tiller
7d57119837 dependency_collector: add perl
Closes #184.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-05-03 18:52:40 +01:00
Misty De Meo
2f7721f1b4 Add :expat special dependency
This will be expanded to a full expat dependency on Tiger alone.

Fixes mistydemeo/tigerbrew#30.
2016-04-22 22:37:21 -07:00
Dominyk Tiller
c9097b40f9 dependency_collector: add rbenv
Closes Homebrew/homebrew#47897.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-01-09 15:53:05 +00:00
Misty De Meo
c6f45a9e06 DependencyCollector: add lua51 language module 2016-01-01 20:10:34 -04:00
Misty De Meo
575b75fced LanguageModuleRequirement: remove jruby support 2016-01-01 20:10:34 -04:00
Misty De Meo
aa1461b7d6 LanguageModuleRequirement: remove ocaml support 2016-01-01 20:10:34 -04:00
Misty De Meo
36cef3c974 LanguageModuleRequirement: remove node support 2016-01-01 20:10:34 -04:00
Misty De Meo
1ad2aeef86 LanguageModuleRequirement: remove chicken support 2016-01-01 20:10:34 -04:00
Misty De Meo
d4db443b19 LanguageModuleRequirement: remove rbx support
This test wasn't running by default, so we missed that it wasn't
actually being executed - or that it was failing when running in the
testing environment.

As far as I can tell this is not, and has not, been used either in core
or in any tap, third party or otherwise, so just remove the feature and
its test.
2016-01-01 20:10:34 -04:00
Misty De Meo
00c51a2480 DependencyCollector: infer dep for .lzh archives
Refs Homebrew/homebrew-games#383.
2015-12-31 19:48:07 -04:00
Xu Cheng
d108bf0a55 move more deprecated methods to compat folder 2015-11-17 18:52:00 +08:00
BrewTestBot
13d544e11e Core files style updates.
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Jack Nagel
7c83e3ffe3 Remove workarounds for destructuring single-element hashes 2015-06-19 22:30:13 -04:00
Mike McQuaid
1e86730289 Rename requirements named *Dependency.
Dependency is another similar, related class and it's super confusing
to have some Requirements that are named *Dependency.

Closes Homebrew/homebrew#38891.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-06-16 08:12:01 +01:00
Alex Dunn
dba9675ed3 add EmacsRequirement
Closes Homebrew/homebrew#39326.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-05-08 14:37:15 +08:00
Mike McQuaid
305ced5360 Add RubyRequirement. 2015-04-21 09:33:41 +01:00
Tim D. Smith
ac16822a16 Prioritize TapDependency in parse_string_spec
test-bot expects the dependencies returned from SoftwareSpec#deps to
satisfy is_a?(TapDependency) if they come from a tap which might need to
be tapped.
2015-04-09 00:42:51 -07:00
Tanachat Nilanon
e97fac1dd6 add :python3 to LANGUAGE_MODULES
Add special :python3 dependency tag to LANGUAGE_MODULES in
dependency_collector.

Closes Homebrew/homebrew#37898.

Signed-off-by: Tim D. Smith <git@tim-smith.us>
2015-03-19 23:04:35 -07:00