142 Commits

Author SHA1 Message Date
Maxim Belkin
e5435dfeb7
Cross-platform diagnostics. 2018-05-14 04:44:15 -05:00
Mike McQuaid
d331c47de0 diagnostic: remove check_user_curlrc check. 2018-04-08 16:07:21 -07:00
Mike McQuaid
7095738d1d Remove config/doctor checks we no longer need
A bunch of these were needed before superenv, environment filtering or
on now long-unsupported versions of macOS.
2018-04-02 09:40:39 +01:00
Mike McQuaid
046ebfb647 diagnostic: general cleanup. 2018-03-27 14:52:47 +01:00
Mike McQuaid
bdb86640e9 diagnostic: remove python pth check.
This isn't an issue with Homebrew but an issue for users to configure
themselves. It's also nonsensical with current Python configurations
e.g. https://discourse.brew.sh/t/brew-doctor-warnings-about-python-3-6-site-packages-and-sitecustomize/1805/1
2018-03-09 14:54:52 +00:00
Mike McQuaid
e03f07f302 Rubocop 0.53.0 automatic fixes. 2018-03-08 14:10:02 +00:00
Mike McQuaid
70253f0009 Adjust docs and more internal code for Python 3.
Now we have `python` for Python 3 and `python@2` for Python 2 some more
adjustments need to be made.
2018-03-03 09:42:25 +00:00
Markus Reiter
c09a0972e5
Merge pull request #3774 from sbol-coolblue/fix-formula-formulae
Grammar: "formula are" -> "formulae are"
2018-02-13 18:10:23 +01:00
ilovezfs
0efe63402b diagnostic: remove cache size check 2018-02-13 01:57:20 -08:00
Mike McQuaid
a30c74987a brew, diagnostic: tweak CI variable checks.
I've adjusted test-bot in:
603918939a
to set CI=1 for Jenkins to make future JENKINS_HOME checks unnecessary.

The only `TRAVIS_*` variable we care about is `TRAVIS_SUDO` so whitelist
that specifically rather than passing through loads of others.
2018-02-12 16:41:21 +00:00
Dominyk Tiller
51ed7983a5
diagnostic: guard cache check on Jenkins too 2018-02-12 10:11:45 +00:00
Dominyk Tiller
f97d8e3905
diagnostic: implement cache size check 2018-02-11 17:05:13 +00:00
Sander Bol
14a25bdd69
Grammar: "formula are" -> "formulae are"
Fix plural form of formula in `brew doctor` output.
2018-02-07 09:50:01 +01:00
Simon B
53d87d3b58 fix broken sentence 2018-01-21 12:49:59 +01:00
Mike McQuaid
6b9ca5dbf5 Remove some unset/checked environment checks
These will be redundant once environment filtering is on by default
in #3529.
2017-12-08 16:33:33 +00:00
Louis Bergelson
2abf2a6a79 whitelisting additional SentinelOne dylib pattern
it seems like SentinelOne is now using dylibs that include a number, possibly randomized in some way
this causes brew doctor to give a warning, but it should probably be ignored like the previous versions of the sentinel dylib

updating diagnostic.rb to include a new pattern to ignore dylibs of the form sentinel-*.dylib
2017-11-28 17:34:16 -05:00
Mike McQuaid
9ebf338804 diagnostic: fix paths usage.
- Don't allow taking an argument. This doesn't work and never has as it
  caches the result regardless of the argument.
- Don't rely on the PATH to check for external commands.
2017-11-17 17:41:58 +00:00
Markus Reiter
526299913f Remove usless comments. 2017-10-24 19:39:40 +02:00
Dominyk Tiller
212367ee7e
diagnostic: handle APFS returning hash order 2017-10-20 22:44:11 +01:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Mike McQuaid
3a606abaa1 Merge pull request #3229 from BenMusch/check-for-master-no-refactor
doctor: Check for branch of core tap (take 2)
2017-10-18 10:59:59 +01:00
Dominyk Tiller
16ea29a641
diagnostic: pass explicit sort to handle APFS 2017-10-14 06:35:25 +01:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Mike McQuaid
a8ca47d294 diagnostic: remove unnecessary blank line. 2017-10-01 19:07:10 +01:00
Mike McQuaid
7974ce24b6 Fix regex style 2017-09-28 20:10:06 +01:00
Ben Muschol
2d6bd04007 Merge branch 'master' into check-for-master-no-refactor 2017-09-27 16:36:10 -04:00
Ben Muschol
fe5c885da0 Implement changes 2017-09-27 16:32:13 -04:00
Mike McQuaid
01e9ec9a9f Rubocop: automatic rule fixes. 2017-09-24 21:23:59 +01:00
ilovezfs
204f370491 Revert "Add check for HEAD ref in diagnostics" 2017-09-18 14:49:10 -04:00
ilovezfs
8b91018c70 Revert "diagnostic: don't check CI core branch."
This reverts commit cb5b14307ca4640e1ba68cfd28e7fef34a3b771b.
2017-09-18 14:49:10 -04:00
ilovezfs
6fab5b0976 Revert "diagnostic: also don't check Jenkins core branch."
This reverts commit db41f9d1182ff8c4c3b42b458e38d5c58b496ffb.
2017-09-18 14:49:10 -04:00
ilovezfs
78a742c1ff Revert "Add check for HEAD ref in diagnostics" 2017-08-26 10:15:35 -07:00
ilovezfs
784a85f885 Revert "diagnostic: don't check CI core branch."
This reverts commit cb5b14307ca4640e1ba68cfd28e7fef34a3b771b.
2017-08-26 10:14:23 -07:00
ilovezfs
b1e0998f58 Revert "diagnostic: also don't check Jenkins core branch."
This reverts commit db41f9d1182ff8c4c3b42b458e38d5c58b496ffb.
2017-08-26 10:13:43 -07:00
Mike McQuaid
db41f9d118 diagnostic: also don't check Jenkins core branch. 2017-08-26 14:50:55 +01:00
Mike McQuaid
cb5b14307c diagnostic: don't check CI core branch. 2017-08-26 14:44:26 +01:00
Ben Muschol
7b31dd6062 Prefer if over unless, simplify messaging 2017-08-26 08:25:08 -04:00
Ben Muschol
b351c3f3ff Fix method name 2017-08-25 21:04:23 -04:00
Ben Muschol
abe47b79c8 Add check for HEAD ref in diagnostics 2017-08-25 20:25:58 -04:00
Mike McQuaid
bd06a7926c diagnostic: use ENV[] 2017-07-20 20:02:34 +01:00
Justin Baugh
0a9de6b8a6 Update source check to match style 2017-07-20 14:44:20 -04:00
Justin Baugh
e077bfe655 Address rubocop issues 2017-07-20 11:57:43 -04:00
Justin Baugh
7504d830cb Add warning to doctor if HOMEBREW_BUILD_FROM_SOURCE is set. 2017-07-20 11:08:53 -04:00
Wang Boyu
89d2cc00da diagnostic: Update whitelisted dylib used by Symantec (again) 2017-06-22 16:00:54 +08:00
Wang Boyu
803c5c3afe diagnostic: Update whitelisted dylib used by Symantec 2017-06-22 10:02:35 +08:00
Mike McQuaid
370eeed2e4 diagnostic: quiet some CI whining.
We want to be able to symlink Homebrew/test-bot to Homebrew/core on
Linux for CI speed.
2017-06-17 14:01:42 +01:00
Baptiste Fontaine
569180dfe5 diagnostic: Fix suggested git remote commands 2017-06-14 17:26:35 +02:00
Mike McQuaid
7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
ilovezfs
197392b56d Revert "Fix operator spacing." 2017-06-01 04:06:40 -07:00