30 Commits

Author SHA1 Message Date
Markus Reiter
487bec9570 Move String#undent to compat. 2017-10-18 14:39:09 +02:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Josh Soref
08e53870a6 spelling: definitions 2017-09-10 16:31:02 +00:00
Misty De Meo
ffa65c7498
String: backport #match? from 2.4.0 2017-06-03 20:47:39 -07:00
Mike McQuaid
4356016b4a Use parallel RuboCop
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
2017-05-29 18:42:02 +01:00
Markus Reiter
58e36c7319 Fix Style/GuardClause. 2016-09-24 12:24:35 +02:00
Markus Reiter
e851c9bf6c Style/Alias: Prefer alias. 2016-09-23 18:19:53 +02:00
Xu Cheng
9755662e49 add String#strip_prefix 2015-12-03 13:46:58 +08:00
William Woodruff
b0d5e17906 tweak String#undent so that only leading whitespace up to the first indentation level is gsubbed, change test_undent to reflect change and add test_undent_nested to test new behavior 2015-08-28 18:02:04 +08:00
BrewTestBot
13d544e11e Core files style updates.
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Jack Nagel
ec1727a1be Remove backports for Ruby 1.8.6
refs. Homebrew/linuxbrew#438, mistydemeo/tigerbrew#327,
mistydemeo/tigerbrew#334
2015-06-19 22:20:47 -04:00
Jack Nagel
aaaab946ec Make inreplace errors fatal
Closes Homebrew/homebrew#32649.
Closes Homebrew/homebrew#32703.
2014-09-28 01:11:31 -05:00
Jack Nagel
cb69f339b8 Intercept calls to sub! in inreplace blocks 2014-09-27 19:11:40 -05:00
Jack Nagel
e409aa3084 Clean up inreplace regexps
- use literal syntax
 - escape interpolated variables
 - remove intermediate variables
 - remove unnecessary capture
2014-09-26 22:35:37 -05:00
Baptiste Fontaine
74e4fdfce2 Fix for String#undent
Without it, String#undent would fail on unindented strings, e.g.:

    "foo".undent

NoMethodError: undefined method `length' for nil:NilClass`

Closes Homebrew/homebrew#28873.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-05-02 19:50:27 -07:00
Misty De Meo
38e26ed929 extend/string: backport #rpartition 2014-03-27 10:14:08 -07:00
Jack Nagel
8e0158b4d7 Add String#end_with?
I'm tired of not remembering if start_with?/end_with? are portable, so
just add them both if they're not defined.
2013-07-19 22:32:57 -05:00
Jack Nagel
b1e5f5ee81 Fix String#start_with? implementation
It is supposed to accept a variable number of prefixes, and also to
check if they are convertible to strings. This matches behavior
documented in RubySpec.
2013-07-19 22:31:07 -05:00
Jack Nagel
b8b014036e Remove redundant return 2013-02-15 00:36:03 -06:00
Jack Nagel
9fd5953ed9 Make this more idiomatic 2013-02-15 00:35:52 -06:00
Max Howell
50767c6077 Record HEAD SHA and date of installs in receipt 2012-08-29 12:41:33 -04:00
Max Howell
3dec84de8a Improve libiconv diagnostic and suggestion
This is coming up a lot at the moment, so here is an attempt to be more helpful.
2012-08-14 11:46:18 -04:00
Adam Vandenberg
42d44053ef inreplace: also warn on plain gsub! usage 2012-02-25 22:41:20 -06:00
Jack Nagel
a3edec8b88 inreplace: warn if no substitutions were made
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-25 22:37:29 -06:00
Trevor Wennblom
55791d4c10 Coerce flags to an array in remove_make_var!
This is needed for Ruby 1.9.x compatibility, but we still don't support
running Homebrew with anything other than a system provided 1.8.[67].

Fixes Homebrew/homebrew#6546

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-07-27 17:38:26 -07:00
Adam Vandenberg
e6bac8a8ea back-port start_with? from 1.8.7
This allows its use in Leopard, which has Ruby 1.8.6.
2011-06-19 21:32:37 -07:00
Adam Vandenberg
b13baedfd8 Move string extensions 2011-03-12 11:55:03 -08:00
Jamie Macey
1e41264f42 fix warnings: ambiguous first arg
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2010-10-30 14:47:44 -07:00
Michael Morgan
3ea550100f extract undent test to test case
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2010-10-17 21:13:16 -07:00
Max Howell
799dd7108e String.undent for prettier HEREDOCs 2010-03-07 17:57:05 +00:00