Andrew Janke
e0a8a79921
Style fixes for Rubocop 0.57.1
2018-06-30 19:40:14 -04:00
Mike McQuaid
05568420c0
linkage_checker: fix cache invalidation.
...
Rather than using the name of the keg for the key use the full path.
This provides several advantages:
- there's no need to invalidate the cache on a `brew upgrade` or
`brew switch`
- it's easier to figure out what cache entries can be removed and this
can be done whenever a keg is removed by `brew uninstall` or
`brew cleanup`.
Also, ensure that an `install` (or `reinstall`, `upgrade`) always
results in the cache being rebuilt for that keg (in case different
options were used).
2018-06-06 13:30:45 +01:00
Mike McQuaid
0a00312b71
Autocorrect new RuboCop 0.55.0 style violations.
2018-04-17 10:54:58 +01:00
Mike McQuaid
3994d5937d
keg: don't remove versioned aliases on unlink.
...
Fixes #4030 .
2018-04-08 16:02:02 -07:00
Mike McQuaid
9fca172d03
Fix HOMEBREW_RUBY_WARNINGS="-w"
...
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Mike McQuaid
5dfa0cf622
keg: delete bad tap opt non-symlink directories.
...
But don't delete them if they are a symlink to a directory i.e. a normal
opt link.
Handles the issue mentioned in
1651647a3d (r28360427)
2018-04-01 09:27:49 +01:00
Mike McQuaid
8975bf0d5b
keg: use Formula#runtime_dependencies.
2018-03-27 14:52:48 +01:00
Mike McQuaid
a7727b66b3
keg: add tab, runtime_dependencies methods.
2018-03-27 14:52:47 +01:00
Mike McQuaid
9c8adb4ac0
keg: delete __pycache__ directory.
2018-03-18 18:48:43 +00:00
Mike McQuaid
6788e78c03
Revert "keg: tweak delete_pyc_files!"
...
This reverts commit 8e928992f5d2a1bbc39b295e2d2a9a2565ecec2a.
2018-03-08 09:18:52 +00:00
Mike McQuaid
e906ec374b
Revert "keg: fix delete_pyc_files path typo."
...
This reverts commit 948b1b8dbeb7bce35d5b0ecc45b14ac50d4eee93.
2018-03-08 09:18:49 +00:00
Mike McQuaid
1d708d77cb
Merge pull request #3892 from lembacon/pycache
...
keg: `delete_pyc_files!` should also remove `__pycache__`
2018-03-08 09:02:09 +00:00
Mike McQuaid
948b1b8dbe
keg: fix delete_pyc_files path typo.
2018-03-08 08:37:34 +00:00
Mike McQuaid
8e928992f5
keg: tweak delete_pyc_files!
2018-03-08 08:17:57 +00:00
ilovezfs
f87a589129
keg: don't delete main opt links of other formulae.
...
If an old alias, according to the tab, of a formula being upgraded (e.g.
python) has the same name as the main opt link of some other formula
(e.g. python@2), don't remove the main opt link of that other formula.
Specifically,
brew install python@2
brew upgrade python
should not accidentally delete /usr/local/opt/python@2 even though
python@2 used to be an alias of python.
2018-03-07 22:35:23 -08:00
Chongyu Zhu
3db033ca89
keg: delete_pyc_files!
should also remove __pycache__
2018-03-08 13:02:03 +08:00
Mike McQuaid
1f48e17f1b
rubocop: fix brew style warnings.
2018-01-17 10:42:43 +00:00
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Mike McQuaid
01e9ec9a9f
Rubocop: automatic rule fixes.
2017-09-24 21:23:59 +01:00
Mike McQuaid
e862bcbc32
keg: cleanup aliases correctly.
...
This was missed when I was focused on cleaning up versioned aliases.
Fixes #2992 .
2017-08-05 18:03:04 +01:00
Mike McQuaid
1651647a3d
keg: correctly cleanup old aliases.
...
Cleanup old, versioned aliases and tap aliases folders when unlinking
or uninstalling a keg.
2017-07-28 11:41:12 +01:00
Markus Reiter
2d6ae61314
Re-revert "Fix operator spacing."
2017-06-02 19:22:05 +02:00
ilovezfs
197392b56d
Revert "Fix operator spacing."
2017-06-01 04:06:40 -07:00
Markus Reiter
d34ba7395b
Fix operator spacing.
2017-05-31 19:53:41 +02:00
Mike McQuaid
7a38bab333
Fixup all RuboCop warnings.
2017-05-29 18:43:18 +01:00
Markus Reiter
060af0a26a
Rename FormulaLock
to LockFile
.
2017-05-25 06:18:52 +02:00
Mike McQuaid
76f48d338e
keg: skip opt versioned aliases for devel/head.
...
These versioned aliases don’t correspond to the correct version if not
Installed from stable.
Fixes #2596 .
2017-05-09 15:10:57 +01:00
Mike McQuaid
82858176f0
keg: correctly remove alias symlinks.
...
Fixes #2427 .
2017-04-01 16:33:24 +01:00
Alex Dunn
00af5250f0
caveats: combine completion and function messages
...
Fixes https://github.com/Homebrew/homebrew-core/issues/10338 .
Closes #2287 .
Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
2017-03-19 16:32:23 -07:00
Mike McQuaid
4991039809
keg: resolve rack aliases correctly.
...
Don't use the basename but instead use the Formulary logic for rack
formula resolution.
Fixes #2288 .
2017-03-08 08:51:41 +00:00
Naoto Kaneko
ccc9b2dc6d
Check for metafiles only in the root directory
2017-02-24 17:44:27 +09:00
Naoto Kaneko
d4df9d44e0
Exclude executables from metafiles
...
Exclude executables in #empty_installation? to avoid 'Empty
Installation' error when only executable which name is the
same as one of metafiles is installed.
2017-02-23 16:49:14 +09:00
Mike McQuaid
1ea79cd0b3
keg: handle missing alias opt link on uninstall.
...
Fixes an issue introduced in #1192 where there would be a failure if the
alias link didn't exist on removal (which would be the case for anything
with an alias installed before #1192 was merged).
2017-02-21 18:31:34 +00:00
Mike McQuaid
dfa2c247e0
keg: simplify code, handle exceptions.
2017-02-20 14:23:01 +00:00
ilovezfs
63295fd81a
have opt alias symlink point into the Cellar
...
in case people expect to be able to find the prefix by only resolving
the symlink once (e.g., if they're using readlink not realpath)
2017-02-20 14:14:04 +00:00
ilovezfs
4c922a089b
remove unless empty since each is no-op for empty
2017-02-20 14:14:03 +00:00
ilovezfs
14ef15f591
keg: create symlinks in opt for formula aliases
2017-02-20 14:14:03 +00:00
Markus Reiter
94dceeab1d
Move require_relocation?
from os/mac/keg
to keg
.
2017-02-11 13:43:00 +01:00
ilovezfs
67bdeb463a
Revert "Use Open3
for integration tests instead of manually forking."
2017-02-10 19:28:40 -08:00
Markus Reiter
cedc46c64b
Use false
instead of # no-op
.
2017-02-09 18:40:20 +01:00
Markus Reiter
956daf37a0
Use Open3
for integration tests instead of manually forking.
2017-02-09 17:17:48 +01:00
Alyssa Ross
245944d359
keg: use Forwardable to methods delegated to #path
2017-01-19 17:06:38 +00:00
Alyssa Ross
34e13fc527
keg: don't conditionally switch alias target
...
This seems to be a remnant of Ruby 1.8.
2017-01-19 17:06:38 +00:00
Mike McQuaid
c0a29d6644
caveats, keg: remove linkapps caveats code.
2017-01-09 14:10:26 +00:00
Mike McQuaid
4497190593
keg: use resolved_path not realpath.
...
This guards against this being a non-symlink in which case it will fail.
2017-01-06 16:35:41 +00:00
Mike McQuaid
fc11f633b2
Merge pull request #1677 from MikeMcQuaid/formula-prefix-opt
...
formula: make prefix usually return opt_prefix.
2017-01-03 20:10:22 +00:00
Alyssa Ross
e4856143a6
keg: check installed dependencies iff optlinked
2017-01-01 14:27:24 +00:00
Alyssa Ross
94ead55772
keg: keg_only kegs can have installed dependents
2017-01-01 14:26:28 +00:00
Alyssa Ross
05b85a7bef
keg: update installed dependency resolution
...
Closes #1525 . (See there for a motivation for this change.)
2017-01-01 14:26:28 +00:00
Alyssa Ross
8b30abe060
keg: handle dependencies of moved/renamed formulae
...
In #1497 I switched from Keg#to_formula for comparing kegs to formulae
to comparing the name and tap in the keg's tab to the name and tap of
the formula.
However, this fails to match if the name and tap of the formula have
changed since the keg was installed, so it's clearly better to use
Keg#to_formula where possible, and fall back to the information in the
tab when #to_formula can't be used.
2016-12-31 17:53:06 +00:00