153 Commits

Author SHA1 Message Date
Gautham Goli
ffb4fe7041 DependencyOrder: Fix var initialization bug 2018-06-30 15:24:53 +05:30
Mike McQuaid
5e6c40e28f Make versioned formulae regex more consistent.
Share the regex where possible and otherwise ensure they are identical.
2018-06-18 14:36:51 +01:00
Markus Reiter
44f56a0773 Refactor join("") to join. 2018-06-15 13:56:08 +02:00
Markus Reiter
b9ba631982 Support constants in DependencyOrder cop. 2018-06-11 04:23:52 +02:00
commitay
3329a9f6d8 text_cop: require cargo to use install instead of build 2018-06-10 16:42:19 +10:00
commitay
490dc9118e text_cop: require dep ensure to use -vendor-only 2018-06-08 00:42:57 +10:00
commitay
1a4340161c options_cop: formula -> formulae 2018-06-02 16:56:55 +10:00
Markus Reiter
a0ca601a1a Silence Parser compatibility warning. 2018-05-26 16:24:48 +02:00
commitay
9d55fed15f audit: new formulae should not have options 2018-05-22 19:39:14 +10:00
Gautham Goli
efec2fa0c5 lines_cop: Add deprected options audit for depends_on 2018-05-06 15:42:51 +05:30
commitay
44937fcf95 components_order_cop: add post_install 2018-04-27 10:26:58 +10:00
ilovezfs
ae6ae30857
Merge pull request #4110 from commitay/desc_cop
formula_desc_cop desclength: make non-strict
2018-04-25 06:01:42 -07:00
Mike McQuaid
9089ea4df3
Merge pull request #4109 from commitay/components_redundancy_cop
components_redundancy_cop: make non-strict
2018-04-25 08:32:35 +01:00
Mike McQuaid
56124f2918
Merge pull request #4108 from commitay/urls_cop_pypi
urls_cop pypiurls: make non-strict
2018-04-25 08:32:30 +01:00
commitay
156451bd4b formula_desc_cop desclength: make non-strict 2018-04-25 16:38:40 +10:00
commitay
1b7e6f7eb2 urls_cop pypiurls: make non-strict 2018-04-25 12:18:22 +10:00
commitay
9e24cb9c62 components_redundancy_cop: make non-strict 2018-04-25 07:58:01 +10:00
commitay
1d3ed256a0 components_order_cop: make non-strict 2018-04-24 19:32:53 +10:00
Gautham Goli
a8294a81c0 urls_cop: Search for func calls to match url and mirror calls 2018-04-10 03:22:32 +05:30
Kevin Abel
1b22e16a08
rubocop: Fix audit for dependency order with multiple tags
Dependencies that have multiple tags (`[:build, :test]`) get sorted into
multiple locations resulting in the cop always reporting an offense
regardless of order.
2018-03-28 20:54:39 -05:00
Mike McQuaid
d2c23bde6d Audit use of :run dependencies.
These are a no-op so let's remove them.
2018-03-19 10:11:08 +00:00
Mike McQuaid
83cca40fc9 RuboCop 0.53.0 manual fixes. 2018-03-08 14:10:02 +00:00
Gautham Goli
09f343d496 rubocop: Add cop to check depends_on order and tests 2018-03-01 12:32:25 +05:30
Mike McQuaid
8cd0d85afb rubocop 0.52.1 2018-01-15 16:17:32 +00:00
Mike McQuaid
7f2fda104a formula_cop: match any values in hash match.
e.g. match an array or symbol or string.
2018-01-09 20:08:22 +00:00
Mike McQuaid
4e29152603 formula_cop: use undeprecated add_offense form. 2018-01-07 14:25:07 +00:00
Mike McQuaid
c8b859faad lines_cop: flag depends_on :perl => "1.0".
This requires ignoring the version argument with a new `:any` mode
for this check.
2018-01-07 14:08:58 +00:00
Mike McQuaid
f9b6407110 lines_cop: deprecate 'needs :openmp'. 2017-12-30 20:56:55 +00:00
Mike McQuaid
4fff56ca4f lines_cop: check for more deprecated requirements. 2017-12-30 20:56:55 +00:00
Mike McQuaid
08a452fead lines_cop: check for more deprecated requirements. 2017-12-23 16:53:25 +00:00
Mike McQuaid
b4d43e950f
Merge pull request #3401 from DomT4/vendor_or_na
go: various tweaks to recommendations
2017-12-16 13:34:22 +00:00
Gautham Goli
fb85ed01bc lines_cop: Convert ARGV audit to negative look ahead 2017-12-02 17:03:11 +05:30
Mike McQuaid
6c23892d41
Merge pull request #3478 from GauthamGoli/dir_audit_bug_fix
lines_cop: Add condition to prevent false positives
2017-11-24 21:07:07 +00:00
Gautham Goli
9be85385b3 lines_cop: Add condition to prevent false positives 2017-11-24 23:45:01 +05:30
Mike McQuaid
c6a5bbac7d
Merge pull request #3411 from issyl0/whitelist_etc_and_fix_autocorrect
formula_desc_cop: Whitelist "etc." and fix the full stop autocorrect
2017-11-19 14:39:09 +00:00
Mike McQuaid
872bd4f703
Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix
lines_cop: Update regex patterns to prevent false positives
2017-11-03 17:48:09 +00:00
Isabell Long
5cbb414797 formula_desc_cop: Fix the 'full stop at end of description' autocorrect
- It wasn't working because desc strings end in quotes, not just full
  stops.
2017-11-01 19:50:56 +00:00
Isabell Long
0786d41693 formula_desc_cop: If desc ends with 'etc.', it's not a violation 2017-11-01 19:50:56 +00:00
Dominyk Tiller
883fee78ad
text_cop: warn against go_resource usage for strict audit 2017-10-31 00:55:00 +00:00
Dominyk Tiller
8fd18eab21
text_cop: drop go_resource recommendation 2017-10-31 00:47:57 +00:00
Gautham Goli
f648dd03ff lines_cop: Update regex patterns to prevent false positives 2017-10-29 23:40:04 +05:30
Isabell Long
640b1e9dcb formula_desc_cop: ensure no full stops at the end of desc
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
  description PR. Based on ilovezfs's incantation `grep -r -E 'desc
  ".*\."' *.rb`, some formulae descriptions do end in full stops. (My
  initial assessment of this failed to account for the fact that
  descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
2017-10-29 15:19:31 +00:00
Mike McQuaid
d985838428 lines_cop: add missing e.g. clang++ regex SOL.
You need a start of line check in this regex (like was added in the
others) to allow things like `#{bin}/clang++`.
2017-10-27 14:58:07 +01:00
Gautham Goli
09326909af lines_cop: Fix detection of negated expression 2017-10-26 15:35:14 +05:30
Mike McQuaid
0cec599b28 Merge pull request #3361 from MikeMcQuaid/lines_cop_clang
lines_cop: fix clang detection.
2017-10-25 08:02:33 +01:00
Markus Reiter
7e970216a3 Refactor and fix RuboCop specs. 2017-10-24 19:39:40 +02:00
Mike McQuaid
d067b5f434 lines_cop: fix clang detection.
We only care about e.g. `gcc`/`llvm-gcc`/`clang` being at the beginning
of a `system` call and not anywhere within the string.
2017-10-24 16:03:13 +01:00
Gautham Goli
7b2fab8ec5 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 13:53:44 +05:30
Gautham Goli
ee35d65867 lines_cop: Refactor to multiple cops and fix style violations 2017-10-21 12:50:49 +05:30
Gautham Goli
bdc7eba4b3 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 01:48:00 +05:30