52 Commits

Author SHA1 Message Date
Markus Reiter
44f56a0773 Refactor join("") to join. 2018-06-15 13:56:08 +02:00
Markus Reiter
a0ca601a1a Silence Parser compatibility warning. 2018-05-26 16:24:48 +02:00
Gautham Goli
efec2fa0c5 lines_cop: Add deprected options audit for depends_on 2018-05-06 15:42:51 +05:30
Gautham Goli
a8294a81c0 urls_cop: Search for func calls to match url and mirror calls 2018-04-10 03:22:32 +05:30
Mike McQuaid
d2c23bde6d Audit use of :run dependencies.
These are a no-op so let's remove them.
2018-03-19 10:11:08 +00:00
Mike McQuaid
83cca40fc9 RuboCop 0.53.0 manual fixes. 2018-03-08 14:10:02 +00:00
Mike McQuaid
8cd0d85afb rubocop 0.52.1 2018-01-15 16:17:32 +00:00
Mike McQuaid
7f2fda104a formula_cop: match any values in hash match.
e.g. match an array or symbol or string.
2018-01-09 20:08:22 +00:00
Mike McQuaid
4e29152603 formula_cop: use undeprecated add_offense form. 2018-01-07 14:25:07 +00:00
Mike McQuaid
c8b859faad lines_cop: flag depends_on :perl => "1.0".
This requires ignoring the version argument with a new `:any` mode
for this check.
2018-01-07 14:08:58 +00:00
Gautham Goli
fb85ed01bc lines_cop: Convert ARGV audit to negative look ahead 2017-12-02 17:03:11 +05:30
Gautham Goli
09326909af lines_cop: Fix detection of negated expression 2017-10-26 15:35:14 +05:30
Markus Reiter
7e970216a3 Refactor and fix RuboCop specs. 2017-10-24 19:39:40 +02:00
Gautham Goli
7b2fab8ec5 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 13:53:44 +05:30
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Gautham Goli
7fa51f71f1 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-13 19:50:46 +05:30
Markus Reiter
9795195726 Fix RuboCop tests. 2017-10-07 23:30:47 +02:00
Mike McQuaid
bf0ab938e7 Merge pull request #3091 from GauthamGoli/audit_line_rubocop_part_3
audit: Port line_problems to rubocop and add tests part 3
2017-09-05 18:10:02 +01:00
Gautham Goli
4ec26aea40 audit: Port audit_class to rubocop, add tests and autocorrect 2017-09-04 23:43:42 +05:30
Gautham Goli
337d5c6470 audit: Fetch formula name from file path rather than class name in cops 2017-09-04 15:05:43 +05:30
Gautham Goli
b582ed513b audit: Add tests for rubocop methods in line_cop.rb 2017-09-04 15:05:43 +05:30
Gautham Goli
267def28fa audit: Port rules from line_problems to rubocop part 3 2017-09-04 15:05:43 +05:30
JCount
6023e408da Merge pull request #2995 from GauthamGoli/audit_line_rubocop_part_2
audit: Port line_problems to rubocop and add tests part 2
2017-08-23 16:16:07 -04:00
Gautham Goli
efabd4b5c2 Add tests for MACOS version consts usage 2017-08-15 00:42:56 +05:30
Gautham Goli
3efba57cd9 Add negated? method to formula cop and add tests for negated build.without? 2017-08-14 02:18:46 +05:30
Gautham Goli
e14fedd1b3 Add test for negated build.with? 2017-08-14 02:14:20 +05:30
Gautham Goli
6dad9d8b44 Add test for top level method def 2017-08-14 01:25:44 +05:30
Gautham Goli
4295a4ca78 audit: Port rules from line_problems to rubocop part 4(WIP-2) 2017-08-10 19:57:53 +05:30
Gautham Goli
a3219ca09c Add node pattern methods to handle dependency audits in a better way 2017-08-07 16:02:50 +05:30
Gautham Goli
b8f811cca6 audit: Port rules from line_problems to rubocop part 3 2017-08-06 18:36:09 +05:30
Gautham Goli
b5da76e28d audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop 2017-08-06 18:36:09 +05:30
Gautham Goli
bc2bcef1ba audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 18:36:09 +05:30
Gautham Goli
7614d2cc8b audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop 2017-08-06 02:28:58 +05:30
Gautham Goli
affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Mike McQuaid
f4983ab16b Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Gautham Goli
c575f34d5f audit: Port audit_urls strict rules to rubocop, add tests and autocorrect 2017-07-30 12:59:37 +05:30
Gautham Goli
e1cb0b43d7 audit: Port dependency rules from line_problems to rubocop and add tests 2017-07-29 16:36:32 +05:30
Gautham Goli
b8adc1a8aa audit: Port audit_options non-strict rules to rubocop and add tests 2017-07-13 12:41:43 +05:30
Gautham Goli
4ed34f91c2 audit: Port audit_conflicts method to rubocop and add tests 2017-07-07 20:46:57 +05:30
Gautham Goli
0e1c88e7ae Refactor Checksum cop to add autocorrect method 2017-06-16 19:45:16 +05:30
Gautham Goli
4d7a983415 audit: Port audit_checksum method to rubocop and add tests 2017-06-16 19:45:16 +05:30
Mike McQuaid
113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Gautham Goli
d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Gautham Goli
134da5b8c2 Add methods in FormulaCop to find block nodes 2017-06-08 19:50:04 +05:30
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Gautham Goli
88f21b84f4 Refactor and add more methods in formula_cop.rb 2017-05-30 15:28:05 +05:30
Gautham Goli
5b97a8f2e1 Add methods in FormulaCop to find method nodes, dependency nodes 2017-05-30 15:28:05 +05:30
Gautham Goli
80572939b4 Update string_content method to support multiline strings, add test for same 2017-05-13 18:48:40 +05:30
Gautham Goli
c3330c289d Add --only-cops,--except-cops options for brew audit
Also refactor audit cops into two "departments"
 - FormulaAudit
 - FormulaAuditStrict
2017-05-02 23:26:12 +05:30
Gautham Goli
413a7e5dae Port audit_components method to rubocops and add corresponding tests 2017-04-22 21:53:16 +05:30