58 Commits

Author SHA1 Message Date
Mike McQuaid
5e6c40e28f Make versioned formulae regex more consistent.
Share the regex where possible and otherwise ensure they are identical.
2018-06-18 14:36:51 +01:00
Gautham Goli
efec2fa0c5 lines_cop: Add deprected options audit for depends_on 2018-05-06 15:42:51 +05:30
Mike McQuaid
f9b6407110 lines_cop: deprecate 'needs :openmp'. 2017-12-30 20:56:55 +00:00
Mike McQuaid
4fff56ca4f lines_cop: check for more deprecated requirements. 2017-12-30 20:56:55 +00:00
Mike McQuaid
08a452fead lines_cop: check for more deprecated requirements. 2017-12-23 16:53:25 +00:00
Gautham Goli
fb85ed01bc lines_cop: Convert ARGV audit to negative look ahead 2017-12-02 17:03:11 +05:30
Gautham Goli
9be85385b3 lines_cop: Add condition to prevent false positives 2017-11-24 23:45:01 +05:30
Gautham Goli
f648dd03ff lines_cop: Update regex patterns to prevent false positives 2017-10-29 23:40:04 +05:30
Mike McQuaid
d985838428 lines_cop: add missing e.g. clang++ regex SOL.
You need a start of line check in this regex (like was added in the
others) to allow things like `#{bin}/clang++`.
2017-10-27 14:58:07 +01:00
Gautham Goli
09326909af lines_cop: Fix detection of negated expression 2017-10-26 15:35:14 +05:30
Mike McQuaid
0cec599b28 Merge pull request #3361 from MikeMcQuaid/lines_cop_clang
lines_cop: fix clang detection.
2017-10-25 08:02:33 +01:00
Markus Reiter
7e970216a3 Refactor and fix RuboCop specs. 2017-10-24 19:39:40 +02:00
Mike McQuaid
d067b5f434 lines_cop: fix clang detection.
We only care about e.g. `gcc`/`llvm-gcc`/`clang` being at the beginning
of a `system` call and not anywhere within the string.
2017-10-24 16:03:13 +01:00
Gautham Goli
7b2fab8ec5 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 13:53:44 +05:30
Gautham Goli
ee35d65867 lines_cop: Refactor to multiple cops and fix style violations 2017-10-21 12:50:49 +05:30
Gautham Goli
bdc7eba4b3 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 01:48:00 +05:30
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
JCount
e882ce1919 lines_cop: add ENV.universal_binary audit exemption for wine 2017-10-15 10:25:35 -04:00
Gautham Goli
7fa51f71f1 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-13 19:50:46 +05:30
Gautham Goli
337d5c6470 audit: Fetch formula name from file path rather than class name in cops 2017-09-04 15:05:43 +05:30
Gautham Goli
b582ed513b audit: Add tests for rubocop methods in line_cop.rb 2017-09-04 15:05:43 +05:30
Gautham Goli
267def28fa audit: Port rules from line_problems to rubocop part 3 2017-09-04 15:05:43 +05:30
Gautham Goli
afdd0e2437 add tests for condition dependencies 2017-08-15 16:09:32 +05:30
Gautham Goli
efabd4b5c2 Add tests for MACOS version consts usage 2017-08-15 00:42:56 +05:30
Gautham Goli
2f94d5f499 add test for ARGV.include? 2017-08-15 00:36:37 +05:30
Gautham Goli
3fc6cc1a3a add test for ENV.fortran 2017-08-15 00:32:34 +05:30
Gautham Goli
5744cd9066 add test for inspecting version 2017-08-15 00:29:58 +05:30
Gautham Goli
cfc423e183 add tests for dependencies 2017-08-15 00:27:09 +05:30
Gautham Goli
d2a7314f53 add test for env mod through system call 2017-08-14 23:32:06 +05:30
Gautham Goli
64a929184a add tests for vendored deps 2017-08-14 23:05:00 +05:30
Gautham Goli
063cbe7acd add tests for formula path shortucut 3 2017-08-14 22:44:28 +05:30
Gautham Goli
9c9c280c8a add tests for formula path string 1 2017-08-14 21:45:01 +05:30
Gautham Goli
65ae6bacd8 add tests for hardcoded compilers in ENV 2017-08-14 20:10:45 +05:30
Gautham Goli
77468fdae3 add tests for hard coded compilers in system calls 2017-08-14 19:58:39 +05:30
Gautham Goli
af5cd1a1da add tests for man+'man[1-8]' 2017-08-14 15:41:03 +05:30
Gautham Goli
76f4eccdce add test for using ARGV to check options 2017-08-14 15:22:44 +05:30
Gautham Goli
dc4d10ff6a add test for build.include? having dashed args 2017-08-14 02:49:52 +05:30
Gautham Goli
3ff8be1216 add test for build.include? 2017-08-14 02:47:29 +05:30
Gautham Goli
5a7cbb762f add test for build.with? "--with-foo" 2017-08-14 02:43:54 +05:30
Gautham Goli
02a1406a2e add test for build.without --without-foo 2017-08-14 02:32:29 +05:30
Gautham Goli
3efba57cd9 Add negated? method to formula cop and add tests for negated build.without? 2017-08-14 02:18:46 +05:30
Gautham Goli
e14fedd1b3 Add test for negated build.with? 2017-08-14 02:14:20 +05:30
Gautham Goli
ec2b0df10e Add tests for unless build.with? 2017-08-14 01:55:47 +05:30
Gautham Goli
f968776e84 Add tests for unless build.without? 2017-08-14 01:52:48 +05:30
Gautham Goli
6dad9d8b44 Add test for top level method def 2017-08-14 01:25:44 +05:30
Gautham Goli
7dfe09ccae Add tests for fileUtils call in system 2017-08-14 01:09:06 +05:30
Gautham Goli
a73c29fef2 add tests for non glob dirs audit 2017-08-14 00:02:44 +05:30
Gautham Goli
77105b809a Add tests for macOS check 2017-08-13 14:50:29 +05:30
Gautham Goli
686fc514cf Add tests for assert match and depends_on instance audit rules 2017-08-12 23:28:08 +05:30
Gautham Goli
087c1ca8d6 audit: Port rules from line_problems to rubocop part 4(WIP-3) 2017-08-12 20:50:43 +05:30