26 Commits

Author SHA1 Message Date
Markus Reiter
d98c45b2d3 Fix code style in audit spec. 2018-06-02 03:46:55 +02:00
Gautham Goli
26e77dd75c new-formula: Don't fail CI instead comment on PR about audit violations 2018-04-30 10:59:20 +05:30
Markus Reiter
33a9521576 Fix MissingFormula namespacing. 2018-04-22 17:27:44 +02:00
Mike McQuaid
5e1806e796 test: rubocop-rspec style auto-corrects.
There’s too many warnings to start enabling `rubocop-rspec` by default
but let’s at least apply the cleanups it does automatically.
2018-03-25 13:30:37 +01:00
William Woodruff
3f43f60a2a
audit: Warn on new formulae containing binary URLs 2018-02-06 08:44:56 -05:00
Mike McQuaid
4d4722c97c Remove more uses of EOS.undent. 2017-11-10 14:22:39 +00:00
Mike McQuaid
219f9691ef
Merge pull request #3292 from claui/add-audit-test-cases
Add tests for `FormulaAuditor#audit_deps`
2017-11-10 13:34:56 +00:00
Claudia
e0bb978cc9 Add tests for FormulaAuditor#audit_deps
These tests cover a few aspects of the `FormulaAuditor#audit_deps`
method. The main focus is the part where FormulaAuditor checks for
dependencies on formulas which are tagged `keg_only` with the
`:provided_by_macos` reason.

For this particular kind of `keg_only` formulas, we expect
`brew audit --new-formula` to fail with a problem message like:

> Dependency 'bc' may be unnecessary as it is provided by
> macOS; try to build this formula without it.

For more details, see the relevant discussion:

[1] https://github.com/Homebrew/homebrew-core/pull/14067#issuecomment-335046151

[2] https://github.com/Homebrew/brew/pull/3290#issuecomment-335052140
2017-10-20 14:08:22 +02:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Gautham Goli
4ec26aea40 audit: Port audit_class to rubocop, add tests and autocorrect 2017-09-04 23:43:42 +05:30
Gautham Goli
affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Markus Reiter
2ad3a87045 Silence all specs by default. 2017-07-29 20:25:37 +02:00
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Gautham Goli
51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Markus Reiter
3cdf8f938a Use scoped RSpec matchers. 2017-05-15 17:23:40 +02:00
Gautham Goli
91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Dominyk Tiller
bf491e5102
audit_spec: add keg_only_style tests 2017-05-02 20:08:30 +01:00
Dominyk Tiller
ed1ae19aee
audit_spec: test go get ban 2017-04-28 18:13:38 +01:00
Mike McQuaid
ceb1629ad7 Merge pull request #2465 from GauthamGoli/audit_components_port_rubocop
audit: audit_components method to rubocops and tests
2017-04-24 10:06:41 +01:00
Mike McQuaid
d5155256ce Fix audit version_scheme and revision checks.
Another attempt at fixing `brew audit` issues around detecting
`revision` and `version_scheme` changes correctly. First done in #1754
and #2086 (reverted in #2099 and #2100).

To ease future debugging a `ph` helper has been added to print a hash
and a series of RSpec tests to verify that the `revision`,
`version_scheme` and `version` formula version audits behave as
expected.

Fixes #1731.
2017-04-23 18:56:22 +01:00
Gautham Goli
413a7e5dae Port audit_components method to rubocops and add corresponding tests 2017-04-22 21:53:16 +05:30
Mike McQuaid
3f8722c971 audit: allow skipping audit methods.
Add `--only` and `--except` methods which can be used to selectively
enable or disable audit groups.
2017-04-18 08:17:26 +01:00
Gautham Goli
19f693d25b Port audit_desc rules to cop 2017-03-02 12:50:05 +05:30
Markus Reiter
a554902380 Add mktmpdir helper method. 2017-02-28 15:06:32 +01:00
Markus Reiter
ebe4042b2f Convert FormulaAuditor test to spec. 2017-02-28 13:46:13 +01:00
Markus Reiter
8676960d09 Convert FormulaText test to spec. 2017-02-27 23:52:20 +01:00