107 Commits

Author SHA1 Message Date
Markus Reiter
fdb2406b20 Add failing spec for DependencyOrder cop. 2018-06-11 04:21:06 +02:00
commitay
3329a9f6d8 text_cop: require cargo to use install instead of build 2018-06-10 16:42:19 +10:00
commitay
490dc9118e text_cop: require dep ensure to use -vendor-only 2018-06-08 00:42:57 +10:00
commitay
1a4340161c options_cop: formula -> formulae 2018-06-02 16:56:55 +10:00
commitay
9d55fed15f audit: new formulae should not have options 2018-05-22 19:39:14 +10:00
Gautham Goli
efec2fa0c5 lines_cop: Add deprected options audit for depends_on 2018-05-06 15:42:51 +05:30
ilovezfs
ae6ae30857
Merge pull request #4110 from commitay/desc_cop
formula_desc_cop desclength: make non-strict
2018-04-25 06:01:42 -07:00
Mike McQuaid
9089ea4df3
Merge pull request #4109 from commitay/components_redundancy_cop
components_redundancy_cop: make non-strict
2018-04-25 08:32:35 +01:00
Mike McQuaid
56124f2918
Merge pull request #4108 from commitay/urls_cop_pypi
urls_cop pypiurls: make non-strict
2018-04-25 08:32:30 +01:00
commitay
156451bd4b formula_desc_cop desclength: make non-strict 2018-04-25 16:38:40 +10:00
commitay
1b7e6f7eb2 urls_cop pypiurls: make non-strict 2018-04-25 12:18:22 +10:00
commitay
9e24cb9c62 components_redundancy_cop: make non-strict 2018-04-25 07:58:01 +10:00
commitay
1d3ed256a0 components_order_cop: make non-strict 2018-04-24 19:32:53 +10:00
Kevin Abel
1b22e16a08
rubocop: Fix audit for dependency order with multiple tags
Dependencies that have multiple tags (`[:build, :test]`) get sorted into
multiple locations resulting in the cop always reporting an offense
regardless of order.
2018-03-28 20:54:39 -05:00
Gautham Goli
09f343d496 rubocop: Add cop to check depends_on order and tests 2018-03-01 12:32:25 +05:30
Mike McQuaid
f9b6407110 lines_cop: deprecate 'needs :openmp'. 2017-12-30 20:56:55 +00:00
Mike McQuaid
d54e670a64 requirements: move more to compat. 2017-12-30 20:56:55 +00:00
Mike McQuaid
b4d43e950f
Merge pull request #3401 from DomT4/vendor_or_na
go: various tweaks to recommendations
2017-12-16 13:34:22 +00:00
Gautham Goli
fb85ed01bc lines_cop: Convert ARGV audit to negative look ahead 2017-12-02 17:03:11 +05:30
Mike McQuaid
872bd4f703
Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix
lines_cop: Update regex patterns to prevent false positives
2017-11-03 17:48:09 +00:00
Dominyk Tiller
bff4762d36
text_cop_spec: update go get tests 2017-10-31 01:01:42 +00:00
Gautham Goli
f648dd03ff lines_cop: Update regex patterns to prevent false positives 2017-10-29 23:40:04 +05:30
Isabell Long
640b1e9dcb formula_desc_cop: ensure no full stops at the end of desc
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
  description PR. Based on ilovezfs's incantation `grep -r -E 'desc
  ".*\."' *.rb`, some formulae descriptions do end in full stops. (My
  initial assessment of this failed to account for the fact that
  descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
2017-10-29 15:19:31 +00:00
Markus Reiter
7e970216a3 Refactor and fix RuboCop specs. 2017-10-24 19:39:40 +02:00
Gautham Goli
7b2fab8ec5 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 13:53:44 +05:30
Gautham Goli
ee35d65867 lines_cop: Refactor to multiple cops and fix style violations 2017-10-21 12:50:49 +05:30
Gautham Goli
bdc7eba4b3 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 01:48:00 +05:30
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Mike McQuaid
1d40061c69 Merge pull request #3291 from JCount/lines-cop-fix-wine-universal-binary
lines_cop: add ENV.universal_binary audit exemption for wine
2017-10-18 10:32:34 +01:00
JCount
85fa79b5cf lines_cop_spec: improve language in universal_binary and build tests 2017-10-15 10:36:51 -04:00
JCount
ca52eee2ad lines_cop_spec: add test for ENV.universal_binary audit exemption for wine 2017-10-15 10:26:03 -04:00
Dominyk Tiller
29070e5cbe
formula_desc_cop_spec: add empty string test 2017-10-14 02:50:08 +01:00
Gautham Goli
7fa51f71f1 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-13 19:50:46 +05:30
Markus Reiter
9795195726 Fix RuboCop tests. 2017-10-07 23:30:47 +02:00
Gautham Goli
626cb6ca91 audit: Add more tests for FormulaAudit/Miscellaneous cop 2017-09-18 18:03:54 +05:30
Mike McQuaid
bf0ab938e7 Merge pull request #3091 from GauthamGoli/audit_line_rubocop_part_3
audit: Port line_problems to rubocop and add tests part 3
2017-09-05 18:10:02 +01:00
Gautham Goli
4ec26aea40 audit: Port audit_class to rubocop, add tests and autocorrect 2017-09-04 23:43:42 +05:30
Gautham Goli
337d5c6470 audit: Fetch formula name from file path rather than class name in cops 2017-09-04 15:05:43 +05:30
Gautham Goli
b582ed513b audit: Add tests for rubocop methods in line_cop.rb 2017-09-04 15:05:43 +05:30
Gautham Goli
d00c515dd8 audit: Add previously unported GH patch audit rule in Patches cop 2017-08-26 18:06:00 +05:30
JCount
6023e408da Merge pull request #2995 from GauthamGoli/audit_line_rubocop_part_2
audit: Port line_problems to rubocop and add tests part 2
2017-08-23 16:16:07 -04:00
Gautham Goli
db20b0c281 audit: In Cops and their tests convert all multiline strings to heredocs 2017-08-17 11:41:58 +05:30
Gautham Goli
afdd0e2437 add tests for condition dependencies 2017-08-15 16:09:32 +05:30
Gautham Goli
efabd4b5c2 Add tests for MACOS version consts usage 2017-08-15 00:42:56 +05:30
Gautham Goli
2f94d5f499 add test for ARGV.include? 2017-08-15 00:36:37 +05:30
Gautham Goli
3fc6cc1a3a add test for ENV.fortran 2017-08-15 00:32:34 +05:30
Gautham Goli
5744cd9066 add test for inspecting version 2017-08-15 00:29:58 +05:30
Gautham Goli
cfc423e183 add tests for dependencies 2017-08-15 00:27:09 +05:30
Gautham Goli
d2a7314f53 add test for env mod through system call 2017-08-14 23:32:06 +05:30
Gautham Goli
64a929184a add tests for vendored deps 2017-08-14 23:05:00 +05:30