11 Commits

Author SHA1 Message Date
Shaun Jackman
7adee6d62f Utils.popen_read: Nonexistent program should fail
Ensure that $CHILD_STATUS.success? is false when the command does not exist.
2017-12-02 15:52:01 -08:00
Shaun Jackman
58a1bd6dbf popen: Do not suppress stderr when HOMEBREW_STDERR 2017-09-20 13:25:36 -07:00
Shaun Jackman
8bf28477a3 popen: Add an options argument
Useful for selectively enabling or silencing stderr, for example.
popen_read("foo", err: :err)
2017-09-20 13:25:29 -07:00
ilovezfs
6fb9fed693 Revert "popen: Do not suppress stderr" 2017-09-19 07:40:29 -07:00
Shaun Jackman
78d3112df2 popen: Do not suppress stderr unless -d or -v 2017-09-08 09:39:33 -07:00
Markus Reiter
dc4f303937 Remove unused popen_read_text method. 2017-05-29 01:45:05 +02:00
Markus Reiter
58e36c7319 Fix Style/GuardClause. 2016-09-24 12:24:35 +02:00
Martin Afanasjew
8486f6e04d Prefer $stderr over STDERR for consistency (#304)
Prior to this change there were only 3 instances of `STD(IN|OUT|ERR)`
versus 74 instances of `$std(in|out|err)` in the Homebrew code base. The
latter variant is also strongly suggested by bbatsov's Ruby Style Guide.
2016-06-01 09:45:49 +02:00
Andrew Janke
a3b70d38a7 brew-audit: pull style checks in to main audit output
This collects all violations for each formula in a single place, instead
of doing `brew style` outputs for all formulae first, and then the other
audit checks.

Closes #112.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-04-21 14:45:33 -04:00
Jack Nagel
5c24b7330b Read if no block is passed to Utils.popen_read 2014-07-11 15:52:39 -05:00
Jack Nagel
ad27b21cd1 Add popen wrapper that does not invoke the shell 2014-07-05 13:50:54 -05:00