97 Commits

Author SHA1 Message Date
Jack Nagel
8b51cf019d Move exception text into exception object 2014-12-29 22:57:45 -05:00
Jack Nagel
912a586d15 Preserve backtrace for download errors 2014-12-29 22:51:55 -05:00
Jack Nagel
1b1a73bddb Always show attribute value in validation error message 2014-12-23 15:37:24 -05:00
Jack Nagel
9a356fc609 Remove FormulaAlreadyInstalledError
install is the only command that can trigger this warning, so it should
be handled before instantiating the installer.
2014-10-31 18:33:39 -05:00
Jack Nagel
56dd575f96 Pass command and arg list into ErrorDuringExecution constructor 2014-09-18 20:32:50 -05:00
Jack Nagel
f3b7c3236b Consistently call name on formula instead of relying on to_s 2014-09-14 11:19:30 -05:00
Jack Nagel
081036c81c Remove InstallationError superclass
None of these subclasses share any behavior other than what is inherited
from RuntimeError, so we can just get rid of the superclass.
2014-09-14 01:10:20 -05:00
Jack Nagel
2332e6525d Remove unused attribute from BuildError 2014-09-13 19:49:27 -05:00
Jack Nagel
a607c71123 Pass the ENV hash into the BuildError constructor 2014-09-13 19:47:30 -05:00
Jack Nagel
20516ee39b Use the superclass properly 2014-09-12 21:31:48 -05:00
Jack Nagel
1f3bbe64e0 Make parameter names match superclass parameter names 2014-09-12 21:31:48 -05:00
Jack Nagel
c85c165fe9 Remove default argument from Homebrew::InstallationError
This class is never instantiated directly, and all subclasses
initializers have different signatures and do not rely on this.
2014-09-12 21:26:24 -05:00
Jack Nagel
1ace6f147d Make exception subclasses use their superclass properly 2014-09-12 21:24:56 -05:00
Jack Nagel
31dc3d1f42 Inline variable 2014-08-25 20:43:11 -05:00
Jack Nagel
262a503b6f Decouple IncompatibleCxxStdlibs from its superclass
This exception is never used outside of the CxxStdlib class, so we don't
need the Homebrew::InstallationError superclass.
2014-08-22 22:37:35 -05:00
Shaun Jackman
1fb1677532 Linuxbrew: Move ISSUES_URL to os from global
Closes Homebrew/linuxbrew#103

Closes Homebrew/homebrew#30830.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-12 15:39:59 -05:00
Matt Hauck
19847285f2 exceptions: fix typo
Closes Homebrew/homebrew#30821.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-07-11 15:08:18 -07:00
Jack Nagel
dae83fc895 Drop pointless string split 2014-07-06 13:52:44 -05:00
Jack Nagel
375c073cec Remove unused attribute 2014-05-28 19:02:30 -05:00
Jack Nagel
9821316ec1 Remove unused method and associated test fixtures 2014-05-28 18:48:38 -05:00
Mike McQuaid
54fc1946f9 exceptions: fix tap issue URL.
Closes Homebrew/homebrew#29043.
2014-05-08 11:43:11 +01:00
Adam Vandenberg
d4b0599a86 --config -> config 2014-04-30 19:09:29 -07:00
Mike McQuaid
165fdf4617 Use gcc instead of apple-gcc42 when needed. 2014-04-23 08:15:30 +01:00
Adam Vandenberg
b24ef38bc1 show formula version in failed build output 2014-04-06 12:00:34 -07:00
Jack Nagel
cfee535786 Remove now unnecessary realpath calls 2014-04-06 00:31:07 -05:00
Jack Nagel
309171e4f4 Automatically reinstall up-to-date dependencies that are missing options
Closes Homebrew/homebrew#21223.
2014-04-05 10:48:54 -05:00
Misty De Meo
ab4f9e57ae Don't check issues on Ruby 1.8.6
The system certs are too old to be able to read from Github, so
don't try to use the Github API on 1.8.6 either.
2014-03-17 11:52:11 -07:00
Jack Nagel
3872f78d66 Add custom exception for untapped formulae 2014-02-28 15:58:20 -06:00
Jack Nagel
793d6de6c3 Pass expansion-time build options to install_dependency 2014-02-27 14:22:43 -06:00
Jack Nagel
9b8cff1484 Tweak DownloadError message to include wrapped exception 2014-02-18 15:08:03 -05:00
Drew Rodman
d63ef14794 Add DownloadError to catch a broader range of resource download errors.
Adding a broader exception class allows for errors raised in Resource.fetch
to be caught in upgrade and prevent the process from being killed when
a download fails. This should resolve issue 18364.

Fixes Homebrew/homebrew#18364.
Closes Homebrew/homebrew#26618.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-02-18 15:08:03 -05:00
Jack Nagel
ca0eff67fa Inline static exception text to remove a rescue 2014-02-18 13:27:35 -05:00
Jack Nagel
0b0d171566 Don't let issue search kill install process 2014-02-08 16:04:53 -05:00
Misty De Meo
d885d98164 C++ stdlibs: issue warning, don't fail the build 2014-02-02 11:04:30 -08:00
Mike McQuaid
a65f649cf5 utils: improve issue searching.
* issues_matching now returns an array
* prints issues titles and URLs
* find_pull_requests shows closed PRs if no matching PRs are open

Closes Homebrew/homebrew#26032.
2014-01-20 17:58:50 -08:00
Mike McQuaid
5413ebca53 exceptions: remove unused AlreadyTappedError. 2014-01-03 21:57:07 +00:00
Mike McQuaid
d7c13f84b6 Update string references to mxcl/homebrew. 2013-12-14 18:18:35 +00:00
Jack Nagel
65a00e213b Make CompilerSelectionError an InstallationError
Fixes Homebrew/homebrew#19962.
2013-12-03 22:16:37 -06:00
Mike McQuaid
6af4ab44c6 exceptions: improve tap error message.
Point users to the tap's issue tracker URL.
2013-11-11 18:09:02 +00:00
Mike McQuaid
37e2005e79 Use HOMEBREW_LOGS more consistently. 2013-10-31 17:02:20 -07:00
Mike McQuaid
55947f84a5 exceptions: direct to correct tap on failure.
Closes Homebrew/homebrew#23757.
2013-10-30 11:20:20 -07:00
Stefan
0a1df377fb fix build log output
Closes Homebrew/homebrew#23669.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-10-27 09:48:15 -07:00
Mike McQuaid
98b28f5ac3 Different regex for user/tap/formula and user/tap.
Closes Homebrew/homebrew#23430.
2013-10-22 11:58:40 +01:00
Mike McQuaid
1cb7eca3a5 tap: use dedicated exception for already tapped. 2013-10-21 20:16:41 +01:00
Mike McQuaid
077f09e4ea global: unify tap regex.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-10-21 18:53:24 +01:00
Misty De Meo
29d204c697 Adjust CompilerSelectionError message 2013-09-27 20:33:15 -07:00
Adam Vandenberg
d4cf3ef212 Implement Resources
Closes Homebrew/homebrew#20212.
2013-09-11 22:05:26 -07:00
Misty De Meo
7c3d6ea81c Check dependencies for a compatible C++ stdlib
There are now a few possible C++ standard libraries a given build could
be using, with subtle incompatibilities and possibility of breakage
when mixed. This makes sure that the dependency chain was compiled in
a compatible manner.

Fortunately all of the Apple compilers use the same libstdc++, and we
don't yet support building with libc++, so this will primarily only
nag users trying to use GNU gcc who already have software installed
with Apple compilers.

Future TODOs:

* Add general support for building with libc++ (compatibility checking
  already handled here)
* Possibly track formulae which actually build C++ bindings, so that
  users aren't bothered by spurious nagging re: interpreted languages,
  pure-C software, etc.
2013-09-01 13:19:13 -07:00
Adam Vandenberg
bb142f4e3b exception style 2013-08-08 11:17:16 -07:00
Adam Vandenberg
1a72c85a05 Use 'path or URL' as tap for non-tap, non-core formulae 2013-06-24 07:33:37 -07:00