93 Commits

Author SHA1 Message Date
Mike McQuaid
ea2892f8ee
brew.rb: handle missing args. 2024-03-07 16:20:20 +00:00
Mike McQuaid
9259c345cc
utils/analytics: general cleanup.
We have plans to add analytics for commands and `brew test-bot`

This requires a certain amount of refactoring which I've done here.

There was also a bunch of legacy `*_influx_?` usage from when we used
both InfluxDB and Google Analytics that made sense to clean up and
excessive indirection.
2024-03-07 15:19:04 +00:00
Bo Anderson
1f483bfe71
utils/analytics: don't fail on invalid version 2023-11-29 15:56:05 +00:00
Mike McQuaid
dda839c27b
analytics: fix @ in formulae names with --github-packages-downloads 2023-07-26 16:46:23 +01:00
Mike McQuaid
16a36a0910
utils/analytics: new InfluxDB token.
This is created with a different user that's more desirable.
2023-07-18 16:22:23 +01:00
Mike McQuaid
77061817f7
Fix (again) InfluxDB analytics messaging
Address https://github.com/Homebrew/brew/pull/15688#issuecomment-1638725595

Fixes https://github.com/Homebrew/brew/issues/15678
2023-07-18 08:03:57 +01:00
Mike McQuaid
c2ce8e7033
utils/analytics: hide InfluxDB message correctly.
Fixes #15678
2023-07-17 19:26:10 +01:00
Bo Anderson
8adac8a53e
Merge pull request #15659 from SMillerDev/fix/analytics/source
analytics: use new AWS based influxdb
2023-07-10 20:19:29 +01:00
Sean Molenaar
fc48930a59
analytics: use new AWS based influxdb 2023-07-10 20:47:19 +02:00
Mike McQuaid
cd313adbe4
cmd/info: add (undocumented) --github-packages-downloads option.
This screen scrapes GitHub Packages download counts from HTML for a
core formula.

It's useful when figuring out the difference between our analytics
numbers (which people can opt-out of) and our bottle downloads (which
people cannot due to the way GitHub Packages works).
2023-06-16 15:39:49 +01:00
Mike McQuaid
75dd070395
Remove Google Analytics
We are now entirely migrated to InfluxDB so can remove all GA code.
2023-06-16 10:33:15 +01:00
Douglas Eichelberger
08af78a2a5 brew style --fix 2023-04-25 09:26:24 -07:00
Douglas Eichelberger
24cf6076e8 brew style --fix 2023-04-24 20:42:39 -07:00
Mike McQuaid
4d8445e29d
analytics: improve InfluxDB cardinality
- roll InfluxDB token (we need to report to a new bucket to fix implicit schema)
- adjust various parameters
- separate default tags and fields
- send more fields and fewer tags (tags should have low cardinality)
- use `--data-binary` to match InfluxDB documentation
- document second precision for greater InfluxDB performance
- pass through tap name, formula/cask name, options separately
- pass `devcmdrun` as a tag
- avoid sending very high-cardinality `OS_VERSION` values
2023-03-20 15:26:47 +00:00
Issy Long
8e13a6e1f4
Merge pull request #14944 from issyl0/more-rubocop-naming-method-parameter-name
rubocop: Further trim `Naming/MethodParameterName` allowlist
2023-03-11 22:59:39 +00:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName allowlist
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Douglas Eichelberger
02fd0422aa Enable typing in a few more files 2023-03-09 13:42:06 -08:00
Mike McQuaid
792ec7fc85
utils/analytics: tweaks constants.
This enables easier usage in `brew formula-analytics`.
2023-02-21 17:07:01 +00:00
Mike McQuaid
57844530a9
analytics: remove UUID.
We don't use this at all with InfluxDB and don't need it any more for GA
so let's just remove it.
2023-02-20 09:05:15 +00:00
Mike McQuaid
ad1213a7da
utils/analytics: make on_request a proper boolean.
Otherwise when it's `false` it's being turned into a `true` value.
2023-02-16 17:51:42 +00:00
Mike McQuaid
a83fef7b41
utils/analytics: cleanup data.
Based on reviewing InfluxDB buckets.
2023-02-16 13:15:04 +00:00
Mike McQuaid
ef8ad10741
utils/analytics: fix BuildError reporting.
Need to ensure we call the correct methods to avoid duplicates.
2023-02-16 12:59:46 +00:00
Mike McQuaid
e42cae19a5
Merge pull request #14647 from MikeMcQuaid/report_influxdb_default
analytics: report to InfluxDB by default.
2023-02-15 19:19:41 +00:00
Mike McQuaid
dfd4cd9b0c
analytics: update token.
We've deleted the old data and added a new bucket with a new token.
2023-02-15 17:32:34 +00:00
Mike McQuaid
769a8c5001
analytics: report to InfluxDB by default.
Now that this is ready: let's roll it out to everyone in 4.0.0.
2023-02-15 17:27:02 +00:00
Mike McQuaid
c5252817c2
analytics: refactor InfluxDB/Google handling. 2023-02-15 16:34:50 +00:00
Sean Molenaar
50e9247da4
fix: add better keys and fuller values to influxDB analytics 2023-02-15 14:12:05 +01:00
Bo Anderson
7ef0c48362
Fix analytics handling when core/cask taps are untapped 2023-02-15 05:31:08 +00:00
Sean Molenaar
61e5e19bdb
analytics: fix spelling
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Eric Knibbe <enk3@outlook.com>
2023-02-06 16:56:25 +01:00
Sean Molenaar
10e3c522f7
analytics: stop sending analytics in tests 2023-02-06 16:28:34 +01:00
Francois-Xavier Coudert
2b07d0d5bb analytics: fix URL typo 2023-01-26 21:24:50 +01:00
Sean Molenaar
59ebdab2b7
analytics: switch to InfluxDB for logging 2023-01-19 18:15:27 +01:00
Mike McQuaid
2d5eab2e1c
brew style --fix 2022-06-30 08:56:21 +01:00
Bo Anderson
40bbdc659e
Fix some Style/FetchEnvVar offences 2022-06-17 19:47:57 +01:00
Bo Anderson
a10b16828f
utils/analytics: use curl shim 2022-06-17 19:47:56 +01:00
Kyle Smith
7866a4b586 feat: support user-configured Google Analytics reporting
Allow users to set a custom Google Analytics tracking ID to report user behaviour
via new environment variable: $HOMEBREW_ADDITIONAL_GOOGLE_ANALYTICS_ID.

If provided, this tracking ID will be used _in addition to_ the default tracking
ID used by <https://brew.sh/analytics/>.
2021-10-19 10:49:43 -05:00
Rylan Polster
9b2a504207
Fix API fetch methods in Utils::Analytics 2021-08-09 18:39:49 -04:00
Rylan Polster
737dd1654b
Refactor API methods 2021-08-06 04:31:27 -04:00
Nanda H Krishna
5ccfbcd1d2
Autocorrect style issues with brew style --fix 2021-07-08 12:36:39 +05:30
Rylan Polster
4b8477ba70 Completions, Settings: move to Homebrew namespace 2021-01-13 11:20:28 -05:00
Rylan Polster
f1f3fdc315 settings: add module for managing git config settings 2021-01-12 16:27:25 -05:00
Mike McQuaid
8af4895479
Improve submitted analytics data
- Use default `custom-prefix` label on macOS ARM (as `/usr/local` is
  not the default).
- Add architecture (or Rosetta) to analytics event label.
- Don't send minor versions on Big Sur.
- Remove defunct `HOMEBREW_OSX_VERSION` reference.
2021-01-07 09:28:40 +00:00
Markus Reiter
6750448d95 Fix some auto-correctable type errors. 2020-11-29 21:23:54 +01:00
Markus Reiter
8598b1186a Handle macOS versions >= 11.1 correctly. 2020-11-23 13:46:15 +01:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Mike McQuaid
8b97c27c21 brew style manual fixes 2020-09-01 14:26:45 +01:00
Mike McQuaid
e09147fe75 brew style --fix 2020-09-01 14:26:45 +01:00
Markus Reiter
fd3225c89c Document Analytics. 2020-08-26 03:13:59 +02:00
Markus Reiter
490e503b1b Replace Homebrew.args with Context. 2020-08-06 16:13:14 +02:00