87 Commits

Author SHA1 Message Date
Mike McQuaid
aa81982aba
brew style --fix 2020-06-02 09:49:23 +01:00
Mike McQuaid
4f75a77b08
Update deprecations
Add more deprecations, disable deprecations and remove disabled code.
2020-05-18 13:50:46 +01:00
Mike McQuaid
9457d1af5e
pull: fix head_revision definition.
Fixes #7405.
2020-04-20 19:54:38 +01:00
Mike McQuaid
8b84ef5dc8
pull: cleanup more code.
Remove more unused code.
2020-04-20 10:09:22 +01:00
EricFromCanada
9d6eb41fc5 cmd/dev-cmd: misc. usage and wording fixes 2020-04-19 13:31:54 -04:00
Mike McQuaid
239b4c9d19
Remove last Jenkins references
- remove Jenkins Testing support from `brew pull`
- update reference to MacStadium Orka
- remove reference to DigitalOcean
2020-04-19 14:53:18 +01:00
Issy Long
3e2f183c60
pull: Remove --bottle flag
- Muscle memory is a thing, as is relying heavily on one's shell
  history. Now that the Jenkins runners are gone, `brew pull --bottle`
  no longer works. This removes the option. If maintainers are confused,
  they should [look at recent changes to the
  docs](https://docs.brew.sh/Brew-Test-Bot-For-Core-Contributors#bottling),
  or ask in Slack.
- An earlier iteration of this showed a deprecation warning and a link
  to the docs, but when an option no longer physically works it's a bit
  late for deprecation *warnings*.
- This also fixes a `brew style` warning from futher up in the file.

pull: Appease RuboCop
2020-04-12 11:24:22 +01:00
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig. 2020-04-07 09:58:26 +01:00
Mike McQuaid
1e265247ca
rubocop: apply autofixes. 2020-03-13 21:16:18 +00:00
Mike McQuaid
e3ac94fc5d
dev-cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
Issy Long
6d5f6ce96c
Revert "pull: use homebrew remote if HOMEBREW_FORCE_HOMEBREW_ON_LINUX"
- This reverts commit 9fb1876101a1abac8e3bfcc9f4f6fadbf0921c7c and commit
f8863c8a3bbef32dc65c9b95a57b54d7fc26c27e.
- The `JENKINS_HOME` envvar appears to be unset on the Linux Jenkins
master that holds the BinTray credentials.
- It's bed time, we're too tired to be fixing forward!
2020-02-24 22:56:33 +00:00
Dawid Dziurla
f8863c8a3b
pull: fix remote on jenkins 2020-02-24 23:26:28 +01:00
Mike McQuaid
5974714453
pull: add more docs comment context. 2020-02-24 11:41:29 +00:00
Dawid Dziurla
9fb1876101
pull: use homebrew remote if HOMEBREW_FORCE_HOMEBREW_ON_LINUX 2020-02-23 21:49:23 +01:00
EricFromCanada
2f7c3afeb8 cmd: improve wording of messages, spacing 2019-12-15 00:04:45 -05:00
Mike McQuaid
766fc4b301
Fix RuboCop 0.77.0 failures. 2019-11-28 15:10:50 +00:00
Mike McQuaid
8755e79475
pull: fix Homebrew Testing pull regression.
Don't fail if we fail to parse an issue when pulling.

While we're here, do some general code cleanup of stuff that's hard to
follow, named confusingly or duplicated unnecessarily.
2019-09-05 14:21:45 +01:00
EricFromCanada
8a8359cdd4 manpages: sentence rewording for readability
Use active voice when applicable, better verbs & adjectives, preposition usage, proper tense, etc.
2019-08-20 09:05:45 -04:00
Michka Popoff
a70179d8b7 pull: extract bottle publishing code
and add tests
2019-07-03 21:18:17 +02:00
Michka Popoff
3c25ddc6ed pull: allow to pull from merge commits 2019-07-03 21:05:21 +02:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
e40b171127
Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
EricFromCanada
560ccddb69 help: rewrap output to 80 columns
Accounts for paragraph breaks and option descriptions. Also fixes some help text nits.
2019-03-11 12:52:07 -04:00
Michka Popoff
45c61cdcdb pull: fix tap name for linuxbrew 2019-02-27 18:29:59 +01:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Mike McQuaid
bbea109926
dev-cmd: remove --help headers and tweak docs. 2019-01-30 21:39:28 +00:00
Shaun Jackman
f70a2c67da pull --bottle: Fix bug in any_bottle_tag
Utils::Bottles.tag is a symbol, whereas bottle_tags is an array of strings.
2018-11-01 09:28:31 -07:00
EricFromCanada
388781f6a7 dev-cmd/: remove colons from command specs.
These aren't needed when converting Parser-based help text to man page or Markdown formats.
Includes regenerated docs.
2018-10-19 13:12:55 -04:00
EricFromCanada
ddf057f3dd dev-cmd/: edit help text and descriptions. 2018-10-19 13:12:11 -04:00
EricFromCanada
20167e5f1b Adjust comments to tidy API docs output. 2018-10-18 21:42:43 -04:00
EricFromCanada
997a207889 docs: fix Official External Commands section
Work around ronn's inability to nest indents within list items by modifying its output to add a line break and indent after lines ending with a colon that aren't a list item's first line. This allows `brew.1.md.erb` to join the commands' help text without extra line breaks, which avoids the issue where kramdown was turning any command specs containing pipe characters into tables in the HTML output.
2018-10-05 23:47:48 -04:00
Gautham Goli
a03d2e0cd1
man: Correct option synopsis 2018-10-03 19:49:46 +05:30
Gautham Goli
7b0f27ca39
style: Fix style errors 2018-10-03 19:49:46 +05:30
Gautham Goli
f60582ca48
man: Remove [] from command synopsis 2018-10-03 19:49:45 +05:30
Gautham Goli
3c74683d88
man: Format h3 tags in ronn output 2018-10-03 19:49:45 +05:30
Gautham Goli
446b1cb9e3
man: Seperate global options into a section 2018-10-03 19:49:45 +05:30
Gautham Goli
e0e876cf37
man: Make command heading H3 2018-10-03 19:49:44 +05:30
Gautham Goli
4f58f2db99
man: Generate dev cmd manpages 2018-10-03 19:49:41 +05:30
Gautham Goli
b6c456b681
Extract out arg parsing method to <cmd>_args method 2018-10-03 19:19:04 +05:30
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
3a0a9f9073 Add String#delete_prefix backport. 2018-09-16 20:07:34 +02:00
Markus Reiter
072127197a Check for range support instead of rescuing error. 2018-09-06 16:25:22 +02:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Gautham Goli
fba52e2f74 cli_parser: Store parsed args in Homebrew.args and access args everywhere else 2018-05-30 00:05:39 +05:30
Alyssa Ross
bdfbc70c87
pull: only add gpg to path if enabled in git 2018-05-22 23:35:50 +02:00
Alyssa Ross
96b95a838a
Fix brew pull with git commit.gpgsign enabled
Because of environment filtering, git tries to sign the commit but
can't find gpg, which means that the patch won't be applied.
2018-05-12 21:25:55 +01:00
Gautham Goli
48aecf2fa7 cli_parser: Refactor required argument for flag to '=' 2018-04-14 19:04:24 +05:30
Gautham Goli
d22b750e17 Store common switch as Homebrew.args global var 2018-04-10 00:00:35 +05:30