664 Commits

Author SHA1 Message Date
Jack Nagel
3bbc9998a5 Rewrite debugger to remove monkeypatches and use of call/cc 2014-09-18 14:16:07 -05:00
Jack Nagel
f3b7c3236b Consistently call name on formula instead of relying on to_s 2014-09-14 11:19:30 -05:00
Mike McQuaid
9531ecc72a Use bundler for test gem dependencies.
Closes Homebrew/homebrew#31986.
References Homebrew/homebrew#31981.
2014-09-10 13:29:14 +01:00
Mike McQuaid
f4d87d41be test.pcap: add pcap fixture. 2014-09-08 09:05:23 +01:00
Jack Nagel
356c391dfb Rewrite fails_with tests as tests for CompilerFailure 2014-08-31 13:40:51 -05:00
Jack Nagel
372945299d Use the accessors to update the test double 2014-08-30 23:41:12 -05:00
Jack Nagel
8b338bd534 Test CompilerSelector against a SoftwareSpec instance 2014-08-30 23:38:48 -05:00
Jack Nagel
eec50f0a9a Remove unnecessary empty block 2014-08-30 23:25:46 -05:00
Jack Nagel
2e2c348944 Test fails_with against spec objects 2014-08-30 23:25:46 -05:00
Jack Nagel
842b051aa7 Test against real CompilerFailure objects 2014-08-30 23:11:02 -05:00
Jack Nagel
b4a634903e Remove obsolete nil check 2014-08-30 23:11:02 -05:00
Jack Nagel
309001fd9f Fix tests on 1.8 2014-08-30 02:01:17 -05:00
Jack Nagel
750d7bb2c8 Options internals no longer need to support switches 2014-08-29 19:38:32 -05:00
Jack Nagel
b14851903c Add a method for retrieving only flags from ARGV 2014-08-29 19:38:32 -05:00
Jack Nagel
6885f588d0 Move handling of leading dashes to Options.create 2014-08-29 19:38:32 -05:00
Jack Nagel
e18da89f3c Implement ARGV.named in terms of ARGV.options_only 2014-08-28 22:11:08 -05:00
Jack Nagel
f7f8ca45fc Remove to_str from Option
We no longer need implicit conversion of options to strings.
2014-08-27 14:08:14 -05:00
Jack Nagel
af3d551de7 Options no longer needs deep-copy semantics
Follow-up to 23d90a6a187a57fbdf4eeac146993e3b37c3d4d9.
2014-08-20 19:05:49 -05:00
Jack Nagel
c7444d34f7 Use the as_flags method instead of map 2014-08-14 01:00:23 -05:00
Jack Nagel
2311181b54 Remove Options#concat 2014-08-13 18:16:25 -05:00
Jack Nagel
d443089270 Simplify tab test setup 2014-08-13 17:15:03 -05:00
Jack Nagel
eed8af9b80 Drop unnecessary parens in tests 2014-08-13 17:14:55 -05:00
Jack Nagel
e40143efd5 Drop unnecessary to_a calls in options tests 2014-08-13 11:09:57 -05:00
Jack Nagel
268cd143be Replace Options.coerce with an alternate constructor 2014-08-13 11:09:57 -05:00
Jack Nagel
094c184b12 Remove unused branches from Options.coerce 2014-08-13 11:09:57 -05:00
Jack Nagel
a980938773 Options is no longer used directly by BuildOptions 2014-08-13 11:09:57 -05:00
Jack Nagel
c5a888fb3a Always pass an Options instance to the BuildOptions constructor 2014-08-13 11:09:57 -05:00
Mike McQuaid
9f14262d92 Revert "Always pass an Options instance to the BuildOptions constructor"
This reverts commit e143bcef259ca76b2124e6e73bd9bdf872418723.

Closes Homebrew/homebrew#31557.
Closes Homebrew/homebrew#31559.
Closes Homebrew/homebrew#31561.
Closes Homebrew/homebrew#31562.
2014-08-13 08:46:17 +01:00
Mike McQuaid
1e852a8f3f Revert "Options is no longer used directly by BuildOptions"
This reverts commit 1c05bc0238aa1abf7d5542b8afa11ead2bee66a8.
2014-08-13 08:45:07 +01:00
Mike McQuaid
00d1bb8d12 Revert "Remove unused branches from Options.coerce"
This reverts commit cee42c339e7632eab15111e2c4e6c121ace6f9e2.
2014-08-13 08:45:07 +01:00
Mike McQuaid
a61c3615d2 Revert "Replace Options.coerce with an alternate constructor"
This reverts commit 8d2ef974a3a87bf4207f71ccb8a7b4776e16a016.
2014-08-13 08:45:06 +01:00
Mike McQuaid
f93a9aafca Revert "Drop unnecessary to_a calls in options tests"
This reverts commit 6f29c36aed9d951499146054a4caca702fa33d1a.
2014-08-13 08:45:04 +01:00
Jack Nagel
445a512379 Drop unnecessary to_a calls in options tests 2014-08-13 00:33:18 -05:00
Jack Nagel
25395c6de6 Replace Options.coerce with an alternate constructor 2014-08-12 23:55:28 -05:00
Jack Nagel
0a2be32d80 Remove unused branches from Options.coerce 2014-08-12 23:55:28 -05:00
Jack Nagel
28bd10551f Options is no longer used directly by BuildOptions 2014-08-12 20:23:02 -05:00
Jack Nagel
ecaf1592a0 Always pass an Options instance to the BuildOptions constructor 2014-08-12 20:09:35 -05:00
Jack Nagel
15162911e3 Deep copies of the build object are no longer needed 2014-08-11 17:48:30 -05:00
Jack Nagel
161778f0f4 Stop exposing defined options from the build object 2014-08-10 22:55:28 -05:00
Jack Nagel
f306e56d21 Add a test for legacy options 2014-08-10 16:47:34 -05:00
Jack Nagel
ca3c727267 Stop exposing combined options from the tab 2014-08-09 16:27:57 -05:00
Jack Nagel
f0b75b2869 Stop duping options when duping the build object
The options collection cannot be mutated from the build object, so it
can be shared among copies safely.
2014-08-09 10:30:43 -05:00
Jack Nagel
618bb9b413 Better assertions in tab test 2014-08-08 23:31:58 -05:00
Jack Nagel
472a2cec1e Avoid using setters in tab tests 2014-08-07 17:39:55 -05:00
Jack Nagel
0c51cf1245 Use predefined options for universal, cxx11, and 32-bit options
:universal and :cxx11 are now handled directly, so we don't need to
always convert symbols to strings in this method. Symbols should be
reserved for future use.
2014-08-07 10:45:32 -05:00
Jack Nagel
acc1c35f35 Raise ArgumentError for argument errors 2014-08-07 00:48:13 -05:00
Jack Nagel
20452f3edc Add more test coverage for option descriptions 2014-08-07 00:48:13 -05:00
Jack Nagel
fa88b9697c Add a test for cxx11 option special case 2014-08-07 00:03:32 -05:00
Jack Nagel
fccfddb510 Partially revert e1f97e2 to pass new test cases 2014-08-02 20:03:42 -05:00
Jack Nagel
142beddd7a Use polymorphism to simplify stdlib compatibility check 2014-08-02 19:29:59 -05:00