Jack Nagel
ae4b9fffd4
Avoid hardcoding the class name
2014-08-13 23:45:48 -05:00
Jack Nagel
edbb219bbd
More idiomatic way to combine arrays
2014-08-13 20:54:49 -05:00
Jack Nagel
2311181b54
Remove Options#concat
2014-08-13 18:16:25 -05:00
Jack Nagel
0d6ceaf86e
Simplify build_argv
2014-08-13 18:16:25 -05:00
Jack Nagel
d443089270
Simplify tab test setup
2014-08-13 17:15:03 -05:00
Jack Nagel
eed8af9b80
Drop unnecessary parens in tests
2014-08-13 17:14:55 -05:00
Jack Nagel
e40143efd5
Drop unnecessary to_a calls in options tests
2014-08-13 11:09:57 -05:00
Jack Nagel
268cd143be
Replace Options.coerce with an alternate constructor
2014-08-13 11:09:57 -05:00
Jack Nagel
094c184b12
Remove unused branches from Options.coerce
2014-08-13 11:09:57 -05:00
Jack Nagel
a980938773
Options is no longer used directly by BuildOptions
2014-08-13 11:09:57 -05:00
Jack Nagel
886c20ddba
Set methods on Options already return Options instances
2014-08-13 11:09:57 -05:00
Jack Nagel
c5a888fb3a
Always pass an Options instance to the BuildOptions constructor
2014-08-13 11:09:57 -05:00
Jack Nagel
5c1c9e6550
Only store strings in the tab object
2014-08-13 11:09:57 -05:00
Mike McQuaid
9f14262d92
Revert "Always pass an Options instance to the BuildOptions constructor"
...
This reverts commit e143bcef259ca76b2124e6e73bd9bdf872418723.
Closes Homebrew/homebrew#31557 .
Closes Homebrew/homebrew#31559 .
Closes Homebrew/homebrew#31561 .
Closes Homebrew/homebrew#31562 .
2014-08-13 08:46:17 +01:00
Mike McQuaid
d4aa7b8df0
Revert "Set methods on Options already return Options instances"
...
This reverts commit 4d1464c246861f7aedc355cb5f6360370d05114e.
2014-08-13 08:45:08 +01:00
Mike McQuaid
1e852a8f3f
Revert "Options is no longer used directly by BuildOptions"
...
This reverts commit 1c05bc0238aa1abf7d5542b8afa11ead2bee66a8.
2014-08-13 08:45:07 +01:00
Mike McQuaid
00d1bb8d12
Revert "Remove unused branches from Options.coerce"
...
This reverts commit cee42c339e7632eab15111e2c4e6c121ace6f9e2.
2014-08-13 08:45:07 +01:00
Mike McQuaid
a61c3615d2
Revert "Replace Options.coerce with an alternate constructor"
...
This reverts commit 8d2ef974a3a87bf4207f71ccb8a7b4776e16a016.
2014-08-13 08:45:06 +01:00
Mike McQuaid
f93a9aafca
Revert "Drop unnecessary to_a calls in options tests"
...
This reverts commit 6f29c36aed9d951499146054a4caca702fa33d1a.
2014-08-13 08:45:04 +01:00
Jack Nagel
445a512379
Drop unnecessary to_a calls in options tests
2014-08-13 00:33:18 -05:00
Jack Nagel
25395c6de6
Replace Options.coerce with an alternate constructor
2014-08-12 23:55:28 -05:00
Jack Nagel
0a2be32d80
Remove unused branches from Options.coerce
2014-08-12 23:55:28 -05:00
Jack Nagel
28bd10551f
Options is no longer used directly by BuildOptions
2014-08-12 20:23:02 -05:00
Jack Nagel
1c49729222
Set methods on Options already return Options instances
2014-08-12 20:19:56 -05:00
Jack Nagel
ecaf1592a0
Always pass an Options instance to the BuildOptions constructor
2014-08-12 20:09:35 -05:00
Misty De Meo
a43f450544
Clarify keg-only caveats
2014-08-12 17:28:49 -07:00
Jack Nagel
f40650ecd0
Set the remote config manually
...
See 5cd6b35 and 8eefd4e.
2014-08-12 01:46:12 -05:00
Jack Nagel
15162911e3
Deep copies of the build object are no longer needed
2014-08-11 17:48:30 -05:00
Jack Nagel
b7b8b88cea
Replace the build object rather than mutate it
2014-08-11 17:48:30 -05:00
Jack Nagel
0b468c528c
Allow build to be set externally
2014-08-11 17:48:30 -05:00
Mike McQuaid
1455d83dd8
formula_installer: check for recommended/optional.
...
build.without? seemingly always returns true for requirements that are
neither recommended nor optional so check these before deciding not to
install a default formula.
Closes Homebrew/homebrew#31511 .
2014-08-11 20:18:15 +01:00
Mike McQuaid
4790d4cba9
formula_installer: default_formula using build.
...
Use the build options instead of whether the requirement is optional to
work out if it is needed. This handles the case of an optional
requirement becoming needed because it's a dependency for another
formula.
Closes Homebrew/homebrew#31476 .
2014-08-11 15:33:35 +01:00
Jack Nagel
045a02aa74
Use public api when adding legacy options
2014-08-10 23:17:53 -05:00
Jack Nagel
161778f0f4
Stop exposing defined options from the build object
2014-08-10 22:55:28 -05:00
Jack Nagel
8beb85a7fc
options.each only yields one argument to the block
2014-08-10 22:24:56 -05:00
Jack Nagel
2f1d40a764
Disconnect defined options from the build object
2014-08-10 21:45:24 -05:00
Jack Nagel
8fc4bba03a
Remove user-defined options method after evaluation
...
Now we can use the superclass options method for our own purposes.
2014-08-10 21:45:23 -05:00
Jack Nagel
d122ae8eea
Handle legacy options in the method_added hook
...
We only need to process the legacy options at load time, not each time
the class is instantiated, and only when there is an options method
defined.
2014-08-10 21:45:23 -05:00
Jack Nagel
f306e56d21
Add a test for legacy options
2014-08-10 16:47:34 -05:00
Mike McQuaid
064aff2591
Revert "formula_installer: fix reqs default formulae."
...
This reverts commit 435092ae0521e79d8ea21c8d4708031e3b4b17a3.
2014-08-10 16:41:30 +01:00
Tomasz Pajor
03cf38c451
formula_installer: fix reqs default formulae.
...
(Commit message written by Mike McQuaid)
With the change in a0a93f1b3b7b2be9b8a319be91086ffe220f8e32
unfortunately requirements with default formulae no longer could be
resolved when the default formulae were not installed. This commit
fixes this problem.
Closes Homebrew/homebrew#31476 .
Closes Homebrew/homebrew#31444 .
Closes Homebrew/homebrew#30901 .
Closes Homebrew/homebrew#31471 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-08-10 15:26:13 +01:00
Jack Nagel
47fedf2951
Update tap README template
2014-08-09 22:45:02 -05:00
Jack Nagel
11470e2a1a
Don't compare versions against floating point numbers
2014-08-09 22:01:28 -05:00
Jack Nagel
04056284ba
Realign case statement
2014-08-09 22:01:28 -05:00
Jack Nagel
62c6b281c9
Update unreleased version check
2014-08-09 22:01:28 -05:00
Dominyk Tiller
97af5a29f7
Initial Yosemite Support
...
Closes Homebrew/homebrew#31435 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-08-09 21:57:04 -05:00
Jack Nagel
2a5218dacc
Remove unnecessary lasgn
2014-08-09 17:50:55 -05:00
Jack Nagel
47a82b036e
Move tab creation outside of the debug loop
2014-08-09 17:50:53 -05:00
Jack Nagel
105db77fc0
Extract build-time stdlib check to a method
2014-08-09 17:50:52 -05:00
Jack Nagel
f743351c60
Cache options hash lookup on the stack
2014-08-09 17:38:45 -05:00
