Jack Nagel
9c5149b85a
Stop exposing mirrors array
2014-07-23 13:09:28 -05:00
Jack Nagel
c3a5b1152e
Stop exposing the downloader as an attribute
2014-07-22 19:14:30 -05:00
Jack Nagel
d99379bc63
Hide the downloader implementation from the installer
2014-07-22 19:14:30 -05:00
Jack Nagel
2b1b7ef0e4
Ruby 1.8 doesn't have the \h regexp metacharacter
2014-07-21 17:27:37 -05:00
Mike McQuaid
31a444ef16
dependency_collector: add :java symbol
2014-07-21 19:14:15 +01:00
Mike McQuaid
7e7b721797
requirements: add JavaDependency.
...
Requested in Homebrew/homebrew-science#1039 .
Closes Homebrew/homebrew#30852 .
2014-07-21 19:14:15 +01:00
Mike McQuaid
19dce37a5f
brew-pull: don't fail to pull on Formula exception
2014-07-21 15:43:54 +01:00
Jack Nagel
f34fcd7781
Simplify onoe
2014-07-20 19:47:31 -05:00
Jack Nagel
5abcfad97e
Fix install names in files in sbin
2014-07-20 18:37:49 -05:00
Adam Vandenberg
8b5397fa28
improve comment
2014-07-20 12:17:06 -07:00
Adam Vandenberg
929fd44082
use ObserverPathnameExtension to remove these files
2014-07-20 12:17:06 -07:00
Adam Vandenberg
557f887f24
add clarifying comments
2014-07-20 12:17:06 -07:00
Adam Vandenberg
b0138e447d
fix comment
2014-07-19 23:28:39 -07:00
Jack Nagel
86b3090d4d
Passing an empty array to puts prints nothing
2014-07-19 23:59:44 -05:00
Jack Nagel
7078af8218
Pass the string directly to the output method
2014-07-19 23:50:59 -05:00
Jack Nagel
d2aeadb1cd
Pass array to puts instead of iterating over it
2014-07-19 23:36:02 -05:00
Jack Nagel
c18eea6a17
Default to stdout since other code calls this method
2014-07-19 23:28:56 -05:00
Jack Nagel
74ad97ce7f
Remove intermediate method
2014-07-19 22:55:49 -05:00
Jack Nagel
a150403eb9
brew-gist-logs: dump config directly
2014-07-19 22:37:22 -05:00
Jack Nagel
010bd2783e
Allow verbose config to be written to any IO object
2014-07-19 22:33:59 -05:00
Jack Nagel
c0579443f2
Don't mess with stdout when writing build config to a file
2014-07-19 22:33:00 -05:00
Jack Nagel
a9c5e81a48
Remove a conditional and always pass the spec to satisfied_requirements
2014-07-19 22:19:02 -05:00
Jack Nagel
d706bcf153
Remove the patch from the cache after applying it
2014-07-19 21:55:02 -05:00
Jack Nagel
01be861deb
Use if-else instead of postfix unless
2014-07-19 20:58:47 -05:00
Jack Nagel
26b8c5a27d
Improve pull request URL regexp
...
- use a regexp literal and avoid escaping forward slashes
- escape the period in "github.com"
- match only hex characters in the commit part
- allow hyphen in usernames and repo names, matching what we allow for
tap names
- avoid unnecessary capture
2014-07-19 20:25:32 -05:00
Maurus Cuelenaere
efcfbcc98b
Fix checking out recursive git submodules
...
When nested submodules appear in a git repository, the `git submodule foreach
git checkout-index ..` command would fail because it would checkout at the root
directory instead of in its parent(s)' folder.
Eg: root/submodule1/submodule2 would be checked out in root/submodule2
Closes Homebrew/homebrew#30841 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-18 21:02:56 -05:00
Dan
8bc5d71315
clang doesn't support -fuse-linker-plugin
...
Closes Homebrew/homebrew#30930 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-18 16:11:20 -05:00
Jack Nagel
6f02314cba
Add a factory method that accepts a formula object
2014-07-18 15:15:12 -05:00
Jack Nagel
49a97c280a
Ask the filename object for the prefix
2014-07-18 15:15:12 -05:00
Jack Nagel
1cc3747094
Move bottle URL construction to the bottle object
2014-07-18 15:15:11 -05:00
Jack Nagel
a87d2108ea
Move bottle filename construction to a class
2014-07-18 15:14:57 -05:00
Jack Nagel
7d28a6c54b
exec_editor with no arguments should not silently succeed
2014-07-18 12:36:26 -05:00
Jack Nagel
a5895ad1fe
Check nil? || empty? instead of to_s.empty?
2014-07-18 11:43:37 -05:00
Jack Nagel
3439703c65
Drop pointless to_s call
2014-07-18 11:43:37 -05:00
Jack Nagel
598e7010f9
Remove dead code
...
This method is identical to the superclass implementation.
2014-07-17 21:55:21 -05:00
Jack Nagel
44fcb24606
Spell out "formula" in parameter name
2014-07-17 20:46:39 -05:00
Jack Nagel
b08c070481
Only ask for the stem once
2014-07-17 19:55:58 -05:00
Jack Nagel
22038d5269
Remove special case for now-deprecated GitHub URLs
2014-07-17 15:18:13 -05:00
Jack Nagel
07003f43ca
Call size on the path
2014-07-17 15:01:27 -05:00
Jack Nagel
ddefbe2c85
Use locals instead of repeatedly converting pathnames to strings
2014-07-17 15:01:26 -05:00
Jack Nagel
ecc9407fed
Remove deprecated options from brew-diy
2014-07-17 12:24:03 -05:00
Jack Nagel
8df33f7446
diy: use configure as the heuristic for autotools
...
Closes Homebrew/homebrew#30912 .
2014-07-17 12:14:17 -05:00
Phillip Calvin
d4b6d8ec96
Remove commentary from error message
...
It might be best not to use the word "lame" here, as it's often considered to be an ableist slur.
Closes Homebrew/homebrew#30915 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-17 12:11:57 -05:00
Jack Nagel
4295e76d3f
Remove more dead code
2014-07-16 23:22:04 -05:00
Jack Nagel
28f0e5c4fd
Don't raise when converting the tag to a version fails
2014-07-16 21:11:48 -05:00
Jack Nagel
596f3ba0a0
Raise ArgumentError when a symbol can't be mapped to a version
...
The fact that this is implemented as a hash lookup is an implementation
detail, so don't let the KeyError bubble up.
2014-07-16 21:11:48 -05:00
Jack Nagel
a554b5c9b7
Rename test
2014-07-16 21:11:48 -05:00
Jack Nagel
ab41071d2b
Separate tag matching and checksum lookup
2014-07-16 21:11:48 -05:00
Jack Nagel
005f41c02a
Use [] on the instance rather than the wrapped hash
2014-07-16 18:54:19 -05:00
Jack Nagel
8044c4524b
Rename variable
2014-07-16 18:54:19 -05:00