42 Commits

Author SHA1 Message Date
Bo Anderson
9063945b3e
Promote shell commands audit to global cop 2021-03-17 20:45:41 +00:00
Seeker
7e7274aaeb rubocops: use Style/UnlessLogicalOperators
Replaces `Style/UnlessMultipleConditions`
2021-03-03 01:39:11 -08:00
Seeker
4c42d717fd
rubocops: add cops to check bottle format, indentation, and order
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2021-02-03 20:46:20 -05:00
Seeker
b9854bd4cf rubocops: add unless_multiple_conditions 2021-01-08 10:33:54 -08:00
Seeker
c4da302303 on_macos/on_linux block: improve rubocop message
Co-authored-by: Markus Reiter <me@reitermark.us>
2020-12-10 11:47:25 -08:00
Mike McQuaid
8528eff604
Add and enable rubocop-rails.
This will help us catch and cleanup usage of e.g. `.blank?` and other
helpers we use from ActiveSupport.
2020-12-02 10:43:04 +00:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Markus Reiter
c2a0ba8e87 Enable rubocop-sorbet. 2020-10-09 16:45:13 +02:00
nandahkrishna
7c3c459f47
livecheck: add RuboCops 2020-09-17 15:57:19 +05:30
Rylan Polster
842335d47b style: check disable! dates and reasons 2020-08-31 10:11:08 -04:00
Rylan Polster
9520eabc35 style: enforce ISO-8601 in deprecation date 2020-06-26 11:53:42 -04:00
Mathäus Zingerle
82ba0475ad audit: Port version checks that do not rely on Formula state to RuboCop and add tests 2020-05-18 10:12:13 -05:00
vidusheeamoli
f851688541 audit: Port audit_keg_only to rubocop and add tests
audit: add test

audit: fixed test

audit: added another test case

audit: fix test

audit: fix test

audit: fix keg only
2020-05-05 10:47:49 +05:30
Mike McQuaid
8eed72cd8b
Move file mode audit to RuboCop. 2020-04-18 15:44:24 +01:00
Issy Long
857393ccfb
Audit correct uses_from_macos usage with RuboCop
- This builds on @jonchang's work that started in #6265.
- We now use `uses_from_macos` to declare dependencies that are implicit
  on macOS because they ship with macOS, but they're needed on Linux. We
  have to be sure that the dependencies people specify as
  `uses_from_macos` are actually shipped with macOS. So, we maintain a
  safelist of those dependencies and check against it.
- Also add more legitimate `uses_from_macos` dependencies to the list.
- This is runnable with `brew audit --only-cops=FormulaAudit/UsesFromMacos`.
- It produces different number of failures on macOS vs. Linux, because
  apparently we've not synced Homebrew/linuxbrew-core upstream thoroughly
  enough yet.
- Originally this was designed as a `--strict` audit, but we flipped it
  to be a normal audit because - to quote Mike - this is "sufficiently
  robust" now.
2020-04-06 13:42:27 +01:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
491ceb6c4c
Import rubocop-cask (with clean brew style) 2018-11-08 15:54:46 +00:00
Mike McQuaid
376eac2b8d
rubocops: rename files for consistency.
Make the filenames consistent with the class names.
2018-11-08 14:42:55 +00:00
Mike McQuaid
800853a28d
Vendor rubocop-rspec
We aren't going to vendor its dependencies because we already require
a systemwide installation of `rubocop` to work in your editor. This
avoids requiring users to manually do another
`gem install rubocop-rspec` to have their editor integration behave as
expected.
2018-10-14 12:11:54 -07:00
Markus Reiter
eca488a966 Add $LOAD_PATH for RuboCop cops. 2018-09-06 01:10:47 +02:00
Mike McQuaid
0aa9dce03c
Revert "Add $LOAD_PATH for RuboCop cops." 2018-09-02 20:49:25 +01:00
Markus Reiter
444e3d2a78 Add $LOAD_PATH for RuboCop cops. 2018-08-29 01:44:47 +02:00
commitay
44873fd4c8 bottle_block_cop: remove 2018-07-04 21:25:43 +10:00
Gautham Goli
09f343d496 rubocop: Add cop to check depends_on order and tests 2018-03-01 12:32:25 +05:30
Gautham Goli
4ec26aea40 audit: Port audit_class to rubocop, add tests and autocorrect 2017-09-04 23:43:42 +05:30
Gautham Goli
66ffdb5b06 Refactor legacy_patches_cop to merge external patch audit rules in a single cop and add tests 2017-08-05 21:51:24 +05:30
Gautham Goli
e1cb0b43d7 audit: Port dependency rules from line_problems to rubocop and add tests 2017-07-29 16:36:32 +05:30
Gautham Goli
b7ddd271e1 audit: Port audit_urls partially to rubocop and add corresponding tests 2017-07-21 20:50:28 +05:30
Gautham Goli
b8adc1a8aa audit: Port audit_options non-strict rules to rubocop and add tests 2017-07-13 12:41:43 +05:30
Gautham Goli
4ed34f91c2 audit: Port audit_conflicts method to rubocop and add tests 2017-07-07 20:46:57 +05:30
Gautham Goli
e6938d9201 Enable LegacyPatches cop 2017-06-30 20:25:18 +05:30
Gautham Goli
4d7a983415 audit: Port audit_checksum method to rubocop and add tests 2017-06-16 19:45:16 +05:30
Mike McQuaid
113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Gautham Goli
d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Gautham Goli
51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Gautham Goli
91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Gautham Goli
413a7e5dae Port audit_components method to rubocops and add corresponding tests 2017-04-22 21:53:16 +05:30
Gautham Goli
19f693d25b Port audit_desc rules to cop 2017-03-02 12:50:05 +05:30
Gautham Goli
5dc358c1b7 Update rubocop config 2017-02-12 14:52:13 +05:30