56 Commits

Author SHA1 Message Date
Jack Nagel
bac25a77bf Elaborate on why we should remove this code 2014-04-19 21:40:44 -05:00
Jack Nagel
8d6c1358a2 Update comment 2014-04-15 14:26:12 -05:00
Jack Nagel
538dea98ad Start cleaning up Xcode.version 2014-04-15 14:20:18 -05:00
Jack Nagel
20c150fb8c Xcode.bad_xcode_select_path? is used only once, so inline it 2014-04-15 11:28:52 -05:00
Jack Nagel
490cb34885 Remove unnecessary xcode-select check
This is handled here:
67fbb313da/Library/brew.rb (L34-46)
2014-04-15 11:21:27 -05:00
Jack Nagel
fcda7a1086 Document some unanswered questions in the Xcode module 2014-04-15 10:08:59 -05:00
Jack Nagel
2d8d7184f6 Remove dead constant 2014-04-15 09:49:01 -05:00
Misty De Meo
89692b34a8 Xcode.prefix: remove osx-gcc-installer hack
This hack is starting to outlive its usefulness, and produces false
positives.

Fixes Homebrew/homebrew#28147.
2014-04-04 15:26:41 -07:00
Jack Nagel
55b0ee787a Remove dead code 2014-04-01 22:54:15 -05:00
Jack Nagel
0d3121f781 Batch up mdfind calls when possible 2014-04-01 20:47:26 -05:00
Jack Nagel
97ca3baedc Avoid calling xcodebuild twice 2014-04-01 18:51:34 -05:00
Misty De Meo
3943a77832 CLT.installed?: base result on version detection
CLT.installed? previously returned false if the user had outdated dev
tools installed after a 10.9 upgrade, which was confusing to users.
2014-03-26 10:35:30 -07:00
Mike McQuaid
3b0eef09e9 Remove unnecessary swearing. 2014-03-22 10:14:20 +00:00
Jack Nagel
cca7d1a96f Update latest CLT version check 2014-03-10 15:39:16 -05:00
Jack Nagel
5bd5e05541 Recognize Xcode 5.1 and CLT 5.1
Closes Homebrew/homebrew#27389.
Fixes Homebrew/homebrew#27390.
2014-03-10 15:26:36 -05:00
Adam Vandenberg
3b24d9f0be latest xcode is 5.0.2
Closes Homebrew/homebrew#26943.
2014-02-23 13:15:53 -08:00
Misty De Meo
d1d6451a6a CLT.version: check 10.9 CLT first
10.9 users might have older CLT receipts sitting around, which could
result in bad pkgutil results. For example, before changing this, my
`brew --config` was printing '1.0' (the 10.7 version) instead of
'5.0.1.0.1.1382131676', the actual CLT I had installed.
2013-12-14 16:21:00 -08:00
Mike McQuaid
4c2e7b1659 Update docs, comment mxcl/homebrew refs. 2013-12-14 18:18:35 +00:00
Jack Nagel
36d3a2dfa8 Homebrew CVS is required for Xcode 5+ 2013-12-04 01:19:17 -06:00
Misty De Meo
426f5c0666 Fix MacOS::CLT.installed? for 10.9+
This continues to use mavericks_dev_tools? instead of trying to read
from pkgutil because pkgutil is really slow.

Fixes Homebrew/homebrew#24123.
2013-11-22 20:47:57 -08:00
Mike McQuaid
90c696ea67 xcode: fix nil outdated comparison. 2013-11-08 09:54:25 +00:00
Jack Nagel
0aa7457b79 Fix CLT latest version check for 10.8/9
Closes Homebrew/homebrew#23874.
2013-11-01 18:58:19 -05:00
Jack Nagel
a5e8962ae7 Avoid comparing Xcode.version to floats 2013-10-22 20:48:22 -05:00
Jack Nagel
df824a22a7 Avoid comparing MacOS.version to floats 2013-10-22 20:47:37 -05:00
Mike McQuaid
6030695bee xcode: update to 5.0.1 on 10.8. 2013-10-23 00:45:19 +01:00
Mike McQuaid
047c8eb927 CLT: correctly find Mavericks CLT PKG.
Closes Homebrew/homebrew#23445.
2013-10-22 23:56:22 +01:00
Mike McQuaid
1be35f036e Xcode: don't detect Mavericks CLT as Xcode. 2013-10-22 22:37:09 +01:00
Mike McQuaid
a7c29271b8 CLT: rename Mavericks CLT path constant. 2013-10-22 22:36:41 +01:00
Jack Nagel
31d705d494 Assume unknown clang versions are post-Xcode 5 2013-10-22 13:46:14 -05:00
Jack Nagel
8887fe7606 Move MacOS modules under OS::Mac namespace
Closes Homebrew/homebrew#23138.
2013-10-18 13:38:07 -05:00
Jack Nagel
c511d7d2f4 Add OS.mac? and OS.linux? 2013-10-18 12:56:51 -05:00
Jack Nagel
9c53a1b8b7 Recommend Xcode 5.0.1 GM on 10.9 2013-10-06 17:24:22 -05:00
Mike McQuaid
535c02674c Add Xcode 5.0.1.
Closes Homebrew/homebrew#23040.
2013-10-04 09:56:02 +01:00
Mike McQuaid
ee79f31516 xcode: Xcode 5.0 is the latest on 10.8. 2013-10-04 09:55:26 +01:00
Jack Nagel
6e4ad9eb22 Fix wrong assumption in MacOS::Xcode.without_clt?
Fixes Homebrew/homebrew#22221.
2013-08-30 14:49:10 -05:00
Jack Nagel
755c786040 Move MacOS.xcode43_without_clt? into Xcode module 2013-08-09 20:47:28 -05:00
Jack Nagel
d6ed7fea4a Cache pkgutil results at the source 2013-07-21 20:09:55 -05:00
Jack Nagel
a1e7d7177f Eliminate nested conditional 2013-07-21 16:41:51 -05:00
Jack Nagel
9f2f5c81e9 Extract bundle_path method from Xcode#prefix 2013-07-21 16:41:51 -05:00
Jack Nagel
d9b9b77fa6 Update comment about CLT
This was worded in a confusing way, and made an assumption about future
OS X versions that we don't know to be true.

Also, it's probably wrong to state that the CLT location is dependent on
the OS X version; surely there will be a newer CLT for 10.8 that gets
installed in the same location as on 10.9. But we don't know any better
yet.
2013-07-21 16:41:50 -05:00
Jack Nagel
aa2554640d Split up unreadable conditional 2013-07-21 16:41:50 -05:00
Mike McQuaid
621c44dbd2 CLT is just CLT now; not "for Xcode".
References Homebrew/homebrew#17383.
2013-07-01 19:02:32 +01:00
David Rice
59f3d0d6f6 Detect Command Line Tools on Mavericks.
Closes Homebrew/homebrew#20774.
2013-06-26 19:09:06 +01:00
Clemens Gruber
c5f9f42e51 Fix Xcode builds on 10.9.
CLT-only builds are still broken and need to be fixed at some point.

Closes Homebrew/homebrew#20524.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-06-17 09:14:17 +01:00
Jack Nagel
e9d245cf3a Avoid unnecessary float to string conversion 2013-06-15 10:13:20 -05:00
Jack Nagel
4498db7887 Xcode 4.6.3 2013-06-13 18:22:28 -05:00
Clemens Gruber
15626b38ca Recognize OS X 10.9 and Xcode 5.0
Closes Homebrew/homebrew#20410.
Closes Homebrew/homebrew#20401.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-06-11 10:20:23 -05:00
Mike McQuaid
bca356dd70 Don't error out on unreleased OSX versions.
References Homebrew/homebrew#20142.
2013-06-04 13:58:08 +01:00
Misty De Meo
8559725645 MacOS::Xcode.latest_version: add Tiger 2013-05-23 18:44:50 -05:00
Jack Nagel
dd280cc0b1 MacOS.version in case statement doesn't work with ranges 2013-05-22 22:59:38 -05:00