135 Commits

Author SHA1 Message Date
Patrick Linnane
a975ad1a5c
Fix: Sparkle audit prior to el_capitan 2022-11-02 21:30:51 -07:00
Sean Molenaar
f5c6667980
Update Library/Homebrew/cask/audit.rb
Co-authored-by: Bo Anderson <mail@boanderson.me>
2022-11-01 21:13:03 +01:00
Sean Molenaar
94c0d8917e
fix: allow sparkle without a macOS version 2022-11-01 20:49:43 +01:00
Sean Molenaar
73d124f342
audit: make min OS check depend on online? 2022-10-31 09:00:43 +01:00
Sean Molenaar
b27aeb8f94
Update Library/Homebrew/cask/audit.rb
Co-authored-by: Bo Anderson <mail@boanderson.me>
2022-10-30 19:41:51 +01:00
Sean Molenaar
012bd1f134
cask: audit for minimal OS version in sparkle feeds 2022-10-30 15:00:56 +01:00
Troy McCabe
d490123d74 Second check for github repos as private homepages 2022-09-20 23:06:47 -05:00
Xuehai Pan
46736c5e81 cask/audit: fix audit error when homepage is missing 2022-09-17 16:42:53 +08:00
Sean Molenaar
ff54095b8a
Cask: automatically add cask audits
This reverts commit 16618374653dc5461dd971e8ed1992188cc3803d.
2022-09-13 11:19:33 +02:00
Mike McQuaid
1661837465
Revert "Cask: automatically add cask audits" 2022-09-06 11:46:40 +01:00
Sean Molenaar
13b060ab86
Merge pull request #13746 from SMillerDev/chore/cask/cleanup_audit
Cask: automatically add cask audits
2022-08-30 09:23:23 +02:00
Sean Molenaar
86f011cefb
Cask: automatically add cask audits 2022-08-29 11:28:20 +02:00
Markus Reiter
999468e41d
Change codesign error message. 2022-08-28 19:24:32 +02:00
Markus Reiter
5c2dd57794
Fix unreachable code. 2022-08-27 04:00:38 +02:00
Markus Reiter
08642f137f
Ignore failed signature check if no signature is present. 2022-08-27 03:51:44 +02:00
Sean Molenaar
b13f6c7c40
Cask: fix signing audit using unexpected pkg method 2022-08-17 15:49:04 +02:00
Sean Molenaar
f7b32abfa3
Cask: fix signing audit checking all artifacts 2022-08-17 09:56:45 +02:00
Sean Molenaar
ca65777e70
cask/audit: improve wording
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2022-08-16 10:01:35 +02:00
Sean Molenaar
e90371f8ab
cask: add audit for incorrect signing 2022-08-11 09:11:29 +02:00
Sam Ford
8bce1e8e37
cask/audit: Skip livecheck audit for :latest casks 2022-06-18 16:44:29 -04:00
Bevan Kay
fa2e4d4401
cask/audit: skip additional livecheck audit when cask is discontinued 2022-06-18 13:16:34 +10:00
Sam Ford
13e3f704c9
Cask::Audit: Account for nil appcast_contents 2022-04-20 23:47:51 -04:00
Nihaal Sangha
1984ca098d
Update cask cookbook header 2021-11-07 01:23:31 +00:00
Sam Ford
77273fe2b3
Cask::Audit: Handle referenced cask in livecheck
`Cask::Audit#check_livecheck_version` was never updated to handle
a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`).
As a result, this audit will wrongly give an error like `Version
'1.2.3' differs from '' retrieved by livecheck.` in this scenario.

This commit ensures that a referenced cask is handled by the audit
and it won't error when the referenced check provides a good version.
2021-11-02 12:32:38 -04:00
Rylan Polster
e24703e58d
Rename :cert_error_allowlist to :secure_connection_audit_skiplist 2021-10-21 21:11:06 -04:00
Rylan Polster
fa4bb7d74a
Refactor audit exception handling 2021-10-21 21:11:05 -04:00
Rylan Polster
d124d8eae8
cask/audit: allow the homepage https audit to have exceptions 2021-10-21 21:01:52 -04:00
Michael Cho
b44ecaceb7
docs: fix cask doc urls to use docs.brew.sh 2021-06-25 13:20:40 -07:00
Sam Ford
e8f803bc75
Cask::Audit: Handle livecheck skip conditions 2021-06-14 14:28:27 -04:00
Kenneth Chew
af594739dc
audit: specify which URL has a content problem in problem message 2021-04-22 13:52:18 +01:00
Markus Reiter
ba87bfc4e4
Only suggest adding livecheck it auto-detection fails. 2021-04-07 19:19:20 +02:00
Markus Reiter
72a79d934e
Fix audit annotations for casks. 2021-04-03 04:27:32 +02:00
Markus Reiter
d2a3944e70
Skip url do URLs in offline audit. 2021-04-02 01:55:35 +02:00
Markus Reiter
3f4706d9e6
Don't suggest adding unnecessary appcast. 2021-03-31 08:13:48 +02:00
Mike McQuaid
9b725a5851
cask/dsl/version: reject invalid characters.
There was a `invalid_characters` method already but it was not being
used.
2021-03-30 14:15:14 +01:00
Rylan Polster
b4a36bef64
audit: fix --display-failures-only failure messaging 2021-03-22 22:20:04 -04:00
Rylan Polster
2b8d19e0bd
audit: limit non-failure cask output 2021-03-22 22:16:54 -04:00
Markus Reiter
3c6a7b39e2
Merge pull request #10894 from reitermarkus/mandatory-livecheck
Make `livecheck` audit mandatory for versioned casks.
2021-03-23 01:34:00 +01:00
Markus Reiter
41fec99591 Make livecheck audit mandatory for versioned casks. 2021-03-23 01:11:35 +01:00
Markus Reiter
b0fd4831d5 New casks should use livecheck. 2021-03-20 22:20:55 +01:00
Markus Reiter
65d1747b29 Check homepage with both browser and default user agent. 2021-03-11 16:19:21 +01:00
Mike McQuaid
9663567501
Fix brew style. 2021-03-01 13:43:47 +00:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions 2021-02-12 18:33:37 +05:30
Mike McQuaid
851bf9aab9
Merge pull request #10465 from vitorgalvao/no-desc-fonts
cask audit: do not require description for fonts
2021-02-02 16:35:26 +00:00
Vítor Galvão
e3d515105b cask audit: do not require description for fonts 2021-02-02 14:06:11 +00:00
Mike McQuaid
861da37f55
Merge pull request #10456 from SeekingMeaning/cask-audit-format-url
cask/audit: underline URLs in audit errors
2021-02-01 09:05:53 +00:00
Seeker
571a13b99e cask/audit: underline URLs in audit errors 2021-01-28 16:17:40 -08:00
Seeker
00e5e1f9fc cask/audit: error if verified does not match, regardless of url 2021-01-28 15:27:00 -08:00
Mike McQuaid
03c861b7d7
Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
EricFromCanada
99ad3350ee use single quotes around stanza and parameter names 2021-01-26 16:19:47 -05:00