mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-15 19:56:59 +08:00
Code Issues Packages Projects Releases Wiki Activity
19,839 Commits 9 Branches 451 Tags
Commit Graph

76 Commits

Author SHA1 Message Date
Mike McQuaid
8ad50cd4dc
utils/github: refactor and update logic. 
- better handle `HOMEBREW_GITHUB_API_USERNAME` and
  `HOMEBREW_GITHUB_API_PASSWORD` from `brew gist-logs`
- only user personal access tokens from the macOS keychain (fixes #6862)
- general refactoring and cleanup around the above
 2020-01-09 16:13:44 +00:00
Maxim Belkin
2735663dc3
GitHub Actions: get username if we don't have it 2019-11-25 16:43:29 -06:00
Maxim Belkin
c7f065b8da
utils/github.rb: use parallel assignments rather than indices 
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
 2019-11-21 11:13:10 -06:00
Maxim Belkin
845f65b945
Factor out some code into functions 2019-11-21 11:13:10 -06:00
Dawid Dziurla
f90612ccf0
bump-formula-pr: make it usable on linux 
This commit makes it possible to use `bump-formula-pr` on linux to
contribute to `homebrew-core` as easily as it is on macOS, but with some
additional steps made before actual bumping of the formula.

Differences in the process (before bumping):
- add `homebrew-core` remote named `homebrew`
- fetch `homebrew/master`
- check if formula exists in `homebrew-core`
- switch to `homebrew/master` ref
 2019-11-15 13:22:31 +01:00
Markus Reiter
f099d44021 Add GitHub::create_check_run function. 2019-10-21 20:12:31 +02:00
Markus Reiter
b1d0c61fea Update Gems. 2019-10-03 09:22:44 +02:00
Markus Reiter
31f15acc01 Add GitHub::check_runs. 2019-09-13 22:30:25 +02:00
Cheng XU
4f29af08f8
github: redact token in the log 2019-07-18 15:10:15 +08:00
Mike McQuaid
2e817d2644
utils/github: better handle blank scopes. 
If both provided and required scopes are blank then we cannot display a
good error message so don't try.

Fixes #6134.
 2019-05-15 09:18:05 +01:00
kiendang
5c83729be9 Fix mutable string syntax 2019-04-26 23:03:40 +08:00
Mike McQuaid
261e2e7926
utils/github: fix frozen string usage. 
See https://discourse.brew.sh/t/error-cant-modify-frozen-string/4691/4
 2019-04-25 23:28:50 -07:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
EricFromCanada
89f0fcedbe whitespace fixes 2019-04-13 21:32:04 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Steven Peters
e91b889e04 utils/github: use tap.full_name 2019-03-03 22:58:31 -08:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Markus Reiter
a4e0413bf9 Let GitHub::open_api return nil when status is 204 No Content. 2019-02-20 02:11:19 +01:00
Markus Reiter
e9c45ff17b Pass additional options to GitHub.pull_requests. 2019-02-16 11:30:49 +01:00
Markus Reiter
68e0c5f904 Check for write access instead of HOMEBREW_DEVELOPER. 2019-02-15 16:27:37 +01:00
Markus Reiter
57fefff942 Add brew cask automerge command. 2019-02-15 16:27:37 +01:00
Mike McQuaid
ec5ce4b180
utils/github: display max 20 closed PRs. 
Closes #5553.
 2019-01-19 17:17:21 +00:00
Mike McQuaid
b167a88e4d
Merge pull request #5090 from JBallin/gist-token-error 
Clarify how to set HOMEBREW_GITHUB_API_TOKEN
 2018-10-21 15:41:34 +01:00
Mike McQuaid
056dd588b2
utils/github: add ValidationFailedError. 
These have specific errors returned so would be more useful to output.
 2018-10-15 12:03:16 -07:00
JBallin
2bf0db40b3 Normalize formatting of gist-logs errors 2018-10-14 20:40:24 -07:00
JBallin
2a1b936f76 Clarify HOMEBREW_GITHUB_API_TOKEN in gist-logs err 2018-10-14 20:40:24 -07:00
Alyssa Ross
864475e14f
bump-formula-pr: use GitHub error message info 
This saves an API call, and is more accurate, because the repo API
doesn't actually say whether forking is enabled, but this error message
does.

To do this, the original GitHub error message had to be accessible on
the GitHub exceptions.
 2018-10-11 16:39:29 +01:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length. 
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
 2018-09-02 16:15:09 +01:00
Gautham Goli
54033d320b utils/github: Raise exceptions if status code != 200 or exit code is not 0 2018-08-15 20:57:22 +05:30
Markus Reiter
8ae284e871 Use SystemCommand for curl. 2018-08-01 01:04:42 +02:00
ilovezfs
cd2b85c40f
Revert "Use SystemCommand for curl." 2018-07-29 21:45:04 -07:00
Markus Reiter
355df64d93 Use SystemCommand for curl. 2018-07-29 01:23:33 +02:00
commitay
7542c4edb7 utils/github: remove full stop from the "skipping" comment 2018-07-25 15:38:14 +10:00
Mike McQuaid
e2968c7889 Various cleanup and fixes. 
Rename some variables and use existing regexes and a single variable.
 2018-05-21 15:36:26 +01:00
Gautham Goli
26e77dd75c new-formula: Don't fail CI instead comment on PR about audit violations 2018-04-30 10:59:20 +05:30
Gautham Goli
1e0f9fb835 bump-formula-pr: Replace hub with GH API calls to fork and open Pull request 2018-03-31 19:44:55 +05:30
Mike McQuaid
83cca40fc9 RuboCop 0.53.0 manual fixes. 2018-03-08 14:10:02 +00:00
Mike McQuaid
1f48e17f1b rubocop: fix brew style warnings. 2018-01-17 10:42:43 +00:00
Thomas Andrew
0e991095f1 Fix issue where keychain github credentials wouldn't work 2017-10-26 18:54:48 +01:00
ilovezfs
1937625d86 github: require formula name to be in issue title 2017-10-24 03:07:33 -07:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Mike McQuaid
cf5fdeef1d Rubocop: manual rule fixes. 2017-09-24 21:23:59 +01:00
Dominyk Tiller
0ea4da4ef6
github: limit PR search to Homebrew 
Not sure whether this is the way you want to handle this problem but
it's really darn irritating so here's a PR that handles it one way.

Fixes: https://github.com/Homebrew/brew/pull/3086#issuecomment-324519156
 2017-08-31 03:59:33 +01:00
Markus Reiter
56ef168e70 Move fix from #3070 inside GitHub module. 2017-08-20 16:31:46 +02:00
Ben Muschol
ca05c7f010 Change var name 2017-08-17 14:38:50 -04:00
Ben Muschol
5f8d212ccc Unify vocabulary in github module, remove unnecessary logic 
Fix duplication bug
 2017-08-14 14:45:24 -04:00
Ben Muschol
68cdb550f7 Spec for issues search 2017-08-14 12:06:12 -04:00
Ben Muschol
603bdd01a8 Implement PR feedback 2017-08-14 11:08:56 -04:00
Ben Muschol
d052f503f9 fix typo 2017-08-13 16:41:18 -04:00