Adrian Ho
cbac7a3063
brew: keep DBus session address in env
...
Otherwise `brew deps --graph` will fail to launch Firefox on Linux.
Fixes https://github.com/Homebrew/brew/issues/12881 .
2022-02-17 14:55:15 +08:00
Xuehai Pan
62a63063bb
Apply suggestions from code review
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Signed-off-by: XuehaiPan <XuehaiPan@pku.edu.cn>
2021-11-24 01:06:27 +08:00
XuehaiPan
9ef52080e3
utils: extract common word "for" in reason
2021-11-23 23:59:09 +08:00
XuehaiPan
466f29a16a
cmd/update-report: redirect stdout to stderr when it is not a TTY
2021-11-23 23:55:06 +08:00
XuehaiPan
c0826f1890
utils: add method ensure_executable!
2021-11-23 23:32:32 +08:00
XuehaiPan
d749173adc
utils: mark reason as keyword argument in ensure_formula_installed!
2021-11-23 23:31:22 +08:00
XuehaiPan
7baaebe544
utils: send output to stderr by default for ensure_formula_installed!
2021-11-23 23:09:42 +08:00
XuehaiPan
3376479e95
utils: add method ensure_formula_installed!
2021-11-23 22:48:39 +08:00
XuehaiPan
687dbe5268
dev-cmd/cat: auto-install bat when running brew cat ... with HOMEBREW_BAT set
2021-11-23 15:20:57 +08:00
fn ⌃ ⌥
84a7c2ba7d
Add VS Code to list of fallback editors
2021-09-30 18:54:51 -07:00
Mike McQuaid
72c59c816f
Merge pull request #11548 from MikeMcQuaid/3_2_deprecate_disable_remove
...
Deprecate, disable, delete code for Homebrew 3.2.0
2021-06-18 14:34:10 +01:00
Misty De Meo
c0a02442d9
Revert "language/java: use shortened brew paths"
...
This reverts commits 318175cfe2b23328f1b5f13812fd59cfd45fe1dc,
e7ab760392b9691a6c730b7e0d660b7874969e70 and
3b35af63f608438b1882756feca94a6ebdd0d6a3 (PR #11537 ).
2021-06-17 20:29:43 -07:00
Mike McQuaid
30a65342e8
Deprecate, disable, delete code for Homebrew 3.2.0
...
Do the usual deprecation, disable, delete dance for Homebrew 3.2.0.
2021-06-17 11:34:32 +01:00
Caleb Xu
318175cfe2
Utils: add shortened_brew_path
2021-06-15 09:58:46 -04:00
Mike McQuaid
c4d69dd2e9
Revert "fix(vendor-gems): redirect bundler stdout to stderr"
2021-06-07 14:51:07 +01:00
Gibson Fahnestock
07d571bebc
fix(vendor-gems): redirect bundler stdout to stderr
...
When running brew commands and interpreting the output, e.g. running
`brew livecheck --json`, it's necessary to stop other programs Homebrew
happens to execute from writing logging output to stdout. Most programs
don't do this, but `bundle install` does seem to.
To reproduce the issue you can run:
```shell
git -C "$(brew --prefix)" clean -ffdx Library/Homebrew/vendor
stdout=$(HOMEBREW_FORCE_VENDOR_RUBY=1 brew livecheck --newer-only --json --cask $(brew --repo homebrew/cask)/Casks/grid.rb)
echo "^^^ was stderr, >>> is stdout: $stdout"
```
If you run it without this change it will print a bunch of output like
this to the stdout before printing out the livecheck JSON output:
```text
Using bundler 1.17.3
Fetching byebug 11.1.3
Fetching coderay 1.1.3
Installing byebug 11.1.3 with native extensions
Installing coderay 1.1.3
Fetching colorize 0.8.1
Installing colorize 0.8.1
[
# Contents of the JSON block.
]
```
With this change the stdout from `bundle install` will be redirected to
brew's stderr, meaning only the JSON goes to stdout, and the rest goes
to stderr.
2021-06-03 11:18:23 +01:00
Mike McQuaid
d73351251c
Deprecate, disable, delete code for next major/minor version.
...
Do the usual dance for bumping our major/minor version.
2021-04-09 09:30:36 +01:00
Markus Reiter
b6ed8915e5
Add compatibility layer for AbstractDownloadStrategy#fetch.
2021-04-03 20:10:33 +02:00
nandahkrishna
3ce8ef3173
utils: raise UsageError in parse_author!
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-04-01 22:22:32 +05:30
nandahkrishna
53a7065bcc
Allow specifying committer for some dev-cmds
2021-04-01 22:22:31 +05:30
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Bo Anderson
0e732d3917
cmd/update-report: report outdated count & suggest brew upgrade
2021-02-10 15:36:38 +00:00
Misty De Meo
c6dc42fd9d
Utils: fix *_stdout_or_stderr helpers
...
Several calls to ohai and puts were directly changed into calls to
these new functions, but they don't share arity or an API.
The base functions allow arbitrary number of arguments, allowing for
multiline printing that covers both a title and a longer message.
2021-02-05 10:13:44 -08:00
Mike McQuaid
72cb6ffd12
utils: import {ohai,puts}_stdout_or_stderr
...
Fixes #10536
2021-02-05 15:03:31 +00:00
Bo Anderson
b670ab1c7b
Deprecate additional arch functions
2021-02-02 16:19:24 +00:00
nandahkrishna
e2ddf9894a
Refactor brew bump
2021-01-24 19:10:46 +05:30
Seeker
b9854bd4cf
rubocops: add unless_multiple_conditions
2021-01-08 10:33:54 -08:00
Seeker
41e0619de8
utils: add git_repository
2021-01-07 11:45:11 -08:00
Markus Reiter
3db55d13d6
Improve handling of SIGINT.
2020-12-18 16:48:49 +01:00
Mike McQuaid
4bb8becf60
odeprecated: handle deprecated and disabled formulae.
...
It's not useful to spend time complaining about or fixing deprecations
or disables in deprecated or disabled formulae given we already complain
on install and don't run them through CI.
2020-12-15 12:04:29 +00:00
Mike McQuaid
9216d8abe6
rubocop-rails: make fixes.
2020-12-02 10:43:04 +00:00
Markus Reiter
fe2c201d00
Merge pull request #9268 from reitermarkus/type-signatures
...
Add more type signatures.
2020-11-30 15:16:05 +01:00
Markus Reiter
6750448d95
Fix some auto-correctable type errors.
2020-11-29 21:23:54 +01:00
Misty De Meo
7f5a94bbcb
Formula cookbook: document with_env
...
The other syntax for setting `ENV` was added in #9013 ,
but this form remained undocumented.
Fixes #8648 .
2020-11-27 09:08:10 -08:00
Markus Reiter
da9289eff0
Add more type signatures.
2020-11-13 12:26:36 +01:00
EricFromCanada
3768b7a6e9
apidoc: update comment wording, punctuation, formatting
2020-11-06 00:21:02 -05:00
EricFromCanada
dddfbf80fc
apidoc: add/update yard tags
2020-11-06 00:16:35 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
nandahkrishna
c1909e80b4
utils/tty: fix TTY handling for stderr
2020-09-17 04:18:13 +05:30
Markus Reiter
0514e2dbba
Move command_help_lines into Help module.
2020-08-24 00:46:33 +02:00
Mike McQuaid
f6e035ec98
Merge pull request #8297 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-0.89.1
...
build(deps): bump rubocop from 0.88.0 to 0.89.1 in /Library/Homebrew
2020-08-19 17:40:32 +01:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks.
2020-08-19 17:12:32 +01:00
Baffour Adu Boampong
ad2809b615
Merge branch 'master' into mlh-outdated-packages
2020-08-10 21:21:09 +00:00
Markus Reiter
490e503b1b
Replace Homebrew.args with Context.
2020-08-06 16:13:14 +02:00
Markus Reiter
75a692d08b
Make ohai, oh1 and odebug use #debug? and verbose? of the current object when possible.
2020-08-06 16:12:52 +02:00
Baffour Adu Boampong
5f19a53195
Refactor bump.rb methods into seperate modules
2020-07-30 22:58:30 +00:00
Baffour Adu Boampong
537a07b42d
Remove duplicate line
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-07-29 13:41:27 +00:00
Baffour Adu Boampong
d7149d1f76
Fix merge conflicts
2020-07-06 03:32:18 +00:00
Baffour Adu Boampong
7a9fbfb6d3
setup and test command
2020-06-30 15:11:11 +00:00
EricFromCanada
e62137133e
docs: fix comment help output
2020-06-25 11:59:42 -04:00
