74 Commits

Author SHA1 Message Date
Jack Nagel
2932bc5347 Remove unused parameter 2014-04-01 16:03:08 -05:00
Jack Nagel
7b6fa8b7bb Inline install_bottle? logic into the installer 2014-03-10 14:56:02 -05:00
Jack Nagel
32ab18c189 Wrap cellar compatibility check in a method 2014-03-10 14:56:02 -05:00
Jack Nagel
4b80d30bab Remove used options check from install_bottle?
This is now handled by requiring that options are always passed to the
installer explicitly.
2014-03-10 14:56:02 -05:00
Jack Nagel
7da459874f Make bottle implementation more generic 2014-03-10 14:56:02 -05:00
Jack Nagel
a911dd5066 Make build_from_source an explicit installer mode 2014-03-10 14:56:02 -05:00
Jack Nagel
44dc21ca5d Prepare bottle tooling for formula revisions 2014-03-05 20:45:44 -06:00
Jack Nagel
7e8c693218 Consolidate bottle defaults and remove a method 2014-03-05 10:24:33 -06:00
Jack Nagel
b45cadd19a bottles: fix options hashes
Defaults can't be specified in the parameter list, as they will be
overwritten by whatever is passed in. Instead the defaults must be
merged with the argument in the method body.
2013-12-08 16:41:35 -06:00
Misty De Meo
492ce9cc5e bottle_filename: remove unused revision default 2013-12-05 23:08:04 -08:00
Misty De Meo
2c175a9d7d Bottles: fix bottle_filename revision
Fixes Homebrew/homebrew#24981.
2013-12-05 23:06:50 -08:00
Misty De Meo
e2af1cbeeb Use BottleCollector in Bottle SoftwareSpec 2013-12-05 18:24:51 -08:00
Misty De Meo
079d0556ad Add BottleCollector
The BottleCollector collects bottle tags and sha1s, and allows tags
to be fetched using more advanced logic than just fetching identical
tags.

Closes Homebrew/homebrew#23434.
2013-12-05 18:24:45 -08:00
Jack Nagel
4d8e023b7f Revert "Disable bottles when HOMEBREW_CELLAR.parent != HOMEBREW_PREFIX"
This reverts commit fdf20dc43971b728520d518f3b6ef0bcb16aeb21.

Closes Homebrew/homebrew#24831.
Closes Homebrew/homebrew#24780.
2013-12-01 17:06:56 -06:00
Jack Nagel
2b8e0c8f79 Disable bottles when HOMEBREW_CELLAR.parent != HOMEBREW_PREFIX 2013-11-30 16:44:14 -06:00
Jack Nagel
5a9356a204 Revert "disable :any bottles due to Homebrew/homebrew#24780"
This reverts commit 31bab6e52b7ed8c63421b9c647d0592af2ee2635.
2013-11-30 16:35:58 -06:00
Adam Vandenberg
9d72738c54 disable :any bottles due to Homebrew/homebrew#24780 2013-11-30 10:47:46 -08:00
Mike McQuaid
b427314c90 bottles: support mavericks.
Closes Homebrew/homebrew#23447.
2013-10-23 00:09:35 +01:00
Misty De Meo
2ac9afcc77 Bottles: add Leopard/PPC tags 2013-10-21 18:06:46 -07:00
Misty De Meo
28c9330abb Update Leopard/Tiger bottle tags
* PPC bottles are in the os_cpu format, e.g. :tiger_g3
* Intel bottles are the bare cat, as usual
* 64-bit bottles have _64 appended to them, e.g. :tiger_g5_64 or :leopard_64
2013-10-21 13:52:49 -07:00
Jack Nagel
805472946b Rename MacOS to OS::Mac 2013-10-18 12:56:51 -05:00
Jack Nagel
1fb9f85c5f Simplify setup for local bottle installation
Closes Homebrew/homebrew#22833.
2013-09-26 10:04:45 -05:00
Mike McQuaid
5d0f868f06 Move bottle.rb logic from test-bot to brew bottle. 2013-09-22 16:16:50 +01:00
Jack Nagel
2eefba005f Give this condition a more revealing name 2013-09-21 19:27:24 -05:00
Mike McQuaid
a7e1dbae63 Bottles: use options hash for install_bottle? 2013-09-18 12:36:43 +01:00
Mike McQuaid
98eac4226b Allow forcing bottle installation. 2013-09-01 12:59:01 +01:00
Mike McQuaid
cfdd23b3ef bottles: use dedicated version class. 2013-08-03 22:27:42 -07:00
Mike McQuaid
4f2725cde3 Move getting formula names from bottles to method. 2013-07-18 09:56:55 -07:00
Mike McQuaid
6c242ad4bb bottles: only try f.bottle.revision if it exists. 2013-07-04 11:32:50 +01:00
Mike McQuaid
49acf70813 bottles: remove legacy tab handling.
References Homebrew/homebrew#20716.
2013-06-27 10:09:37 +01:00
Adam Vandenberg
ad291d7f06 Remove unused guard
Closes Homebrew/homebrew#20716.
2013-06-26 20:32:13 -07:00
Mike McQuaid
bf1db738d7 bottles: add arguments cleanup TODO. 2013-06-22 11:13:59 +01:00
Jack Nagel
e9d245cf3a Avoid unnecessary float to string conversion 2013-06-15 10:13:20 -05:00
Jack Nagel
50db35e5d3 Use Hardware::CPU module 2013-06-14 10:34:17 -05:00
Jack Nagel
79a769215f Decouple bottle tags from MacOS.cat 2013-06-06 16:02:27 -05:00
Jack Nagel
057ed6b4fb bottles: use String#[] instead of "captures.first rescue nil" 2013-06-06 14:11:44 -05:00
Jack Nagel
3c73cc28e0 Optimization: avoid repeated interpolation in regexp
Benchmark.bm do |b|
  b.report("before") do
    100_000.times { /(\.#{MacOS.cat}\.bottle\.(\d+\.)?tar\.gz)$/ }
  end
  b.report("after ") do
    100_000.times { /(\.#{MacOS.cat}\.bottle\.(\d+\.)?tar\.gz)$/o }
  end
end
            user     system      total        real
before 35.400000   0.140000  35.540000 ( 35.619674)
after   0.020000   0.000000   0.020000 (  0.016662)
2013-04-14 18:32:48 -05:00
Mike McQuaid
c7c33c9830 Warn on bottles skipped due to non-default Cellar.
Closes Homebrew/homebrew#18333.
2013-03-09 21:29:53 +00:00
Mike McQuaid
5a2874c652 bottles: remove unused 'version' from DSL. 2013-03-09 21:27:41 +00:00
Mike McQuaid
8f35793020 Support 32-bit 10.6 bottles.
Closes Homebrew/homebrew#17735.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-03-01 17:49:09 +00:00
Mike McQuaid
20c0ddc401 Add non-/usr/local bottles support.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-03-01 17:49:09 +00:00
Mike McQuaid
22aec1d0d9 Add custom bottle URL support.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-03-01 17:49:09 +00:00
Mike McQuaid
360af367a8 Cleanup bottle DSL.
* Remove legacy url syntax.
* Use revision instead of version.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-03-01 17:49:09 +00:00
Mike McQuaid
599b012702 Add pour_bottle? method to Formula.
Allows a formula to selectively disable bottle pouring.
e.g. the default Boost bottle does not work with a brewed Python.

Fixes Homebrew/homebrew#17142
2013-01-29 17:14:11 -08:00
Mike McQuaid
1107171f83 Cleanup old bottle syntax. 2013-01-29 17:14:00 -08:00
Jack Nagel
f3d3bc4368 Move option comparison into BuildOptions 2013-01-26 11:37:00 -06:00
Mike McQuaid
4b0e663c2c Improve bottle error messages.
On installation or creation of a bottle error out of the current
machine does not support bottles.

References Homebrew/homebrew#16291.
2012-12-04 12:06:02 +00:00
Mike McQuaid
549b07e8df Fix bad reference to local_bottle_path.
Fixes Homebrew/homebrew#16337.
2012-12-01 15:38:05 +00:00
Mike McQuaid
c4fb2b73e2 Support installing bottles from local files. 2012-12-01 12:45:23 +00:00
Mike McQuaid
bed2fa088b Don't fail to cleanup redacted formula. 2012-08-25 13:40:05 -07:00