1276 Commits

Author SHA1 Message Date
Adam Vandenberg
d55dc8d01e audit: find env/export as a full word, not as a prefix
Closes Homebrew/homebrew#27219.
2014-03-05 07:53:19 -08:00
Troels Thomsen
fdf5ecf4bb Use name of formula rather than name of dependency
Closes Homebrew/homebrew#27192.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-03-04 16:00:25 -06:00
Jack Nagel
1ab5943fb2 Let commands decide what mode the installer should use 2014-03-04 14:06:25 -06:00
Jack Nagel
4c0db19538 Extract installer setup to prelude method 2014-03-04 14:06:25 -06:00
Mike McQuaid
21e5785652 bottle: fix bottling Git tag case. 2014-03-04 17:34:21 +00:00
Jack Nagel
de254f6cd6 Stop mutating build options in upgrade 2014-03-02 14:02:18 -06:00
Jaime Marquínez Ferrándiz
8a014b3221 audit: Raise a problem if the SourceForge download url uses http instead of https
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-03-02 09:16:53 -08:00
Jack Nagel
c534b1907d Revert "Let commands decide what mode the installer should use"
I'd still like to make this change, but at least for now the initializer
requires ignore_deps to be set correctly.

This reverts commit 881a8855b944fa9bd7dfd598bb9197f79f7a13f0.
2014-03-02 09:01:50 -06:00
Adam Vandenberg
95d7776a90 add check for /Library Python
Closes Homebrew/homebrew#24788.
2014-03-01 23:19:36 -08:00
Jack Nagel
47f22d20af Fix typo 2014-03-02 00:30:09 -06:00
Jack Nagel
ffbe5bf22c Let commands decide what mode the installer should use 2014-03-02 00:21:13 -06:00
Jack Nagel
ea85812c58 Reduce the number of ways options can be passed to the installer 2014-03-02 00:03:08 -06:00
Jack Nagel
7966b29ac6 reinstall: re-raise original exception after cleaning up 2014-03-01 18:27:30 -06:00
Jack Nagel
cf4e7e5954 reinstall: fix incorrect use of Formula.canonical_name
Fixes Homebrew/homebrew#27117.
2014-03-01 18:22:35 -06:00
Mike McQuaid
7f45c63468 fetch: add --retry option to retry fetch once.
Sometimes there may be intermittent failures with hosts that work if
immediately retried. Let's allow a single retry in this case with the
--retry flag. This also behaves nicely with the --force flag.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-03-01 16:45:31 +00:00
Jack Nagel
27de1257e3 audit: don't complain about missing cross-tap dependencies 2014-02-28 23:05:28 -06:00
Jack Nagel
26785dbe5d Use Formula.path 2014-02-28 16:51:15 -06:00
Jack Nagel
d0f43ad367 Remove "brew info <URL>"
Closes Homebrew/homebrew#27076.
2014-02-28 11:07:55 -06:00
Jack Nagel
26c71b19f6 Add audit check for system "xcodebuild" 2014-02-27 21:53:33 -06:00
Jack Nagel
4002abb146 deps: use Dependency objects in recursive_deps_tree 2014-02-27 12:56:59 -06:00
Jack Nagel
87cbe716d9 deps: keep "--all" output sorted 2014-02-27 12:56:42 -06:00
Adam Vandenberg
50b94ada1b add audit for Formula.factory 2014-02-27 08:21:14 -08:00
Mike McQuaid
09330dd83b doctor: tweak XQuartz check.
Sometimes (e.g. Homebrew/homebrew#27014) it may find an installed version but no prefix.

In this case we still want to tell users if it's outdated.
2014-02-26 12:40:25 +00:00
Adam Vandenberg
4a4b960558 fix typo in audit 2014-02-25 20:51:16 -08:00
Adam Vandenberg
758a601555 add audit for scons 2014-02-25 20:29:08 -08:00
Adam Vandenberg
c189dd6e20 only get counts if needed 2014-02-25 20:24:34 -08:00
Jack Nagel
9cd95bc0b7 Remove unused variable 2014-02-23 23:04:44 -05:00
Adam Vandenberg
1f86923ec2 ignore skip_clean :all 2014-02-23 15:53:26 -08:00
Adam Vandenberg
fab5e1d905 add doctor check for HOMEBREW_KEEP_INFO 2014-02-23 08:31:03 -08:00
Adam Vandenberg
bb5a2b587e Always keep info files
Closes Homebrew/homebrew#26659.
2014-02-23 08:30:50 -08:00
Jack Nagel
a836602024 create: make conditional more obvious 2014-02-22 20:17:04 -05:00
Jack Nagel
d1dd4b0e67 create: pull requires out of method 2014-02-22 20:17:04 -05:00
Jack Nagel
101066cf71 Update method call 2014-02-22 20:17:04 -05:00
Mike McQuaid
cf0a3fe93e bottle: detail what a new regex should match. 2014-02-22 17:15:28 +00:00
Jack Nagel
41a9ba8259 Move Formula.class_s to Formulary 2014-02-21 00:46:03 -05:00
Drew Rodman
d63ef14794 Add DownloadError to catch a broader range of resource download errors.
Adding a broader exception class allows for errors raised in Resource.fetch
to be caught in upgrade and prevent the process from being killed when
a download fails. This should resolve issue 18364.

Fixes Homebrew/homebrew#18364.
Closes Homebrew/homebrew#26618.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-02-18 15:08:03 -05:00
Jack Nagel
7bdaa7ffe1 search: use a queue to collect errors
The threading in the tap search code makes handling errors difficult. If
an API-related error is raised in one thread, it is likely to be raised
in each of the rest as well. This results in duplicated error messages,
which is ugly and bad UX.

This patch adds a synchronized queue to collect these exceptions. The
first one added to the queue is re-raised after all operations are
complete.

It's not ideal, but it's minimally invasive and I don't have the energy
or time to do a rewrite.
2014-02-16 23:19:09 -05:00
Mike McQuaid
34930586c3 audit: handle recommended/optional options better. 2014-02-16 22:35:14 +00:00
Mike McQuaid
8157515b2a audit: whitelist pyobject3 use of ARGV. 2014-02-16 22:10:22 +00:00
Mike McQuaid
1fecd418e4 versions: ignore validation errors.
References Homebrew/homebrew#26748.
2014-02-16 18:35:33 +00:00
Mike McQuaid
4bc82456ee bottle: fail if there is no stable version.
Closes Homebrew/homebrew#26742.
2014-02-15 11:28:48 +00:00
Jack Nagel
a7b515e503 Use a more accurate method name and drop unhelpful block 2014-02-13 23:22:43 -05:00
Jack Nagel
345457b33e Pass the string instead of reconstructing it from a regexp 2014-02-12 13:59:18 -05:00
Adam Vandenberg
ae69fa25cc Revert "Recognize --head as an alias for --HEAD"
This reverts commit c32ab0a35a2dfa9b593f759ef0ae8b7af077b0b7.

There are other hard-coded uses of HEAD, in build_options for instance.
These all need to be fixed before enabling this.
2014-02-11 21:25:26 -08:00
Misty De Meo
b1c0380b7b Recognize --head as an alias for --HEAD
Homebrew currently recognizes "--head" during the install process, but
rather than actually fetch HEAD it just nags the user to use the
correct option.	Since we recognize the spelling anyway, this just
promotes the lowercase version to an official alias.

Closes Homebrew/homebrew#26555.
2014-02-09 15:44:49 -08:00
Mike McQuaid
e93792fdef bottle: fix --write messages. 2014-02-09 14:34:50 +00:00
Mike McQuaid
89e07d44f6 bottle: make --write handle both quotes styles. 2014-02-09 14:34:50 +00:00
Jack Nagel
25c4e336f4 Use GitHub wrapper for private tap check 2014-02-08 20:41:11 -05:00
Jack Nagel
d01c671d74 Drop unnecessary map + compact in search_tap 2014-02-08 17:53:08 -05:00
Jack Nagel
7d4709d9d6 Prevent repeated warnings when GitHub API rate limit is exceeded 2014-02-08 16:04:53 -05:00