Change EC2_HOME's value from 'export EC2_HOME="/usr/local/Cellar/ec2-api-tools/1.6.12.0/"'
to 'export EC2_HOME="/usr/local/Cellar/ec2-api-tools/1.6.12.0/libexec"'
Avoide the wrong value of EC_HOME caused by
024208466bfb4ffb479d48709caecc6a1e85ba4d
ClosesHomebrew/homebrew#25918.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
ScriptFileFormula's use is that it installs whatever was downloaded
to bin; if the install is overridden, there's no benefit over deriving
directly from Formula.
The initializer for Formula does a number of validations, but it does
them in a weird order, and some attributes aren't validated under
certain circumstances. This became even more of a mess when most
software package attributes were moved into the SoftwareSpec class.
This commit removes the last vestiges of storing these attributes as
instance variables. In particular, it eliminates #set_instance_variable
and #validate_variable, replacing them with methods that operate on
SoftwareSpec instances, and generate more useful errors.
Doing these validations unconditionally in the initializer means we bail
out much earlier if the formula has invalid attributes or is not fully
specified, and no longer need to validate in #prefix.
Technically we don't need to validate in #brew either, but we continue
to do so anyway as a safety measure, and because we cannot enforce calls
to super in subclasses.
(rather than the version being installed)
This avoids having to change the variable when a different version is linked.
Also ensure the private key / cert variables point to only 1 file.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
