30 Commits

Author SHA1 Message Date
Jack Nagel
42652049b4 Don't attempt to require nil
Fixes Homebrew/homebrew#28942.
2014-05-04 09:15:34 -05:00
Jack Nagel
6577f93f71 Simplify HOMEBREW_LIBRARY_PATH usage 2014-05-02 12:59:38 -05:00
Jack Nagel
2b46af5136 No need to put vendor on the load path 2014-05-02 12:59:38 -05:00
Jack Nagel
f6d81cf762 require accepts Pathnames 2014-05-02 12:59:38 -05:00
Jack Nagel
1ff182ae68 Set ENV variables to strings, not pathnames 2014-05-02 12:59:38 -05:00
Jack Nagel
2d156f06c8 Use File::PATH_SEPARATOR 2014-05-02 12:59:37 -05:00
Jack Nagel
aa5a5a526f Rename Xcode.folder to MacOS.active_developer_dir
This reflects what Apple calls it in more recent versions of Xcode/OS X.
2014-05-01 18:36:46 -05:00
Adam Vandenberg
d4b0599a86 --config -> config 2014-04-30 19:09:29 -07:00
Jack Nagel
20c150fb8c Xcode.bad_xcode_select_path? is used only once, so inline it 2014-04-15 11:28:52 -05:00
Mike McQuaid
3a5c14cea4 brew: allow external cmds to use Homebrew.failed. 2014-04-11 16:02:41 +01:00
Jack Nagel
66c8f2707c Reorganize conditional to avoid shelling out if possible 2014-04-01 18:40:20 -05:00
Mike McQuaid
eabe9dc6d0 brew: check for --help and friends in more of ARGV
Let's check for e.g. --help anywhere in the ARGV array rather than just
the first value to avoid brew upgrade --help causing problems.

Closes Homebrew/homebrew#26675.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-02-14 18:32:56 +00:00
Misty De Meo
5994fd469c xcode-select check: move after first options 2013-12-13 19:17:56 -08:00
Misty De Meo
ea646cd428 Adjust bad xcode-select path exit code 2013-12-13 09:29:35 -08:00
Misty De Meo
775406be91 brew: error out if bad xcode-select path given
Since a bad xcode-select path can cause many brew commands to freeze,
it's worth warning users and bailing out as early as possible.

The doctor check wasn't good enough, since the doctor could freeze
before the warning about this was ever printed.
2013-12-13 08:52:29 -08:00
Jack Nagel
4a5b65c9f5 Remove "-c1" one-line config
This is broken and nobody noticed, so remove it.

Closes Homebrew/homebrew#23878.
2013-11-01 19:04:04 -05:00
Mike McQuaid
d9d2443d5d Cleanup use of some global constants. 2013-10-30 13:20:48 -07:00
Jack Nagel
df824a22a7 Avoid comparing MacOS.version to floats 2013-10-22 20:47:37 -05:00
Jack Nagel
27f7e3503f Move verbose ENV setup out of brew.rb 2013-10-19 10:41:09 -05:00
Xiyue Deng
3b66a7d4fd Improve superenv add/remove message.
* Now it includes all flags that are added or removed by superenv when
  passing "--verbose" or envvar VERBOSE or HOMEBREW_VERBOSE is set.
2013-10-18 13:11:50 -07:00
Jack Nagel
c511d7d2f4 Add OS.mac? and OS.linux? 2013-10-18 12:56:51 -05:00
Adam Vandenberg
9b7786fc04 change wording 2013-09-15 10:28:06 -07:00
Adam Vandenberg
4c9ac19e87 Consolidate sudo checks.
Closes Homebrew/homebrew#20318.
2013-06-08 20:44:56 -07:00
Jack Nagel
da5a4223e8 brew.rb: drop constant reassignment
Closes Homebrew/homebrew#18807.
2013-03-28 18:26:47 -05:00
Misty De Meo
29af53d451 Replace remaining shelled-out whiches 2013-03-21 08:37:51 -05:00
Jack Nagel
7b23870b98 Normalize magic encoding comments 2013-03-02 17:43:58 -06:00
Mike McQuaid
f9f05d1173 brew: use a shell wrapper script for brew
This reverts commit dfd4dd12a41e1697ee9d5feac12cc1ea7c3a590e.

Fixes the problems from Homebrew/homebrew#17683 and Homebrew/homebrew#17685.
2013-02-21 21:42:18 +00:00
Mike McQuaid
191e9ed88a brew: move to Library/brew.rb
This reverts commit ac156b36d00ead5f225389f0a1d8069d0c1cce4a.
2013-02-21 21:42:18 +00:00
Mike McQuaid
1e47298456 Revert "brew: move to Library/brew.rb"
This reverts commit 67d06b84d00a17cf43770eedf34e37e50e209741.

Closes Homebrew/homebrew#17683.
Closes Homebrew/homebrew#17685.
2013-02-08 08:55:53 -08:00
Mike McQuaid
7344149f52 brew: move to Library/brew.rb 2013-02-07 17:48:29 -08:00