5541 Commits

Author SHA1 Message Date
Jack Nagel
72d83adaf3 Adjust link command for updated error handling 2014-04-21 12:43:06 -05:00
Jack Nagel
6b5e92ac47 Raise AlreadyLinkedError when a keg is already linked 2014-04-21 12:43:06 -05:00
Jack Nagel
b2e8c4e79a Only unlink after a LinkError 2014-04-21 12:43:06 -05:00
Jack Nagel
727f204760 Raise useful errors from make_relative_symlink 2014-04-21 12:43:06 -05:00
Jack Nagel
d3ab439b7c Rework make_relative_symlink error handling and move it into keg 2014-04-21 12:43:06 -05:00
Jack Nagel
9d72555644 Print the attempted command when xcrun wrapper fails 2014-04-21 11:05:30 -05:00
Jack Nagel
4b4b6e183e Use File::PATH_SEPARATOR since we use it everywhere else 2014-04-21 11:03:44 -05:00
Jack Nagel
c832bd1591 Fix typo 2014-04-21 10:52:46 -05:00
Jack Nagel
0682c1ad02 Add some comments to the cc wrapper 2014-04-21 10:40:26 -05:00
Jack Nagel
9d15aefd2e Only interpolate constant regexps once 2014-04-21 10:35:05 -05:00
Finn Smith
eed3368039 Fix keg version in Formula#to_hash
Closes Homebrew/homebrew#28550.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-04-21 09:29:53 -05:00
Jack Nagel
23400ec217 Remove code that doesn't do anything 2014-04-21 00:17:34 -05:00
Jack Nagel
85109c95d8 Add newlines between methods 2014-04-21 00:17:34 -05:00
Jack Nagel
815e7f29fc Write the positive case first 2014-04-21 00:17:34 -05:00
Jack Nagel
de9ce56414 Make obvious that what we care about is the presence of sdkroot 2014-04-21 00:17:33 -05:00
Jack Nagel
8b086fe575 Make obvious that this is a nested conditional 2014-04-21 00:17:33 -05:00
Jack Nagel
ed8851dfa1 Filter list before mapping it 2014-04-21 00:17:33 -05:00
Jack Nagel
cb58bd779b Remove last monkeypatch 2014-04-20 22:39:47 -05:00
Jack Nagel
a379fc7f79 Remove nil split monkeypatch 2014-04-20 22:39:47 -05:00
Jack Nagel
bef9ec29ef Remove unused method 2014-04-20 22:39:46 -05:00
Jack Nagel
c351a641de Use original value when building the flag 2014-04-20 20:13:53 -05:00
Jack Nagel
7498cfff99 Remove to_flags monkeypatch 2014-04-20 19:59:25 -05:00
Jack Nagel
d1041319f4 Remove "cleanpath" monkeypatch 2014-04-20 19:57:07 -05:00
Jack Nagel
dfad695748 Use File.expand_path 2014-04-20 18:00:29 -05:00
Jack Nagel
201a1ad9eb Delay loading Pathname until we absolutely need it 2014-04-20 17:00:44 -05:00
Jack Nagel
a00dcd0079 Use a multiline conditional to make this code more readable 2014-04-20 16:52:59 -05:00
Jack Nagel
275e66e08d Stop loading a bunch of monkeypatches every time xcrun is invoked 2014-04-20 16:48:55 -05:00
Jack Nagel
91cc7aca49 Use File.expand_path 2014-04-20 16:33:41 -05:00
Jack Nagel
dd8dc7a380 Remove obsolete DEVELOPER_DIR hacks
These days Homebrew refuses to do anything if the xcode-select path is
busted, so this workaround is unnecessary.
2014-04-20 16:33:41 -05:00
Jack Nagel
749c877f03 Add another comment 2014-04-19 21:47:42 -05:00
Jack Nagel
bac25a77bf Elaborate on why we should remove this code 2014-04-19 21:40:44 -05:00
Adam Vandenberg
174a9a76b4 Move mydumper to the boneyard
This software compiles against now-private APIs:
https://github.com/Homebrew/homebrew/issues/24748
http://bugs.mysql.com/bug.php?id=70672
https://answers.launchpad.net/mydumper/+question/239895

Closes Homebrew/homebrew#24748.
2014-04-19 12:35:35 -07:00
Yann-R
68a8ce7ee7 colormake 0.9
Closes Homebrew/homebrew#27345.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-04-19 11:47:52 -07:00
David Turner
629b244cf8 Handle formula URLs with query parameters. This is useful for fetching formulas from cgit repositories, which uses ?h= to choose branches.
Closes Homebrew/homebrew#28314.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-04-18 08:40:39 -07:00
Mike McQuaid
daa7b7b6db search: move nginx to Homebrew organisation. 2014-04-18 10:59:12 +01:00
Jack Nagel
434854cc69 Don't use assert_nothing_raised 2014-04-15 15:39:26 -05:00
Jack Nagel
46a11a2b26 Remove questionable test
This is already covered in test_mach.rb.
2014-04-15 15:39:10 -05:00
Jack Nagel
8d6c1358a2 Update comment 2014-04-15 14:26:12 -05:00
Jack Nagel
538dea98ad Start cleaning up Xcode.version 2014-04-15 14:20:18 -05:00
Jack Nagel
9d02c39e23 Fix syntax error 2014-04-15 11:37:20 -05:00
Jack Nagel
20c150fb8c Xcode.bad_xcode_select_path? is used only once, so inline it 2014-04-15 11:28:52 -05:00
Jack Nagel
a55e670a8a Remove yet another xcode-select check 2014-04-15 11:28:01 -05:00
Jack Nagel
b78a4b7372 Don't call xcrun twice 2014-04-15 11:26:04 -05:00
Jack Nagel
2f052a2f65 Remove another unnecessary check 2014-04-15 11:26:03 -05:00
Jack Nagel
490cb34885 Remove unnecessary xcode-select check
This is handled here:
67fbb313da/Library/brew.rb (L34-46)
2014-04-15 11:21:27 -05:00
Jack Nagel
fcda7a1086 Document some unanswered questions in the Xcode module 2014-04-15 10:08:59 -05:00
Jack Nagel
2d8d7184f6 Remove dead constant 2014-04-15 09:49:01 -05:00
Mike McQuaid
5883f1675d brew-test-bot: check CompilerSelectionError twice.
It may be that even installing a new compiler doesn't fix things so
detect that case and skip the formula installation rather than erroring
out.
2014-04-15 08:29:30 +01:00
Jack Nagel
47d24c461c Do path and string manipulation in pure bash 2014-04-14 22:36:40 -05:00
Jack Nagel
76b0140af5 Aliases don't have .rb extensions, so no need to remove them 2014-04-14 22:36:40 -05:00