446 Commits

Author SHA1 Message Date
Mike McQuaid
d52e870b07
rubocop: remove NewFormulaAudit.
This is no longer used anywhere.
2020-04-13 16:01:26 +01:00
Mike McQuaid
2200b1ed40
Merge pull request #7231 from hyuraku/audit_github-prerelease_or_not
audit whether GitHub prerelease or not
2020-04-13 09:09:20 +01:00
Jonathan Chang
e6e5571a07 audit: fix keg_only check 2020-04-13 14:19:58 +10:00
Mike McQuaid
afa5713e63
audit: cleanup prerelease detection. 2020-04-12 14:51:49 +01:00
Mike McQuaid
6ea6db9026
dev-cmd/audit: test presence of formulae in lists. 2020-04-12 14:17:06 +01:00
Mike McQuaid
373650d00d
KegOnlyReason: add reason helpers, rename valid. 2020-04-12 13:12:02 +01:00
hyuraku
5578845e3f repair regex condition 2020-04-12 20:23:43 +09:00
hyuraku
399caa007c chnage how to extract owner and tag 2020-04-02 23:44:55 +09:00
hyuraku
40871a9782 repair style 2020-04-02 00:32:09 +09:00
hyuraku
e89be06447 change how to get tag 2020-04-02 00:13:58 +09:00
Mike McQuaid
8975dfb6ff
Merge pull request #7238 from Homebrew/dependabot/bundler/Library/Homebrew/unf_ext-0.0.7.7
build: bump unf_ext from 0.0.7.6 to 0.0.7.7 in /Library/Homebrew
2020-03-29 19:36:51 +01:00
hyuraku
6f622cd525 audit whether GitHub prerelease ot not 2020-03-28 16:57:47 +09:00
Tom Schoonjans
6f7302e4bc keg_only_whitelist: add libsigc++@2 2020-03-27 08:01:01 +00:00
Michka Popoff
cdb9d0fbe4 Revert "Merge pull request #7203 from hyuraku/audit_whether_prerelease-or-not"
This reverts commit 081f6cdcd514396b1d396ce7d0eb40291a1a317c, reversing
changes made to 12d3a2a2d269e0a26565eb3e63552803f826f366.

This fails on some formulae with:
Error: Not Found

See:
https://github.com/Homebrew/homebrew-core/pull/52031
2020-03-22 23:53:59 +01:00
Mike McQuaid
081f6cdcd5
Merge pull request #7203 from hyuraku/audit_whether_prerelease-or-not
audit whether prerelease or not
2020-03-22 17:28:35 +00:00
hyuraku
fa80296ab4 repair notation 2020-03-22 23:25:13 +09:00
hyuraku
a6fcc94249 repair style 2020-03-22 22:18:00 +09:00
hyuraku
f6b260d7c4 audit whether prerelease or not 2020-03-22 22:00:32 +09:00
Sam Ford
e835ccb5cc
audit: throttle awscli@1 instead of awscli 2020-03-15 21:25:21 -04:00
Mike McQuaid
78140cef4a
Merge pull request #7073 from alexreg/issue-7068
audit: ignore group write bit
2020-03-06 14:08:45 +00:00
Alexander Regueiro
68047abc0e audit: ignore group write bit 2020-03-05 23:01:41 +00:00
Mike McQuaid
e3ac94fc5d
dev-cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
Michka Popoff
c46a30b575 brew: remove most traces of python@2 2020-02-17 22:38:24 +01:00
Jonathan Chang
bcb8f4da5f
Merge pull request #6903 from jonchang/audit-core-wording
audit: add "homebrew/core" for relevant checks
2020-01-08 15:53:45 -05:00
Jonathan Chang
779304df68 audit: add "homebrew/core" for relevant checks 2020-01-08 15:38:48 -05:00
Mike McQuaid
4efc1276b3
dev-cmd/audit: make git audit only --new-formula only.
Useful in e.g. https://github.com/Homebrew/homebrew-core/pull/46550 to
avoid repeatedly triggering a failing audit.
2020-01-08 12:12:26 +00:00
Gautham Goli
959b88266d
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args 2020-01-02 13:56:19 +00:00
Gautham Goli
685a6b4da6 ARGV: Replace usages of ARGV.named with Homebrew.args.named 2019-12-18 20:38:21 +05:30
EricFromCanada
f0270a585c desc/audit: remove messages obviated by new arg parser 2019-12-13 15:23:38 -05:00
Mike McQuaid
96e0686d78
Merge pull request #6778 from bayandin/audit-check-resources-uniq-name
dev-cmd/audit: check resource name does not match formula name
2019-11-26 16:25:47 +00:00
Tom Schoonjans
e704bf7184 audit: add libepoxy 1.5.4 to whitelist 2019-11-26 10:26:17 +00:00
Alexander Bayandin
349f37be68 dev-cmd/audit: check resource name does not match formula name 2019-11-26 01:02:27 +00:00
George Waters
8221e32ad4 Fix Audit check for env :std
When performing a strict audit of a formula in the core tap, it was
possible that the check for `env :std` would not happen.
2019-11-13 20:33:43 -05:00
Markus Reiter
6521dbbad7
Merge pull request #6682 from reitermarkus/openjdk
Allow `JAVA_HOME` in formulae depending on `openjdk`.
2019-11-06 23:24:54 +01:00
Jonathan Chang
ae9638a80a audit: better check for forked repo
Co-Authored-By: Steven Peters <scpeters@openrobotics.org>
2019-11-04 13:17:48 +11:00
Markus Reiter
b31c5cb137 Allow JAVA_HOME in formulae depending on openjdk. 2019-11-03 18:25:06 +01:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Issy Long
18e684fad7
Stringify dev-cmd/audit text variables when used in Regexp matching
- To have the audit commands continue to work, and the tests passing
  (the previous error was [1]), everywhere we're trying to
  `.match?(text)`, instead do `.match?(text.to_s)`.

[1] 5) Homebrew::FormulaAuditor#audit_file __END__ but no DATA
    Failure/Error: fa.audit_file

    TypeError:
      no implicit conversion of Homebrew::FormulaText into String
    # ./dev-cmd/audit.rb:267:in `match?'
    # ./dev-cmd/audit.rb:267:in `audit_file'
    # ./test/dev-cmd/audit_spec.rb:137:in `block (3 levels) in <module:Homebrew>'
2019-10-13 16:04:38 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses 2019-10-13 16:04:26 +01:00
Dawid Dziurla
86feb5a9de
audit: replace depends_on with uses_from_macos 2019-10-10 17:59:32 +02:00
Tom Schoonjans
9fc495125d audit: add gcab 1.3 to whitelist 2019-10-08 10:00:28 +01:00
Markus Reiter
e719744248 Refactor brew style. 2019-10-05 00:20:06 +02:00
Markus Reiter
b1d0c61fea Update Gems. 2019-10-03 09:22:44 +02:00
Sean Molenaar
8cb833f7da
Audit bitbucket.com repositories 2019-09-05 20:56:25 +02:00
Sean Molenaar
0cca6cb8bd
Audit gitlab.com repositories 2019-09-05 12:14:33 +02:00
Mike McQuaid
4add1d1cb3
Check binary URL resources with RuboCop
- Migrate the existing binary URL audit to a RuboCop.
- Check resources as well as main URLs
- Also check for "macos" and "osx" in URLs
- Add whitelists for URLs and formulae
2019-09-02 10:50:49 +01:00
Mike McQuaid
9291fe583e
audit: fix --display-cop-names. 2019-09-02 10:48:19 +01:00
EricFromCanada
8a8359cdd4 manpages: sentence rewording for readability
Use active voice when applicable, better verbs & adjectives, preposition usage, proper tense, etc.
2019-08-20 09:05:45 -04:00
EricFromCanada
ee314617f7 manpages: update command usage strings 2019-08-20 08:55:54 -04:00