142 Commits

Author SHA1 Message Date
Mike McQuaid
4f3c590873
Unify and use Git username/email/GPG handling.
We're using essentially the same logic to setup Git for committing in
multiple places but the way we're doing so is inconsistent. Moved to
using two shared utility methods and use them consistently.
2020-11-02 12:21:18 +00:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Dustin Rodrigues
f41dd1834f bottle: new formula license may be a list, not just a string 2020-09-23 21:08:44 -04:00
Mike McQuaid
fb4d08a49a Fix brew style 2020-09-11 10:29:22 +01:00
Dustin Rodrigues
8ab5ea5249 bottle: use File.lutime instead of system call 2020-09-06 19:43:30 -04:00
Mike McQuaid
8b97c27c21 brew style manual fixes 2020-09-01 14:26:45 +01:00
Mike McQuaid
dbe427073d
Merge pull request #8399 from MLH-Fellowship/migrate-to-args-named
args: Migrate usage of args loading methods to args.named
2020-08-25 10:07:27 +01:00
William Ma
fa7bd3bff6 args: Migrate usage of args loading methods to args.named 2020-08-23 09:02:20 -04:00
Markus Reiter
3118fedab9 Refactor and document Git. 2020-08-23 06:40:07 +02:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
Rylan Polster
0ff2f88f39 bottle: fix args 2020-08-01 14:56:11 -04:00
Markus Reiter
9c65a73893 Pass args correctly in brew bottle. 2020-07-31 18:58:07 +02:00
Markus Reiter
d4c2ffd705 Refactor CLI::Parser. 2020-07-31 15:07:17 +02:00
Dawid Dziurla
a8e524d334
bottle: fix inreplace string 2020-07-27 17:23:08 +02:00
vidusheeamoli
fd382d2ecd srb: set utils/inreplace.rb to true and refactor
- Sorbet gives preference to class methods over methods defined in
  included modules, hence Sorbet was unavailable to resolve the
definition of the gsub! method.
- The gsub! method in StringInreplaceExtension conflicts with the definition in String.
- This PR refactors the call to the gsub! method so that a custom object
  is exposed instead of a string.
2020-07-26 12:43:31 +05:30
Shaun Jackman
e2db288340 bottle --merge: Fix bug with cellar :any
When merging cellar, :any ought to have higher priority than
:any_skip_relocation.
The variables first and second are strings, not tags.
2020-07-10 09:46:05 -07:00
Bo Anderson
0e3f22e1df dev-cmd/bottle: fix positioning of bottle block in some cases 2020-07-01 23:51:23 +01:00
Mike McQuaid
aa81982aba
brew style --fix 2020-06-02 09:49:23 +01:00
Mike McQuaid
29fd98960c
Revert "bottle: author bottle commit as BrewTestBot" 2020-04-01 16:20:35 +01:00
Dawid Dziurla
96cd210f8f
bottle: author bottle commit as BrewTestBot 2020-03-31 16:26:10 +02:00
Mike McQuaid
1e265247ca
rubocop: apply autofixes. 2020-03-13 21:16:18 +00:00
Mike McQuaid
e3ac94fc5d
dev-cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
Mike McQuaid
f31e01c3ad
test: set Git name and email.
Extract the code from `bottle.rb` into `utils/git.rb` and ensure it's
run before we run tests.

Should resolve issues like in
https://github.com/Homebrew/homebrew-core/pull/50328
2020-02-17 19:40:44 +00:00
Dawid Dziurla
c80107c8a2
bottle: prioritize HOMEBREW_CELLAR over :any over :any_skip_relocation 2020-02-10 21:39:36 +01:00
Shaun Jackman
7f4c7e0afc bottle: Elide root_url only if it is the default
Elide root_url only if it is precisely equal to the default root_url.
Eliding root_url when a prefix matches the default also elides
a custom root_url such as https://linuxbrew.bintray.com/bottles-bio.
2020-01-26 22:04:41 -08:00
Mike McQuaid
ea1a3ea6e0
dev-cmd/bottle: run sudo --purge non-interactively.
This should avoid hanging if permissions are not granted.
2020-01-15 10:48:13 +00:00
Mike McQuaid
36dac3d41f
dev-cmd/bottle: add HOMEBREW_BOTTLE_SUDO_PURGE.
Add environment variable to optionally run `sudo purge` a few times to
potentially work around #6539.
2020-01-14 15:09:13 +00:00
Gautham Goli
959b88266d
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args 2020-01-02 13:56:19 +00:00
Gautham Goli
685a6b4da6 ARGV: Replace usages of ARGV.named with Homebrew.args.named 2019-12-18 20:38:21 +05:30
EricFromCanada
90e830c19e cmd: add raises for invalid input 2019-12-15 00:04:45 -05:00
EricFromCanada
2f7c3afeb8 cmd: improve wording of messages, spacing 2019-12-15 00:04:45 -05:00
Mike McQuaid
6decac5875
Merge pull request #6803 from MikeMcQuaid/latest_version_installed
Rename Formula#installed? to Formula#latest_version_installed?
2019-12-03 12:09:01 +00:00
Mike McQuaid
5dd8ead51a
Rename Formula#installed? to Formula#latest_version_installed?
This naming has always been a bit weird and confusing so let's change
it and provide a `compat` fallback for later deprecation.
2019-12-03 11:42:42 +00:00
EricFromCanada
b817796562 Grammar fixes for status messages 2019-12-02 11:38:06 -05:00
Mike McQuaid
176297d361
Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles
2019-11-06 15:25:40 +00:00
Mike McQuaid
ddcbdbe0c0
formula: cache runtime_dependencies related stuff. 2019-11-06 10:04:13 +00:00
Mike McQuaid
eeb9ac36a2
keg: cache runtime_dependencies. 2019-11-06 10:04:13 +00:00
Jonathan Chang
81db0e9551 dev-cmd: enable frozen string literals
Now that we use Ruby 2.6 we can fix these last two files.
2019-11-04 21:00:20 +11:00
Mike McQuaid
333642927b
Merge pull request #6607 from dawidd6/keep-old-but-not-cellar
bottle: don't keep old cellar
2019-10-21 13:37:17 +01:00
Dawid Dziurla
aa9950282f
bottle: set bottle.cellar to old_spec.cellar if deleting mismatch
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2019-10-21 14:11:08 +02:00
Dawid Dziurla
e19fab86c0
bottle: allow prefix cellar to be any* 2019-10-21 13:37:55 +02:00
Cheng XU
94cf0d922e
bottle: do not install patchelf if --skip-relocation flag is passed 2019-10-16 14:29:53 +08:00
Markus Reiter
b1d0c61fea Update Gems. 2019-10-03 09:22:44 +02:00
Dawid Dziurla
8ff7601a92
define default prefix constants
also use them to detect if prefix line in bottle block is needed
2019-09-30 16:46:53 +02:00
EricFromCanada
8a8359cdd4 manpages: sentence rewording for readability
Use active voice when applicable, better verbs & adjectives, preposition usage, proper tense, etc.
2019-08-20 09:05:45 -04:00
EricFromCanada
b4303cd983 manpages: fix command & option descriptions 2019-08-20 09:03:33 -04:00
Cheng Xu
6437a70a5f
Revert "Elide default root_url in the bottle block"
This reverts commit e4f4e0f98b6ff9c0f9f988345c2257fbc151e8b0.

This is no longer necessary as `HOMEBREW_FORCE_HOMEBREW_ON_LINUX`
is set when uploading bottles for Homebrew.
2019-05-20 15:09:31 +08:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
fc6bd2ea1c
Fixup more frozen string handling. 2019-04-20 14:07:29 +09:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00