699 Commits

Author SHA1 Message Date
Mike McQuaid
2ca3f73078
dev-cmd/audit: remove unused warnings key.
These are now all errors so the code can be simplified.
2023-04-19 16:09:45 +01:00
Mike McQuaid
0b4c0350c2
Merge pull request #15201 from hyuraku/remove_cask/cmd/audit
remove `cask/cmd/audit`
2023-04-19 10:01:06 +01:00
hyuraku
54ce31e0fe remove auditing = true 2023-04-15 10:05:58 +09:00
hyuraku
98ec60c15e remove nil param 2023-04-13 19:02:20 +09:00
Markus Reiter
66d80cb114
Allow running audit for different architecture. 2023-04-12 21:46:48 +02:00
hyuraku
b8f18309c3 repair variable 2023-04-12 22:23:08 +09:00
hyuraku
acca57a2d8 repair cask_results query 2023-04-12 21:59:28 +09:00
hyuraku
f7b51d8cd1 pass opitions as named parameters 2023-04-12 20:16:10 +09:00
hyuraku
4999639140 - remove cask/cmd/audit
- repair cmd/audit
2023-04-11 23:06:01 +09:00
Issy Long
41466025cc
dev-cmd/style: Properly clean up the --display-cop-names option
- I remember making these changes as part of the RuboCop bump
  Dependabot PR (15136), but I must have not actually pushed them. Odd.
2023-04-11 00:19:09 +01:00
Issy Long
8319c8f9b9
Make audit_casks return [path, { errors:, warnings:}] for CI
- This was failing but only in CI because the annotations require
  "errors" and "warnings" hash elements. Since formulae have this
  despite formulae not having warnings (probably for compatibility with
  casks), I decided to reinstate `errors` and `warnings` hash for Casks
  _right at the end_ and we can clean this up another time (famous last
  words).
2023-04-07 14:31:12 +01:00
Issy Long
d636d2de37
Apply suggestions from review comments
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
  from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Issy Long
53a17b921f
Make --display-failures-only help hidden as it's deprecated
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-04-04 17:17:19 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only the default for Casks
- Cask warnings are really noisy and numerous. Let's only show them if
  the user passes `--strict` or something implying `--strict`, like
  `--new-cask`.
- Additionally remove `display_passes` since we would like silence if
  nothing is wrong with the cask, the same as with formula audits.
2023-04-01 01:56:45 +01:00
Markus Reiter
bdd6523ce8
Deprecate appcast. 2023-03-30 03:29:06 +02:00
Dustin Rodrigues
b776fb32de
change includecount to include_count for readability 2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize 2023-03-19 23:35:47 -04:00
Douglas Eichelberger
f4c9a96c70 Enable types in dev-cmd 2023-03-14 08:32:03 -07:00
Douglas Eichelberger
f9f73f3ef6 Tidy up 2023-02-27 21:42:47 -08:00
Douglas Eichelberger
1ab278f74c Fix style/type violations 2023-02-27 20:34:07 -08:00
Douglas Eichelberger
0eccc0e987 git grep -l Utils::Inflection | xargs gsed -i 's|Utils::Inflection|Utils|g' 2023-02-27 20:18:27 -08:00
Douglas Eichelberger
3da68651e5 Port more call sites 2023-02-27 20:18:08 -08:00
Bo Anderson
e86a8c2477
Move HOMEBREW_NO_INSTALL_FROM_API defaults to shell 2023-02-24 21:53:08 +00:00
Bo Anderson
559bec95bc
Scope HOMEBREW_NO_INSTALL_FROM_API to core formulae in brew audit 2023-02-24 13:33:46 +00:00
EricFromCanada
dfc9906184
internal messaging fixes 2023-02-10 23:17:16 -05:00
Mike McQuaid
cb1872e5bf
Merge pull request #14553 from MikeMcQuaid/4.0.0-changes 2023-02-08 11:05:08 +00:00
Mike McQuaid
342d40e88d
Merge pull request #14510 from reitermarkus/audit-only-except
Pass `only` and `except` to cask audits.
2023-02-08 09:05:00 +01:00
Markus Reiter
b821a00bc5
Pass only and except to cask audits. 2023-02-08 08:38:32 +01:00
Mike McQuaid
6b4363092d
Revert "Merge pull request #14548 from Homebrew/revert-14382-deprecate-disable-remove"
This reverts commit 932d2cf3b77c9439a57b6a43577fc8d3b6399a62, reversing
changes made to f4e60482791d2ff628efadfdbf0d14d9237d2d29.
2023-02-07 19:25:51 +01:00
Mike McQuaid
6882ac17e7
Revert "Add deprecations and disables" 2023-02-07 15:13:19 +01:00
Mike McQuaid
59c03cb2a6
Add deprecations and disables
Do the usual dance:
- commented `odeprecated` to `odeprecated`
- `odeprecated` to `odisabled`
- `odisabled` removed
2023-02-03 10:48:43 +00:00
apainintheneck
2cbe89102e Comment out path args deprecation 2022-12-27 14:09:31 -08:00
apainintheneck
c2e8bf3e83 Deprecate path args to audit cmd
`brew audit` doesn't work as expected when users
pass in formula/cask paths so we are deprecating it.
2022-12-22 10:00:42 -08:00
Mike McQuaid
77c0d38c35
brew style --fix 2022-12-13 11:37:06 +00:00
Bevan Kay
74092bc40d
Update Library/Homebrew/dev-cmd/audit.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2022-12-06 20:50:00 +11:00
Bevan Kay
839746cf99
dev-cmd/audit: enable --[no]-signing flag for audits 2022-12-06 11:00:59 +11:00
Bo Anderson
eac32f0b20
Additional fixes for Ruby 3 compatibility 2022-10-18 01:54:59 +01:00
Sean Molenaar
dd46cc40c7
audit: improve error wording 2022-09-26 15:37:12 +02:00
Sean Molenaar
95777e7cdf Audit: complain if no targets are found 2022-09-26 10:49:12 +02:00
Mike McQuaid
e2759fbdff
Deprecate reading all formulae through commands
We added the `--all` flag (now renamed to `--eval-all`) for various
commands for this behaviour so let's start deprecating this.

Also, introduce a `HOMEBREW_EVAL_ALL` environment variable to use the
existing, less secure, behaviour by default and avoid passing
`--eval-all` everywhere.
2022-09-05 13:57:22 +01:00
Mike McQuaid
22d6af1258
Manual brew style fixes. 2022-06-30 08:56:21 +01:00
Mike McQuaid
2d5eab2e1c
brew style --fix 2022-06-30 08:56:21 +01:00
Bo Anderson
f5dc7a571f
Fix Style/ObjectThen offences 2022-06-17 19:47:55 +01:00
Bo Anderson
0c0cdf8105
dev-cmd/audit: fix error with --installed 2022-04-08 19:10:20 +01:00
Mike McQuaid
79891a7103
Update uses of Formula.all/Cask::Cask.all
Add some `--all` flags we'll eventually migrate to to ensure that we'll
eventually require their usage to read all formulae. Where we need to
do stuff later, add some comments.
2022-03-08 19:24:56 +00:00
Mike McQuaid
3a709d36b2
Start process to remove Enumerable from Formula and Cask::Cask.
This is the first step to address
https://github.com/Homebrew/brew/issues/11292.
2022-01-03 14:59:10 +00:00
Rylan Polster
2e6b6ab3a2
Fix style 2021-12-24 21:15:21 -05:00
Rylan Polster
e09139fb47
Clarify comment 2021-11-06 00:59:46 -04:00
Rylan Polster
46f7c8b0b6
Move handling to dev-cmd/audit.rb 2021-11-06 00:51:20 -04:00
Rylan Polster
fa4bb7d74a
Refactor audit exception handling 2021-10-21 21:11:05 -04:00