Issy Long
0041ea21f5
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
hyuraku
38e0aa8800
change condition
2020-05-19 23:58:33 +09:00
hyuraku
c263c755aa
check tap_path size
2020-05-19 22:22:31 +09:00
hyuraku
7ac337181a
use helper methods
2020-05-18 20:41:55 +09:00
hyuraku
a0d069b309
brew doctor shows deleted formulae
2020-05-17 17:23:23 +09:00
Dawid Dziurla
80e118cba3
diagnostic: whitelist /bin and /sbin for *-config files
2020-04-20 16:18:56 +01:00
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig.
2020-04-07 09:58:26 +01:00
Mike McQuaid
7df1dd7797
diagnostic: complain on deprecated/disabled formulae.
2020-04-01 13:43:15 +01:00
Mike McQuaid
4e5b9f57ca
diagnostic: check homebrew-core git status.
...
Also look in Homebrew/homebrew-core for uncommitted files (in some ways
we care about uncommitted stuff there more than Homebrew/brew). Also,
list all the modified files even when on non-CI to make it easier for
users to figure out their own issues and check the contents of the
whole repos rather than just a subdirectory.
In general this is a cleanup that should have been done long ago (when
we split Homebrew/brew and Homebrew/homebrew-core).
2020-03-11 17:25:07 +00:00
Xiao Di Guan
a9b22165fd
doctor: remove DYLD checks
2020-01-26 14:38:32 +11:00
Mike McQuaid
70e0b500e9
diagnostic: fix suggested origin URL.
...
Fixes #6909 .
2020-01-09 14:14:44 +00:00
Mike McQuaid
355626ac51
Tweak/fix Git remote configuration behaviour.
2019-12-30 10:38:47 +00:00
hyuraku
f7adc88241
fix style
2019-12-19 00:09:59 +09:00
hyuraku
7501f3d402
check before examine_git_origin
2019-12-19 00:05:20 +09:00
hyuraku
e6e0d1128c
create new envoronments
2019-12-03 00:45:11 +09:00
Mike McQuaid
1e3ddcade1
diagnostic: tweak modified detection.
2019-10-18 09:22:34 +01:00
EricFromCanada
6bc1785c88
doctor: list any uncommitted modified files
2019-10-16 17:43:51 -04:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere
...
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
...
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
Layout/InconsistentIndentation once the auto-fixer had got rid of the
"redundant begin"s.
2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses
2019-10-13 16:04:26 +01:00
Simon Olofsson
d372031fdc
Fix diagnostic when only keep_file is in sbin.
...
Brew creates the keep_file itself and then complains about files in sbin.
2019-10-09 19:33:11 +01:00
EricFromCanada
6520785307
manpages: grammar fixes
2019-08-20 08:26:26 -04:00
Mike McQuaid
fc6bd2ea1c
Fixup more frozen string handling.
2019-04-20 14:07:29 +09:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
...
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
EricFromCanada
fa6404e0f5
grammar fixes
2019-04-13 21:29:32 -04:00
Mike McQuaid
983e542b9a
diagnostic: flag unreadable rather than unavailable formulae.
...
Fixes #5980 .
2019-04-03 19:02:04 +01:00
Mike McQuaid
baecc4fdee
diagnostic: report unreadable, installed formulae.
...
We previously did this somewhat unintentionally. `brew readall` does
this for all formulae but takes way longer.
2019-04-02 19:06:05 +01:00
Daniel Blankenberg
d717358a32
In diagnostics, when directory is not writable, also hint to the user to set permissions.
2019-03-22 22:45:41 -04:00
Mike McQuaid
b23f990175
Rubocop autofixes
2019-03-18 14:30:44 +00:00
Jonathan Chang
aff5759920
diagnostic: check cask git origin
2019-02-22 13:10:55 +11:00
Jonathan Chang
f274fa44d8
diagnostic: refactor git origin checks
2019-02-22 13:10:50 +11:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier.
2019-02-21 12:55:49 +00:00
Yuta HIGUCHI
64f977158d
Print full tap path for all deprecated taps
...
Print full tap path for all deprecated taps found so that it can be copy-pasted as `brew untap` argument
2019-02-21 00:06:57 +09:00
Mike McQuaid
67cbb129ff
diagnostic: warn people about tapped, deprecated taps.
2019-02-16 20:07:10 +00:00
Mike McQuaid
1aa8ad09e2
Deprecate macOS versions below Mavericks
...
And remove all dead/unneeded code.
2019-01-27 12:27:47 +00:00
Mike McQuaid
9b5ab7fbb7
Merge pull request #5598 from MikeMcQuaid/odeprecated-odisabled
...
Update deprecations and cleanup
2019-01-27 12:13:26 +00:00
Michka Popoff
b24e96e28d
diagnostic: ignore case in origin comparison
...
On circle-ci we do:
git remote set-url origin $CIRCLE_REPOSITORY_URL
which is defined as: https://github.com/linuxbrew/homebrew-core
This is being compared to:
https://github.com/Linuxbrew/homebrew-core
2019-01-26 16:10:06 +01:00
Shaun Jackman
d13a287954
Fix check_coretap_git_origin
...
check_coretap_git_origin was not working as intended.
Permit Linuxbrew/homebrew-core as a valid origin.
Factor out check_coretap_git_branch.
2019-01-25 14:01:10 -08:00
Mike McQuaid
eed1444d61
Update deprecations and cleanup
...
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
2019-01-23 21:57:40 +00:00
Mike McQuaid
589ed8e17c
Tweak diagnostic checks
...
- Make `gist-logs` perform more checks
- Don't complain about a non-/usr/local install at install time unless
actually building from source.
- Show more checks output on a build error
- Improve naming of checks methods
2019-01-21 19:23:31 +00:00
Mike McQuaid
3a0e0dca36
Output more warnings on unsupported configurations
2019-01-21 13:58:03 +00:00
Mike McQuaid
699d543ecd
Use Homebrew.default_prefix? in more places.
2019-01-21 12:37:42 +00:00
Mike McQuaid
e10d61b81b
Merge pull request #5447 from jonchang/linux-doctor
...
doctor: check supported versions of glibc and kernel [Linux]
2019-01-02 19:11:05 +00:00
Mike McQuaid
8cfcc7fcf0
cleanup: run and replace brew prune.
...
It's always seemed a bit pointless to me that we have both of these
commands. Given we're doing more and more to recommend (and eventually,
safely, automatically run (see #4760 ) `brew cleanup` let's roll their
functionality into a single command.
2019-01-02 13:21:34 +00:00
Jonathan Chang
9db92a0203
Revert "Revert "diagnostic: share prefix check""
2019-01-01 18:11:59 -08:00
Jonathan Chang
c32283e5be
diagnostic: use universal pull request message
2019-01-01 15:48:00 -08:00
Jonathan Chang
0a5fed1938
Revert "diagnostic: share prefix check"
2018-12-29 14:31:39 -08:00
Jonathan Chang
0d0eac8078
diagnostic: share prefix check
2018-12-27 11:23:18 -08:00
EricFromCanada
0362e66a26
doctor: use minimum Git version set in brew.sh
2018-10-28 20:13:19 -04:00
