Gautham Goli
fba52e2f74
cli_parser: Store parsed args in Homebrew.args and access args everywhere else
2018-05-30 00:05:39 +05:30
Tom Schoonjans
ecbd9b9a26
Add gtk-mac-integration to gnome_devel_whitelist
2018-05-29 10:38:38 +01:00
commitay
dc96e6f735
Merge pull request #4170 from commitay/new-formulae-options
...
audit: new formulae should not have options
2018-05-24 07:16:11 +10:00
commitay
c297d39420
audit: add back new formulae condition for patches
2018-05-23 07:36:59 +10:00
Mike McQuaid
c7aa286336
audit: tweak line length/style.
2018-05-22 14:52:02 +01:00
Gautham Goli
38c832b029
audit: exit with code 1 if regular audit errors or new formula audit errors when comment is not created
2018-05-22 19:14:18 +05:30
Gautham Goli
b01446d059
audit: Add condition check on new_formula_audits
2018-05-22 17:55:40 +05:30
commitay
9d55fed15f
audit: new formulae should not have options
2018-05-22 19:39:14 +10:00
Mike McQuaid
8401cffe41
audit: remove "new formula" from messaging.
2018-05-22 09:55:41 +01:00
Mike McQuaid
1c91c83eac
Merge branch 'master' into bot-comment
2018-05-21 17:16:19 +01:00
Mike McQuaid
e2968c7889
Various cleanup and fixes.
...
Rename some variables and use existing regexes and a single variable.
2018-05-21 15:36:26 +01:00
Mike McQuaid
840c97c1cc
formula: add versioned formulae method.
2018-05-12 15:02:29 -04:00
Gautham Goli
26e77dd75c
new-formula: Don't fail CI instead comment on PR about audit violations
2018-04-30 10:59:20 +05:30
Markus Reiter
33a9521576
Fix MissingFormula namespacing.
2018-04-22 17:27:44 +02:00
Markus Reiter
16fb563d49
Refactor MissingFormula spec.
2018-04-20 19:11:22 +02:00
commitay
909312f9a4
audit: new formulae should not have a HEAD spec
2018-04-14 19:24:07 +10:00
Mike McQuaid
b584e24ad1
Merge pull request #4033 from MikeMcQuaid/audit-depend-if-build-with
...
audit (strict): check for build.with? dependencies.
2018-04-08 22:54:07 +01:00
Mike McQuaid
544dc1b0d0
audit: check for build.with? dependencies.
...
These don't behave as expected; depending on when and where in Homebrew
(or even an installation process) these are evaluated they return
different results. This means that sometimes these will be seen as
dependencies and sometimes they will be ignored entirely by the DSL.
Instead `:optional` or `:recommended` dependencies should be used. We
don't have a solution yet for grouping dependencies together but this is
another case for removing more optional dependencies altogether (as
there are no designs or proposed implementations).
2018-04-07 20:41:25 +01:00
Mike McQuaid
9fca172d03
Fix HOMEBREW_RUBY_WARNINGS="-w"
...
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Gautham Goli
8ef1fb30a0
Add :quiet, :verbose, :debug common switches to be specified
2018-03-29 03:20:14 +05:30
Mike McQuaid
f37b0bc987
Merge pull request #3980 from GauthamGoli/arg-parser-refactor
...
cli_parser: Add class method to make options declaration more readable
2018-03-25 13:57:59 +01:00
Gautham Goli
ed387572ec
cli_parser: Add class method to make options declaration more readable
2018-03-25 18:02:29 +05:30
Tom Schoonjans
2019c289cb
Add libepoxy to gnome_devel_whitelist
2018-03-25 11:35:16 +01:00
Mike McQuaid
8040c82e9e
Merge pull request #3610 from GauthamGoli/arg-parser
...
cli : Add basic arg parser and use it for parsing `brew audit` args
2018-03-21 08:56:38 +00:00
Mike McQuaid
d2c23bde6d
Audit use of :run dependencies.
...
These are a no-op so let's remove them.
2018-03-19 10:11:08 +00:00
Mike McQuaid
cb6828dbe6
Merge pull request #3925 from maxim-belkin/git_remote_exists_bool
...
append ? to git_remote_exists
2018-03-15 08:20:14 +00:00
Maxim Belkin
c99cfd1591
add ? to svn_remote_exist
2018-03-14 16:55:45 -05:00
Maxim Belkin
f984701c29
append ? to git_remote_exist
2018-03-14 16:30:45 -05:00
Gautham Goli
5743f22209
cli : Implement Parser and use it for parsing audit command args
2018-03-09 02:44:50 +05:30
William Woodruff
b4443e1cc0
Merge branch 'audit-deny-binary-looking-urls'
2018-02-07 11:20:19 -05:00
William Woodruff
3f43f60a2a
audit: Warn on new formulae containing binary URLs
2018-02-06 08:44:56 -05:00
Mike McQuaid
3ac2f81f3c
Merge pull request #3757 from EricFromCanada/master
...
docs: add more option descriptions
2018-02-05 10:31:57 +01:00
William Woodruff
7fffccba05
audit: Remove FILEUTILS_METHODS constant
...
This constant hasn't been used since there was an `audit_line`
method, and as such is vestigial.
2018-02-04 22:44:46 -05:00
EricFromCanada
1d2b4ed321
docs: add more missing option descriptions
...
and improve wording or formatting where necessary.
2018-02-01 16:06:17 -05:00
Mike McQuaid
50a84f2535
audit: allow env :std in custom taps.
...
This is a nicer experience than writing `Requirement`s by hand.
2018-01-09 15:26:54 +00:00
commitay
8a419b4742
audit: pass explicit sort to handle APFS
2018-01-07 13:36:16 +10:00
Mike McQuaid
d54e670a64
requirements: move more to compat.
2017-12-30 20:56:55 +00:00
Mike McQuaid
7f54c83911
audit: remove unneeded mercurial check.
2017-12-29 19:53:04 +00:00
Martin Schimandl
0db069602e
Refactor: Move FormulaAudit.check_http_content to utils/curl
2017-12-03 14:02:55 +01:00
Gautham Goli
7b2fab8ec5
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 13:53:44 +05:30
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Gautham Goli
7fa51f71f1
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-13 19:50:46 +05:30
Dominyk Tiller
0865ab0d1b
audit: nudge to use predicate for 'executable?' as well
2017-10-10 15:45:41 +01:00
Dominyk Tiller
a0f4861934
audit: broaden refute_predicate nudge
2017-10-09 16:46:01 +01:00
Mike McQuaid
56458f03fc
Merge pull request #3277 from sjackman/audit-notable
...
audit: Silence not notable on non-Homebrew taps
2017-10-08 13:41:15 -07:00
Shaun Jackman
53dd0e3f28
audit: Silence not notable on non-Homebrew taps
...
Silence "GitHub repository not notable" on non-Homebrew taps.
2017-10-08 10:35:53 -07:00
Markus Reiter
175ca909ee
Clean up code style and remove .rubocop_todo.yml.
2017-10-08 16:10:37 +02:00
Dominyk Tiller
2a25825a12
audit: tweak assert/refute_predicate audit
...
Addresses some of the issues I raised in https://github.com/Homebrew/homebrew-core/pull/19127#issue-263566817 .
Would still like to work out a way to check `File.exist?`-style language
inside the `test do` block exclusively but for now it's better to be
too conservative on the audit than to be overly-zealous and flag too
much.
2017-10-08 06:54:49 +01:00
Dominyk Tiller
4e957165d1
audit: prefer assert/refute_predicate over File.exist?
2017-10-05 02:52:21 +01:00
Mike McQuaid
134bd00d10
audit: don't care about shadowing official taps.
...
We're trying to import all of these formulae anyway.
2017-09-29 16:23:02 +01:00
