98 Commits

Author SHA1 Message Date
Markus Reiter
d443afc82d Improve brew man output. 2020-09-27 22:54:57 +02:00
Markus Reiter
f54b458cda Allow installing casks with brew install. 2020-09-27 22:53:32 +02:00
Markus Reiter
37ecdb28f7 Add spec for NamedArgs#to_paths. 2020-09-09 22:15:10 +02:00
Markus Reiter
2a63ba4060 Support passing casks in brew style. 2020-09-09 22:15:10 +02:00
Misty De Meo
c06848c487
Fix printing MultipleVersionsInstalledError details
The refactor in 6e8f5d0958247e4b4d629866099ed2836a0e0863 means that the
exception no longer exposes the name of the package with multiple versions,
and as a result the rescuer is unable to print this information.

Because we now have a path in which MultipleVersionsInstalledError doesn't
have the name at all, we can't reasonably restore the old behaviour.
And since rack resolution happens purely internal to the function that
raises the exception, the caller has no way to know what name to use.
However, since the exception text gets printed anyway, we can just move
this text into the exception itself.

Fixes the following error:

```
Error: mpd has multiple installed versions
Error: undefined method `name' for #<MultipleVersionsInstalledError:0x00007fc6009d8870>
/usr/local/Homebrew/Library/Homebrew/cmd/uninstall.rb:137:in `rescue in uninstall'
/usr/local/Homebrew/Library/Homebrew/cmd/uninstall.rb:135:in `uninstall'
/usr/local/Homebrew/Library/Homebrew/brew.rb:119:in `<main>'
```
2020-09-09 11:56:53 -07:00
Mike McQuaid
2e5272d04c Deprecate/disable code for Homebrew 2.5.0.
Do the usual "disable deprecations" and "uncomment pending deprecations"
dance and delete/deprecate/disable relevant/related code.
2020-09-03 10:34:22 +01:00
Seeker
5acdcd26d0 formula: rename installed_prefix to latest_installed_prefix 2020-09-01 09:32:32 -07:00
Mike McQuaid
344d8432d2 cli/named_args: handle missing cask tap.
Casks (and indeed formulae) don't always have taps.

Fixes #8535
2020-09-01 08:50:56 +01:00
Claudia
7d09ddc3b5
Print meaningful message on missing formula
Add an import statement needed for `MissingFormula` to be found.

Fixes #8538.

Reported-by: Nate Whetsell <nathan.whetsell@gmail.com>
2020-08-30 17:43:54 +02:00
Markus Reiter
46a93ee7bb Don't output warning to stdout. 2020-08-29 20:24:08 +02:00
Mike McQuaid
3866c0b047
Merge pull request #8483 from whoiswillma/print-correct-cask-ref
cli/named_args: Print correct cask ref when name is loaded as formula/keg
2020-08-27 08:39:14 +01:00
Markus Reiter
ceeb6e6492 Document NamedArgs. 2020-08-26 03:13:58 +02:00
William Ma
d32be75ec0 named args: Print correct cask ref when name is resolved as formula/keg 2020-08-25 11:57:01 -04:00
William Ma
b4ee7a691c args: Comment out deprecations 2020-08-23 09:02:25 -04:00
William Ma
fa7bd3bff6 args: Migrate usage of args loading methods to args.named 2020-08-23 09:02:20 -04:00
Bo Anderson
e3372e2a14 Lazily require some heavy files 2020-08-20 02:05:17 +01:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
William Ma
a7b063efb5 named_args: Warn when cask with same name exists 2020-08-17 13:06:47 -04:00
Mike McQuaid
c565a2130e
Merge pull request #8332 from MLH-Fellowship/named-args
args: Move named args parsing to separate class
2020-08-17 15:15:26 +01:00
Markus Reiter
4c833b241d Fix parsing of negative options. 2020-08-14 20:03:15 +02:00
William Ma
13bc69385c args: Move named args parsing to separate class 2020-08-14 13:49:03 -04:00
Markus Reiter
b48bc316e0 Use CLI::Parser for cask commands. 2020-08-13 05:15:15 +02:00
Markus Reiter
490e503b1b Replace Homebrew.args with Context. 2020-08-06 16:13:14 +02:00
Markus Reiter
9d6350037f Use try instead of send. 2020-08-06 16:13:14 +02:00
William Ma
cf961caa27 caskroom: Add --caskroom command 2020-08-03 12:35:03 -04:00
Bo Anderson
5e98d4df08 cli/parser: restore env setting for global options 2020-08-01 17:36:16 +01:00
Markus Reiter
0de9eb0382 Rename split_double_dash to split_non_options. 2020-07-31 17:46:54 +02:00
Markus Reiter
be2d19fe07 Refactor handling of formula options in CLI::Parser. 2020-07-31 17:46:54 +02:00
Markus Reiter
4381c32524 Add test for parsing with ignore_invalid_options. 2020-07-31 15:07:17 +02:00
Markus Reiter
d4c2ffd705 Refactor CLI::Parser. 2020-07-31 15:07:17 +02:00
Markus Reiter
8d97029b03
Merge pull request #8084 from reitermarkus/cli-parser
Refactor usage of global `Homebrew.args`.
2020-07-30 11:44:12 +02:00
Mike McQuaid
4888a677c7
Merge pull request #8126 from MLH-Fellowship/integrate-deps
deps: Print cask dependencies
2020-07-30 10:20:30 +01:00
Markus Reiter
05365b5542 Pass args more explicitly in FormulaInstaller. 2020-07-30 03:21:12 +02:00
Markus Reiter
c470a6ff43 Pass args directly to prevent_build_flags. 2020-07-30 03:21:12 +02:00
Markus Reiter
db467497ca Fix indentation. 2020-07-30 03:21:12 +02:00
Markus Reiter
24eff8f81a Pass args in SoftwareSpec instead of using global args. 2020-07-30 03:21:12 +02:00
William Ma
cc63cece76 deps: print cask dependencies
* Allow references to commands when using `brew deps`, e.g. `brew deps
cellery`
* Fix crash when using `brew deps <formula> --installed
--include-requirements`
* Do not include runtime dependencies as direct dependencies when using
`--tree`
2020-07-28 20:24:19 -04:00
Markus Reiter
c0d42dd922 Remove --force from global_options. 2020-07-28 10:31:11 +02:00
Markus Reiter
bf13db3367 Make Parser#parse return args. 2020-07-25 02:37:10 +02:00
Jonathan Chang
76709d82c5 Fix brew style. 2020-07-13 23:24:14 +10:00
William Ma
df8d22a29b Remove debugging markers (oops) 2020-07-03 18:27:19 -04:00
William Ma
6e8f5d0958 Modify MultipleVersionsInstalledError to have a generic message 2020-07-03 18:25:49 -04:00
William Ma
525d1ac27d Fix PR issues 2020-07-03 10:33:38 -04:00
William Ma
dff61c9eab style: Fix style issues 2020-06-30 12:21:21 -04:00
William Ma
8a05b5258a args: Refactor to load casks directly 2020-06-30 12:08:03 -04:00
William Ma
5900263cab args: Add resolved_formulae_and_unknowns 2020-06-24 14:53:03 -04:00
William Ma
cbfea6c125 args: Add field for kegs and unknowns 2020-06-24 11:59:07 -04:00
Mike McQuaid
ef95b59ed4
Remove HomebrewArgvExtension
Fixes #5730
2020-05-23 19:39:11 +01:00
Mike McQuaid
e1f3c8d2b3
Merge pull request #7579 from MikeMcQuaid/deprecations
Update deprecations
2020-05-23 14:38:10 +01:00
Bo Anderson
a2939be08a formula_installer: don't propagate --include-test unless requested 2020-05-19 19:12:47 +01:00