Jonathan Chang
08059680f0
diagnostic: fix xattr check
...
Python emits the version on either stderr or stdout based on major
version, so just to be safe let's use popen_read and combine the
output streams.
2020-09-21 01:15:31 +10:00
Mike McQuaid
3923d331de
Fix brew style
2020-09-15 13:39:06 +01:00
Mike McQuaid
f161e56ce0
ENV: check SDK exists when setting up.
...
Reuse code from `brew doctor` that checks and produces a fatal error
and from `install.rb` that runs it.
Closes #8646
2020-09-11 12:05:22 +01:00
Mike McQuaid
8b97c27c21
brew style manual fixes
2020-09-01 14:26:45 +01:00
Markus Reiter
e024b12d47
Remove os/linux/diagnostic.
2020-08-24 00:22:17 +02:00
Markus Reiter
3118fedab9
Refactor and document Git.
2020-08-23 06:40:07 +02:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks.
2020-08-19 17:12:32 +01:00
Markus Reiter
d50dc2e1bb
Refactor and document Homebrew::Diagnostic.
2020-08-14 18:46:43 +02:00
rmnull
043719383b
remove code using patchelf, remove HOMEBREW_PATCHELF_RB var
2020-08-08 06:48:31 +05:30
Mike McQuaid
a1dc809f5b
bin/brew: don't filter GitHub Actions variables.
2020-08-07 10:19:00 +01:00
Mike McQuaid
e4eff8ebb6
Merge pull request #7974 from MLH-Fellowship/integrate-doctor
...
doctor: Run cask doctor checks in brew doctor
2020-07-22 13:27:53 +01:00
William Ma
f4bc2db736
doctor: Disable cask staging path check when running CI, fix style
2020-07-20 08:31:26 -04:00
Adrian Ho
567b5a96d6
check_user_path_1: Fix message presentation
2020-07-14 18:57:45 +08:00
William Ma
447ea12d38
doctor: Move cask doctor checks to brew diagnostics
2020-07-10 10:36:59 -04:00
Mike McQuaid
fa760a2f26
Fix brew style.
2020-07-07 13:12:37 +01:00
Mike McQuaid
f951ea83d4
Fix brew style.
2020-07-07 12:23:29 +01:00
Mike McQuaid
300d7e4799
diagnostic: allow some uncommitted gems.
...
Until these feature flags are fully enabled/removed these will result
in uncommitted gems (which will block CI).
2020-07-07 09:51:22 +01:00
Issy Long
0041ea21f5
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
hyuraku
38e0aa8800
change condition
2020-05-19 23:58:33 +09:00
hyuraku
c263c755aa
check tap_path size
2020-05-19 22:22:31 +09:00
hyuraku
7ac337181a
use helper methods
2020-05-18 20:41:55 +09:00
hyuraku
a0d069b309
brew doctor shows deleted formulae
2020-05-17 17:23:23 +09:00
Dawid Dziurla
80e118cba3
diagnostic: whitelist /bin and /sbin for *-config files
2020-04-20 16:18:56 +01:00
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig.
2020-04-07 09:58:26 +01:00
Mike McQuaid
7df1dd7797
diagnostic: complain on deprecated/disabled formulae.
2020-04-01 13:43:15 +01:00
Mike McQuaid
4e5b9f57ca
diagnostic: check homebrew-core git status.
...
Also look in Homebrew/homebrew-core for uncommitted files (in some ways
we care about uncommitted stuff there more than Homebrew/brew). Also,
list all the modified files even when on non-CI to make it easier for
users to figure out their own issues and check the contents of the
whole repos rather than just a subdirectory.
In general this is a cleanup that should have been done long ago (when
we split Homebrew/brew and Homebrew/homebrew-core).
2020-03-11 17:25:07 +00:00
Xiao Di Guan
a9b22165fd
doctor: remove DYLD checks
2020-01-26 14:38:32 +11:00
Mike McQuaid
70e0b500e9
diagnostic: fix suggested origin URL.
...
Fixes #6909 .
2020-01-09 14:14:44 +00:00
Mike McQuaid
355626ac51
Tweak/fix Git remote configuration behaviour.
2019-12-30 10:38:47 +00:00
hyuraku
f7adc88241
fix style
2019-12-19 00:09:59 +09:00
hyuraku
7501f3d402
check before examine_git_origin
2019-12-19 00:05:20 +09:00
hyuraku
e6e0d1128c
create new envoronments
2019-12-03 00:45:11 +09:00
Mike McQuaid
1e3ddcade1
diagnostic: tweak modified detection.
2019-10-18 09:22:34 +01:00
EricFromCanada
6bc1785c88
doctor: list any uncommitted modified files
2019-10-16 17:43:51 -04:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere
...
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
...
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
Layout/InconsistentIndentation once the auto-fixer had got rid of the
"redundant begin"s.
2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses
2019-10-13 16:04:26 +01:00
Simon Olofsson
d372031fdc
Fix diagnostic when only keep_file is in sbin.
...
Brew creates the keep_file itself and then complains about files in sbin.
2019-10-09 19:33:11 +01:00
EricFromCanada
6520785307
manpages: grammar fixes
2019-08-20 08:26:26 -04:00
Mike McQuaid
fc6bd2ea1c
Fixup more frozen string handling.
2019-04-20 14:07:29 +09:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
...
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
EricFromCanada
fa6404e0f5
grammar fixes
2019-04-13 21:29:32 -04:00
Mike McQuaid
983e542b9a
diagnostic: flag unreadable rather than unavailable formulae.
...
Fixes #5980 .
2019-04-03 19:02:04 +01:00
Mike McQuaid
baecc4fdee
diagnostic: report unreadable, installed formulae.
...
We previously did this somewhat unintentionally. `brew readall` does
this for all formulae but takes way longer.
2019-04-02 19:06:05 +01:00
Daniel Blankenberg
d717358a32
In diagnostics, when directory is not writable, also hint to the user to set permissions.
2019-03-22 22:45:41 -04:00
Mike McQuaid
b23f990175
Rubocop autofixes
2019-03-18 14:30:44 +00:00
Jonathan Chang
aff5759920
diagnostic: check cask git origin
2019-02-22 13:10:55 +11:00
Jonathan Chang
f274fa44d8
diagnostic: refactor git origin checks
2019-02-22 13:10:50 +11:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier.
2019-02-21 12:55:49 +00:00
