32 Commits

Author SHA1 Message Date
Mike McQuaid
0222a83406
test: fix brew style. 2020-09-23 09:01:55 +01:00
Michka Popoff
9da32e3d93 test: make pgrep call portable
Fixes (on linux), for example for the ninja formula test:

```
pgrep
-P
83252
{out: :close}}
Invalid preceding regular expressionpgrep: write error: Bad file descriptor
Error: ninja: failed
An exception occurred within a child process:
  BuildError: Failed executing: pgrep -P 83252 {out: :close}
```

Using File:NULL is more portable.
2020-09-22 23:35:10 +02:00
Mike McQuaid
541fecea22
test: check for pgrep/pkill for developers/CI.
If people are running `brew test` but don't have `pgrep` or `pkill`
installed the forked processes may never be killed. This is not a big
deal on a user's machine but on CI may make a job block and never
complete/timeout successfully.
2020-09-17 13:05:01 +01:00
William Ma
fa7bd3bff6 args: Migrate usage of args loading methods to args.named 2020-08-23 09:02:20 -04:00
Markus Reiter
490e503b1b Replace Homebrew.args with Context. 2020-08-06 16:13:14 +02:00
Markus Reiter
bace9ecc34 Pass verbose? to Formula#verify_download_integrity. 2020-08-06 16:13:14 +02:00
Markus Reiter
5caafe413e Pass debug? to Formula#brew and Formula#run_test. 2020-08-06 16:12:52 +02:00
Bo Anderson
7f46d4ec3c build, test: set Homebrew.args 2020-08-01 18:27:15 +01:00
Bo Anderson
20c6a3f325 build, test: fix debrew not working 2020-08-01 18:26:56 +01:00
Markus Reiter
276c570c16 Pass individual args explicitly to ENV extensions. 2020-07-28 02:52:45 +02:00
Markus Reiter
25b3632c4c Pass args to ENV instead of using global args. 2020-07-25 03:57:43 +02:00
Markus Reiter
6b0b25cd00 Pass keep_tmp? and interactive? instead of using global args. 2020-07-25 02:37:10 +02:00
Bo Anderson
41a666febb ENV/std: port superenv SDK changes 2020-04-23 18:11:10 +01:00
Mike McQuaid
7da922cd5c
test: ensure pkill is run even without exception.
This should make it easier to cleanup after test failures or successes.

It may also allow simplification of `test do` blocks if they can assume
that all subprocesses will be killed.
2020-04-15 19:47:05 +01:00
Alexander Bayandin
bfcba0f5f0 Library/Homebrew: add free_port test helper
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-03-31 00:00:11 +01:00
Mike McQuaid
a15ce054c8
test: revert renaming test_args method. 2020-01-13 14:56:59 +00:00
Gautham Goli
eadf17881d
Homebrew/test.rb: Reuse test_args method 2020-01-13 14:51:50 +00:00
Mike McQuaid
2bb0ad6560
test: parse arguments. 2020-01-02 13:56:19 +00:00
Gautham Goli
959b88266d
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args 2020-01-02 13:56:19 +00:00
Shaun Jackman
4ab7eb93d7 test: Avoid pgrep -q, not available with GNU pgrep 2019-05-05 21:00:27 -07:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
4b369962d3
test: kill all subprocesses on timeout.
Fixes #5885.
2019-04-19 14:42:26 +09:00
William Woodruff
367629d289
utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-04 11:03:32 -04:00
Mike McQuaid
7df5b7057e
Revert "Use JSON to marshal errors from children" 2018-08-18 08:20:13 +01:00
William Woodruff
5c90833f0a
Use JSON to marshal errors from children 2018-08-17 15:23:08 -04:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
ilovezfs
197392b56d Revert "Fix operator spacing." 2017-06-01 04:06:40 -07:00
Markus Reiter
d34ba7395b Fix operator spacing. 2017-05-31 19:53:41 +02:00
Uladzislau Shablinski
092d4712a1 Update commit when resolving the formula (#536) 2016-07-17 16:56:13 +08:00
BrewTestBot
13d544e11e Core files style updates.
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Xu Cheng
b621edf89d sandbox test 2015-04-15 19:51:54 +08:00