Mike McQuaid
ea33958e03
Merge pull request #3031 from JCount/audit-fix-tap-versioned-aliases
...
audit: fix mismatch in versioned alias names in non-core taps
2017-08-09 20:46:13 +01:00
Bob W. Hogg
0ae22c0e36
dev-cmd/bump-formula-pr: search for tar
...
We first search for gtar in PATH, then
check if Homebrew's gtar is available,
then finally search for tar in PATH.
Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-08-08 23:07:27 -07:00
JCount
e1ebaab0cb
audit: fix mismatch in versioned alias names in non-core taps
...
Fixes #3022
2017-08-08 16:56:19 -04:00
Markus Reiter
ae4bafdb36
Simplify CurlDownloadStrategy.
2017-08-08 18:10:13 +02:00
ilovezfs
986887b413
Revert "Refactor SVN and cURL download strategies."
2017-08-07 14:31:56 -07:00
Markus Reiter
dc5a2c1764
Simplify CurlDownloadStrategy.
2017-08-07 21:31:17 +02:00
Mike McQuaid
12c454822a
sandbox: stop printing message.
...
We’re always using the sandbox where possible now so this is just
noise for the vast majority of our users.
2017-08-07 11:16:36 +01:00
Gautham Goli
43cec10000
audit: Port patches audit code to a rubocop
2017-08-05 21:51:24 +05:30
Mike McQuaid
f4983ab16b
Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
...
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Mike McQuaid
43d68b6dda
Merge pull request #2980 from GauthamGoli/audit_style_check_bug_fix
...
audit: fix bug where `brew audit foo` runs every style check.
2017-08-01 11:36:18 +01:00
Mike McQuaid
c3c3575b70
Merge pull request #2964 from GauthamGoli/audit_line_rubocop_part_1
...
audit: Port dependency rules from line_problems to rubocop and add tests
2017-08-01 11:29:26 +01:00
Gautham Goli
5e8e705b50
audit: fix bug where brew audit foo
runs every style check.
2017-07-30 22:03:43 +05:30
Gautham Goli
c575f34d5f
audit: Port audit_urls strict rules to rubocop, add tests and autocorrect
2017-07-30 12:59:37 +05:30
Gautham Goli
e1cb0b43d7
audit: Port dependency rules from line_problems to rubocop and add tests
2017-07-29 16:36:32 +05:30
Gautham Goli
0c04b9041a
audit: Check for style violations when --new-formula
is passed
2017-07-28 05:05:34 +05:30
Mike McQuaid
baa61f5a6e
Use https for all docs.brew.sh links.
...
May as well use the more secure link when possible.
2017-07-27 15:59:37 +01:00
Gautham Goli
2639b6c556
audit: Update Urls Cop with more rules of audit_urls and corresponding tests
2017-07-25 19:06:36 +05:30
Gautham Goli
b7ddd271e1
audit: Port audit_urls partially to rubocop and add corresponding tests
2017-07-21 20:50:28 +05:30
Mike McQuaid
ce1b26d58d
Merge pull request #2905 from GauthamGoli/audit_option_rubocop_3
...
audit: Port audit_options rules for new formulae to rubocop and add test
2017-07-15 13:40:45 +01:00
Mike McQuaid
f5cc8daa39
Merge pull request #2900 from MikeMcQuaid/improve-docs
...
Documentation improvements
2017-07-15 13:39:32 +01:00
Gautham Goli
a8f1b02be9
audit: Port audit_options rules for new formulae to rubocop and add test
2017-07-15 17:35:10 +05:30
Mike McQuaid
4fd8aea015
Documentation improvements
...
- Document ilovezfs as the official lead maintainer of
Homebrew/homebrew-core. This is a role he's been doing unofficially
(and brilliantly) for a while and explicit documentation of power
structures makes it easier for non-Homebrew-maintainers to understand.
- Document the contents of some of Homebrew's subdirectories for people
clicking around in the GitHub UI looking to contribute.
- Remove update bug mention from README. Enough time has passed that we
can remove this disappointment.
2017-07-15 12:57:34 +01:00
Gautham Goli
f3923f23ef
audit: Port audit_options strict rules to rubocop and add tests
2017-07-14 21:43:16 +05:30
Mike McQuaid
20db5470e3
Merge pull request #2879 from GauthamGoli/audit_option_rubocop_1
...
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-14 15:32:52 +01:00
Mike McQuaid
ec574c0e7f
tests: unpin bundler.
...
These issues were fixed by https://github.com/Homebrew/brew/pull/2872
and https://github.com/Homebrew/brew/pull/2823 .
2017-07-13 17:15:03 +01:00
Gautham Goli
b8adc1a8aa
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-13 12:41:43 +05:30
Mike McQuaid
f1fa475c4f
Merge pull request #2843 from GauthamGoli/audit_conflicts_rubocop
...
audit: Port audit_conflicts method to rubocop and add tests
2017-07-08 07:44:16 +01:00
Gautham Goli
4ed34f91c2
audit: Port audit_conflicts method to rubocop and add tests
2017-07-07 20:46:57 +05:30
Mike McQuaid
ddb1fd7981
Merge pull request #2841 from mistydemeo/formula_assertions_constant
...
Define a custom assertion failure error for cross-version compat
2017-07-07 10:14:21 +01:00
Mike McQuaid
5c2fa1fc1f
test: use Test::Unit class.
2017-07-07 09:44:02 +01:00
Mike McQuaid
bddafe4d54
audit: don't suggest non-stable versioned alias.
...
Additionally handle the case where a formula has been installed as
devel/HEAD rather than just e.g. `brew audit --devel`.
2017-07-07 09:30:18 +01:00
Mike McQuaid
2b3717a5a0
Merge pull request #2842 from GauthamGoli/audit_only_cops_option
...
audit: Don't run audit methods when `--only-cops` option is passed
2017-07-02 14:45:29 +01:00
ilovezfs
a94a938285
Merge pull request #2829 from mislav/bump-formula-pr-unshallow
...
Fix `bump-formula-pr` when working with a shallow git clone
2017-07-01 09:15:07 -07:00
Gautham Goli
8c167b23cc
audit: Don't run audit methods when --only-cops
is passed
2017-06-30 20:25:12 +05:30
Misty De Meo
5b464babf8
Define a custom assertion failure error for cross-version compat
...
Fixes #2840 .
2017-06-29 17:40:04 -07:00
Mislav Marohnić
f8ec2332a2
Strip trailing newline
2017-06-29 13:28:55 +02:00
Misty De Meo
87fa20076c
audit: ask for full_index patches
2017-06-28 20:49:37 -07:00
Mislav Marohnić
3701b11e42
Fix unshallowing taps in bump-formula-pr
...
Never try to unhshallow full clones.
2017-06-27 23:45:57 +02:00
Mislav Marohnić
b3ef9ccb8a
Fix bump-formula-pr
when working with a shallow git clone
...
Creating a fork and pushing to it doesn't work when the repository in
question is a shallow clone. By default, Homebrew clones all taps in
shallow mode unless `--full` was passed or $HOMEBREW_DEVELOPER was set.
2017-06-27 14:32:09 +02:00
Mike McQuaid
3ce667f3b9
Merge pull request #2823 from MikeMcQuaid/test-simplify-minitest
...
test: simplify minitest inclusion.
2017-06-25 13:30:47 +01:00
Mike McQuaid
c45cca8e36
test: simplify minitest inclusion.
...
The previous version seems needlessly complicated given we only support
a single Ruby version. It was also blowing up on Bundler 1.15.X.
2017-06-25 13:04:36 +01:00
Mike McQuaid
f4cdd7a051
Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop
...
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-25 08:54:59 +01:00
Mike McQuaid
5f8a86c178
Merge pull request #2816 from MikeMcQuaid/test-needs-link
...
test: require non-keg-only formulae to be linked.
2017-06-24 13:30:21 +01:00
Gautham Goli
2e82754776
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-24 17:06:26 +05:30
Mike McQuaid
b9e3daac70
audit: don't use Fossies as a primary URL.
...
As requested in:
https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234
2017-06-23 19:34:25 +01:00
Mike McQuaid
7d5cce569d
test: require non-keg-only formulae to be linked.
...
This can be overridden with `--force`.
As mentioned in:
https://github.com/Homebrew/homebrew-core/pull/14525#issuecomment-307838164
2017-06-23 17:42:09 +01:00
Gautham Goli
4d7a983415
audit: Port audit_checksum method to rubocop and add tests
2017-06-16 19:45:16 +05:30
Mike McQuaid
ed9942fbd1
Merge pull request #2769 from MikeMcQuaid/rubocop-no-perl-backrefs
...
rubocop: don’t allow Perl regex backrefs.
2017-06-12 16:47:28 +01:00
Mike McQuaid
22c431d221
Merge pull request #2767 from MikeMcQuaid/rubocop-no-special-global-vars
...
rubocop: don’t allow special global variables.
2017-06-12 16:16:37 +01:00
Mike McQuaid
021cef4b2b
Autocorrect Rubocop Style/SpecialGlobalVars.
2017-06-12 09:11:42 +01:00