This will allow `brew style` and `brew audit` to be run separately
without providing duplicates.
Additionally, run RuboCop style rules when `--strict` isn't provided and
remove a confusing reference to `style`.
- Muscle memory is a thing, as is relying heavily on one's shell
history. Now that the Jenkins runners are gone, `brew pull --bottle`
no longer works. This removes the option. If maintainers are confused,
they should [look at recent changes to the
docs](https://docs.brew.sh/Brew-Test-Bot-For-Core-Contributors#bottling),
or ask in Slack.
- An earlier iteration of this showed a deprecation warning and a link
to the docs, but when an option no longer physically works it's a bit
late for deprecation *warnings*.
- This also fixes a `brew style` warning from futher up in the file.
pull: Appease RuboCop
If `HOMEBREW_GITHUB_API_TOKEN` is not set and `GITHUB_TOKEN` is: let's
use it. `GITHUB_TOKEN` is a somewhat standard env var to set for
GitHub authentication tokens (e.g. used by `hub`).
- Without this, `brew man` produces a lowercasing diff that violates
Vale's rules.
- Also run `brew man` to test this out, and that updated some dates to
December.
This variable allows a user to configure how often `brew update` runs.
With the previous implementation, however, it was still pretty slow as
it would run some of `brew update` even within the timeout. This feels
related to complaints about Homebrew "feeling slow" since we enabled
this. Address this by:
- making `HOMEBREW_AUTO_UPDATE_SECS` behave more like
`HOMEBREW_NO_AUTO_UPDATE` and entirely skip the invocation of
`brew update` if the relevant tap (homebrew-core or homebrew-cask
depending on command invoked) has been checked in the last
`HOMEBREW_AUTO_UPDATE_SECS`
- Only require/check the update of a single tap rather than every tap
- Increase the default value of `HOMEBREW_AUTO_UPDATE_SECS` from 1m
to 5m to cut people a bit more slack. We're not updating things
often enough for 1m not to feel a bit overkill and 5m feels
appropriate for a Homebrew "session" to only require a single update.