mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
109 lines
2.7 KiB
Ruby
109 lines
2.7 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "formula_installer"
|
|
require "development_tools"
|
|
require "messages"
|
|
|
|
module Homebrew
|
|
module_function
|
|
|
|
def reinstall_formula(
|
|
formula,
|
|
flags:,
|
|
installed_on_request: false,
|
|
force_bottle: false,
|
|
build_from_source_formulae: [],
|
|
interactive: false,
|
|
keep_tmp: false,
|
|
debug_symbols: false,
|
|
force: false,
|
|
debug: false,
|
|
quiet: false,
|
|
verbose: false,
|
|
git: false
|
|
)
|
|
if formula.opt_prefix.directory?
|
|
keg = Keg.new(formula.opt_prefix.resolved_path)
|
|
tab = keg.tab
|
|
keg_had_linked_opt = true
|
|
keg_was_linked = keg.linked?
|
|
backup keg
|
|
end
|
|
|
|
build_options = BuildOptions.new(Options.create(flags), formula.options)
|
|
options = build_options.used_options
|
|
options |= formula.build.used_options
|
|
options &= formula.options
|
|
|
|
fi = FormulaInstaller.new(
|
|
formula,
|
|
**{
|
|
options:,
|
|
link_keg: keg_had_linked_opt ? keg_was_linked : nil,
|
|
installed_as_dependency: tab&.installed_as_dependency,
|
|
installed_on_request: installed_on_request || tab&.installed_on_request,
|
|
build_bottle: tab&.built_bottle?,
|
|
force_bottle:,
|
|
build_from_source_formulae:,
|
|
git:,
|
|
interactive:,
|
|
keep_tmp:,
|
|
debug_symbols:,
|
|
force:,
|
|
debug:,
|
|
quiet:,
|
|
verbose:,
|
|
}.compact,
|
|
)
|
|
fi.prelude
|
|
fi.fetch
|
|
|
|
oh1 "Reinstalling #{Formatter.identifier(formula.full_name)} #{options.to_a.join " "}"
|
|
|
|
fi.install
|
|
fi.finish
|
|
rescue FormulaInstallationAlreadyAttemptedError
|
|
nil
|
|
rescue Exception # rubocop:disable Lint/RescueException
|
|
ignore_interrupts { restore_backup(keg, keg_was_linked, verbose:) }
|
|
raise
|
|
else
|
|
begin
|
|
backup_path(keg).rmtree if backup_path(keg).exist?
|
|
rescue Errno::EACCES, Errno::ENOTEMPTY
|
|
odie <<~EOS
|
|
Could not remove #{backup_path(keg).parent.basename} backup keg! Do so manually:
|
|
sudo rm -rf #{backup_path(keg)}
|
|
EOS
|
|
end
|
|
end
|
|
|
|
def backup(keg)
|
|
keg.unlink
|
|
begin
|
|
keg.rename backup_path(keg)
|
|
rescue Errno::EACCES, Errno::ENOTEMPTY
|
|
odie <<~EOS
|
|
Could not rename #{keg.name} keg! Check/fix its permissions:
|
|
sudo chown -R #{ENV.fetch("USER", "$(whoami)")} #{keg}
|
|
EOS
|
|
end
|
|
end
|
|
|
|
def restore_backup(keg, keg_was_linked, verbose:)
|
|
path = backup_path(keg)
|
|
|
|
return unless path.directory?
|
|
|
|
Pathname.new(keg).rmtree if keg.exist?
|
|
|
|
path.rename keg
|
|
keg.link(verbose:) if keg_was_linked
|
|
end
|
|
|
|
def backup_path(path)
|
|
Pathname.new "#{path}.reinstall"
|
|
end
|
|
end
|