mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
41 lines
771 B
Ruby
41 lines
771 B
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
# Helper module for installing default files.
|
|
module InstallRenamed
|
|
def install_p(_, new_basename)
|
|
super do |src, dst|
|
|
if src.directory?
|
|
dst.install(src.children)
|
|
next
|
|
else
|
|
append_default_if_different(src, dst)
|
|
end
|
|
end
|
|
end
|
|
|
|
def cp_path_sub(pattern, replacement)
|
|
super do |src, dst|
|
|
append_default_if_different(src, dst)
|
|
end
|
|
end
|
|
|
|
def +(other)
|
|
super.extend(InstallRenamed)
|
|
end
|
|
|
|
def /(other)
|
|
super.extend(InstallRenamed)
|
|
end
|
|
|
|
private
|
|
|
|
def append_default_if_different(src, dst)
|
|
if dst.file? && !FileUtils.identical?(src, dst)
|
|
Pathname.new("#{dst}.default")
|
|
else
|
|
dst
|
|
end
|
|
end
|
|
end
|