mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00

- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
145 lines
4.5 KiB
Ruby
145 lines
4.5 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "extend/cachable"
|
|
require "api/download"
|
|
|
|
module Homebrew
|
|
module API
|
|
# Helper functions for using the formula JSON API.
|
|
module Formula
|
|
extend Cachable
|
|
|
|
DEFAULT_API_FILENAME = "formula.jws.json"
|
|
INTERNAL_V3_API_FILENAME = "internal/v3/homebrew-core.jws.json"
|
|
|
|
private_class_method :cache
|
|
|
|
sig { params(name: String).returns(Hash) }
|
|
def self.fetch(name)
|
|
Homebrew::API.fetch "formula/#{name}.json"
|
|
end
|
|
|
|
sig { params(formula: ::Formula).returns(::Formula) }
|
|
def self.source_download(formula)
|
|
path = formula.ruby_source_path || "Formula/#{formula.name}.rb"
|
|
git_head = formula.tap_git_head || "HEAD"
|
|
tap = formula.tap&.full_name || "Homebrew/homebrew-core"
|
|
|
|
download = Homebrew::API::Download.new(
|
|
"https://raw.githubusercontent.com/#{tap}/#{git_head}/#{path}",
|
|
formula.ruby_source_checksum,
|
|
cache: HOMEBREW_CACHE_API_SOURCE/"#{tap}/#{git_head}/Formula",
|
|
)
|
|
download.fetch
|
|
|
|
with_env(HOMEBREW_FORBID_PACKAGES_FROM_PATHS: nil) do
|
|
Formulary.factory(download.symlink_location,
|
|
formula.active_spec_sym,
|
|
alias_path: formula.alias_path,
|
|
flags: formula.class.build_flags)
|
|
end
|
|
end
|
|
|
|
def self.cached_json_file_path
|
|
if Homebrew::API.internal_json_v3?
|
|
HOMEBREW_CACHE_API/INTERNAL_V3_API_FILENAME
|
|
else
|
|
HOMEBREW_CACHE_API/DEFAULT_API_FILENAME
|
|
end
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def self.download_and_cache_data!
|
|
if Homebrew::API.internal_json_v3?
|
|
json_formulae, updated = Homebrew::API.fetch_json_api_file INTERNAL_V3_API_FILENAME
|
|
overwrite_cache! T.cast(json_formulae, T::Hash[String, T.untyped])
|
|
else
|
|
json_formulae, updated = Homebrew::API.fetch_json_api_file DEFAULT_API_FILENAME
|
|
|
|
cache["aliases"] = {}
|
|
cache["renames"] = {}
|
|
cache["formulae"] = json_formulae.to_h do |json_formula|
|
|
json_formula["aliases"].each do |alias_name|
|
|
cache["aliases"][alias_name] = json_formula["name"]
|
|
end
|
|
(json_formula["oldnames"] || [json_formula["oldname"]].compact).each do |oldname|
|
|
cache["renames"][oldname] = json_formula["name"]
|
|
end
|
|
|
|
[json_formula["name"], json_formula.except("name")]
|
|
end
|
|
end
|
|
|
|
updated
|
|
end
|
|
private_class_method :download_and_cache_data!
|
|
|
|
sig { returns(T::Hash[String, Hash]) }
|
|
def self.all_formulae
|
|
unless cache.key?("formulae")
|
|
json_updated = download_and_cache_data!
|
|
write_names_and_aliases(regenerate: json_updated)
|
|
end
|
|
|
|
cache["formulae"]
|
|
end
|
|
|
|
sig { returns(T::Hash[String, String]) }
|
|
def self.all_aliases
|
|
unless cache.key?("aliases")
|
|
json_updated = download_and_cache_data!
|
|
write_names_and_aliases(regenerate: json_updated)
|
|
end
|
|
|
|
cache["aliases"]
|
|
end
|
|
|
|
sig { returns(T::Hash[String, String]) }
|
|
def self.all_renames
|
|
unless cache.key?("renames")
|
|
json_updated = download_and_cache_data!
|
|
write_names_and_aliases(regenerate: json_updated)
|
|
end
|
|
|
|
cache["renames"]
|
|
end
|
|
|
|
sig { returns(Hash) }
|
|
def self.tap_migrations
|
|
# Not sure that we need to reload here.
|
|
unless cache.key?("tap_migrations")
|
|
json_updated = download_and_cache_data!
|
|
write_names_and_aliases(regenerate: json_updated)
|
|
end
|
|
|
|
cache["tap_migrations"]
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def self.tap_git_head
|
|
# Note sure we need to reload here.
|
|
unless cache.key?("tap_git_head")
|
|
json_updated = download_and_cache_data!
|
|
write_names_and_aliases(regenerate: json_updated)
|
|
end
|
|
|
|
cache["tap_git_head"]
|
|
end
|
|
|
|
sig { params(regenerate: T::Boolean).void }
|
|
def self.write_names_and_aliases(regenerate: false)
|
|
download_and_cache_data! unless cache.key?("formulae")
|
|
|
|
return unless Homebrew::API.write_names_file(all_formulae.keys, "formula", regenerate:)
|
|
|
|
(HOMEBREW_CACHE_API/"formula_aliases.txt").open("w") do |file|
|
|
all_aliases.each do |alias_name, real_name|
|
|
file.puts "#{alias_name}|#{real_name}"
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|