mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
69 lines
1.8 KiB
Ruby
69 lines
1.8 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "utils/user"
|
|
|
|
module Cask
|
|
# Helper functions for interacting with the `Caskroom` directory.
|
|
#
|
|
# @api internal
|
|
module Caskroom
|
|
sig { returns(Pathname) }
|
|
def self.path
|
|
@path ||= HOMEBREW_PREFIX/"Caskroom"
|
|
end
|
|
|
|
# Return all paths for installed casks.
|
|
sig { returns(T::Array[Pathname]) }
|
|
def self.paths
|
|
return [] unless path.exist?
|
|
|
|
path.children.select { |p| p.directory? && !p.symlink? }
|
|
end
|
|
private_class_method :paths
|
|
|
|
# Return all tokens for installed casks.
|
|
sig { returns(T::Array[String]) }
|
|
def self.tokens
|
|
paths.map { |path| path.basename.to_s }
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def self.any_casks_installed?
|
|
paths.any?
|
|
end
|
|
|
|
sig { void }
|
|
def self.ensure_caskroom_exists
|
|
return if path.exist?
|
|
|
|
sudo = !path.parent.writable?
|
|
|
|
if sudo && !ENV.key?("SUDO_ASKPASS") && $stdout.tty?
|
|
ohai "Creating Caskroom directory: #{path}",
|
|
"We'll set permissions properly so we won't need sudo in the future."
|
|
end
|
|
|
|
SystemCommand.run("/bin/mkdir", args: ["-p", path], sudo:)
|
|
SystemCommand.run("/bin/chmod", args: ["g+rwx", path], sudo:)
|
|
SystemCommand.run("/usr/sbin/chown", args: [User.current, path], sudo:)
|
|
SystemCommand.run("/usr/bin/chgrp", args: ["admin", path], sudo:)
|
|
end
|
|
|
|
# Get all installed casks.
|
|
#
|
|
# @api internal
|
|
sig { params(config: T.nilable(Config)).returns(T::Array[Cask]) }
|
|
def self.casks(config: nil)
|
|
tokens.sort.filter_map do |token|
|
|
CaskLoader.load(token, config:, warn: false)
|
|
rescue TapCaskAmbiguityError => e
|
|
T.must(e.loaders.first).load(config:)
|
|
rescue
|
|
# Don't blow up because of a single unavailable cask.
|
|
nil
|
|
end
|
|
end
|
|
end
|
|
end
|