mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00

- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
193 lines
5.9 KiB
Ruby
193 lines
5.9 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "language/python"
|
|
require "utils/service"
|
|
|
|
# A formula's caveats.
|
|
class Caveats
|
|
extend Forwardable
|
|
|
|
attr_reader :formula
|
|
|
|
def initialize(formula)
|
|
@formula = formula
|
|
end
|
|
|
|
def caveats
|
|
caveats = []
|
|
begin
|
|
build = formula.build
|
|
formula.build = Tab.for_formula(formula)
|
|
string = formula.caveats.to_s
|
|
caveats << "#{string.chomp}\n" unless string.empty?
|
|
ensure
|
|
formula.build = build
|
|
end
|
|
caveats << keg_only_text
|
|
|
|
valid_shells = [:bash, :zsh, :fish].freeze
|
|
current_shell = Utils::Shell.preferred || Utils::Shell.parent
|
|
shells = if current_shell.present? &&
|
|
(shell_sym = current_shell.to_sym) &&
|
|
valid_shells.include?(shell_sym)
|
|
[shell_sym]
|
|
else
|
|
valid_shells
|
|
end
|
|
shells.each do |shell|
|
|
caveats << function_completion_caveats(shell)
|
|
end
|
|
|
|
caveats << service_caveats
|
|
caveats << elisp_caveats
|
|
caveats.compact.join("\n")
|
|
end
|
|
|
|
delegate [:empty?, :to_s] => :caveats
|
|
|
|
def keg_only_text(skip_reason: false)
|
|
return unless formula.keg_only?
|
|
|
|
s = if skip_reason
|
|
""
|
|
else
|
|
<<~EOS
|
|
#{formula.name} is keg-only, which means it was not symlinked into #{HOMEBREW_PREFIX},
|
|
because #{formula.keg_only_reason.to_s.chomp}.
|
|
EOS
|
|
end.dup
|
|
|
|
if formula.bin.directory? || formula.sbin.directory?
|
|
s << <<~EOS
|
|
|
|
If you need to have #{formula.name} first in your PATH, run:
|
|
EOS
|
|
s << " #{Utils::Shell.prepend_path_in_profile(formula.opt_bin.to_s)}\n" if formula.bin.directory?
|
|
s << " #{Utils::Shell.prepend_path_in_profile(formula.opt_sbin.to_s)}\n" if formula.sbin.directory?
|
|
end
|
|
|
|
if formula.lib.directory? || formula.include.directory?
|
|
s << <<~EOS
|
|
|
|
For compilers to find #{formula.name} you may need to set:
|
|
EOS
|
|
|
|
s << " #{Utils::Shell.export_value("LDFLAGS", "-L#{formula.opt_lib}")}\n" if formula.lib.directory?
|
|
|
|
s << " #{Utils::Shell.export_value("CPPFLAGS", "-I#{formula.opt_include}")}\n" if formula.include.directory?
|
|
|
|
if which("pkg-config", ORIGINAL_PATHS) &&
|
|
((formula.lib/"pkgconfig").directory? || (formula.share/"pkgconfig").directory?)
|
|
s << <<~EOS
|
|
|
|
For pkg-config to find #{formula.name} you may need to set:
|
|
EOS
|
|
|
|
if (formula.lib/"pkgconfig").directory?
|
|
s << " #{Utils::Shell.export_value("PKG_CONFIG_PATH", "#{formula.opt_lib}/pkgconfig")}\n"
|
|
end
|
|
|
|
if (formula.share/"pkgconfig").directory?
|
|
s << " #{Utils::Shell.export_value("PKG_CONFIG_PATH", "#{formula.opt_share}/pkgconfig")}\n"
|
|
end
|
|
end
|
|
end
|
|
s << "\n" unless s.end_with?("\n")
|
|
s
|
|
end
|
|
|
|
private
|
|
|
|
def keg
|
|
@keg ||= [formula.prefix, formula.opt_prefix, formula.linked_keg].filter_map do |d|
|
|
Keg.new(d.resolved_path)
|
|
rescue
|
|
nil
|
|
end.first
|
|
end
|
|
|
|
def function_completion_caveats(shell)
|
|
return unless keg
|
|
return unless which(shell.to_s, ORIGINAL_PATHS)
|
|
|
|
completion_installed = keg.completion_installed?(shell)
|
|
functions_installed = keg.functions_installed?(shell)
|
|
return if !completion_installed && !functions_installed
|
|
|
|
installed = []
|
|
installed << "completions" if completion_installed
|
|
installed << "functions" if functions_installed
|
|
|
|
root_dir = formula.keg_only? ? formula.opt_prefix : HOMEBREW_PREFIX
|
|
|
|
case shell
|
|
when :bash
|
|
<<~EOS
|
|
Bash completion has been installed to:
|
|
#{root_dir}/etc/bash_completion.d
|
|
EOS
|
|
when :fish
|
|
fish_caveats = +"fish #{installed.join(" and ")} have been installed to:"
|
|
fish_caveats << "\n #{root_dir}/share/fish/vendor_completions.d" if completion_installed
|
|
fish_caveats << "\n #{root_dir}/share/fish/vendor_functions.d" if functions_installed
|
|
fish_caveats.freeze
|
|
when :zsh
|
|
<<~EOS
|
|
zsh #{installed.join(" and ")} have been installed to:
|
|
#{root_dir}/share/zsh/site-functions
|
|
EOS
|
|
end
|
|
end
|
|
|
|
def elisp_caveats
|
|
return if formula.keg_only?
|
|
return unless keg
|
|
return unless keg.elisp_installed?
|
|
|
|
<<~EOS
|
|
Emacs Lisp files have been installed to:
|
|
#{HOMEBREW_PREFIX}/share/emacs/site-lisp/#{formula.name}
|
|
EOS
|
|
end
|
|
|
|
def service_caveats
|
|
return if !formula.service? && !Utils::Service.installed?(formula) && !keg&.plist_installed?
|
|
return if formula.service? && !formula.service.command? && !Utils::Service.installed?(formula)
|
|
|
|
s = []
|
|
|
|
# Brew services only works with these two tools
|
|
return <<~EOS if !Utils::Service.systemctl? && !Utils::Service.launchctl? && formula.service.command?
|
|
#{Formatter.warning("Warning:")} #{formula.name} provides a service which can only be used on macOS or systemd!
|
|
You can manually execute the service instead with:
|
|
#{formula.service.manual_command}
|
|
EOS
|
|
|
|
startup = formula.service.requires_root?
|
|
if Utils::Service.running?(formula)
|
|
s << "To restart #{formula.full_name} after an upgrade:"
|
|
s << " #{startup ? "sudo " : ""}brew services restart #{formula.full_name}"
|
|
elsif startup
|
|
s << "To start #{formula.full_name} now and restart at startup:"
|
|
s << " sudo brew services start #{formula.full_name}"
|
|
else
|
|
s << "To start #{formula.full_name} now and restart at login:"
|
|
s << " brew services start #{formula.full_name}"
|
|
end
|
|
|
|
if formula.service.command?
|
|
s << "Or, if you don't want/need a background service you can just run:"
|
|
s << " #{formula.service.manual_command}"
|
|
end
|
|
|
|
# pbpaste is the system clipboard tool on macOS and fails with `tmux` by default
|
|
# check if this is being run under `tmux` to avoid failing
|
|
if ENV["HOMEBREW_TMUX"] && !quiet_system("/usr/bin/pbpaste")
|
|
s << "" << "WARNING: brew services will fail when run under tmux."
|
|
end
|
|
|
|
"#{s.join("\n")}\n" unless s.empty?
|
|
end
|
|
end
|