mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
74 lines
2.3 KiB
Ruby
74 lines
2.3 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
module Superenv
|
|
sig { returns(Pathname) }
|
|
def self.shims_path
|
|
HOMEBREW_SHIMS_PATH/"linux/super"
|
|
end
|
|
|
|
sig { returns(T.nilable(Pathname)) }
|
|
def self.bin
|
|
shims_path.realpath
|
|
end
|
|
|
|
sig {
|
|
params(
|
|
formula: T.nilable(Formula),
|
|
cc: T.nilable(String),
|
|
build_bottle: T.nilable(T::Boolean),
|
|
bottle_arch: T.nilable(String),
|
|
testing_formula: T::Boolean,
|
|
debug_symbols: T.nilable(T::Boolean),
|
|
).void
|
|
}
|
|
def setup_build_environment(formula: nil, cc: nil, build_bottle: false, bottle_arch: nil, testing_formula: false,
|
|
debug_symbols: false)
|
|
generic_setup_build_environment(formula:, cc:, build_bottle:, bottle_arch:,
|
|
testing_formula:, debug_symbols:)
|
|
self["HOMEBREW_OPTIMIZATION_LEVEL"] = "O2"
|
|
self["HOMEBREW_DYNAMIC_LINKER"] = determine_dynamic_linker_path
|
|
self["HOMEBREW_RPATH_PATHS"] = determine_rpath_paths(@formula)
|
|
self["M4"] = "#{HOMEBREW_PREFIX}/opt/m4/bin/m4" if deps.any? { |d| d.name == "libtool" || d.name == "bison" }
|
|
end
|
|
|
|
def homebrew_extra_paths
|
|
paths = generic_homebrew_extra_paths
|
|
paths += %w[binutils make].filter_map do |f|
|
|
bin = Formulary.factory(f).opt_bin
|
|
bin if bin.directory?
|
|
rescue FormulaUnavailableError
|
|
nil
|
|
end
|
|
paths
|
|
end
|
|
|
|
def homebrew_extra_isystem_paths
|
|
paths = []
|
|
# Add paths for GCC headers when building against glibc@2.13 because we have to use -nostdinc.
|
|
if deps.any? { |d| d.name == "glibc@2.13" }
|
|
gcc_include_dir = Utils.safe_popen_read(cc, "--print-file-name=include").chomp
|
|
gcc_include_fixed_dir = Utils.safe_popen_read(cc, "--print-file-name=include-fixed").chomp
|
|
paths << gcc_include_dir << gcc_include_fixed_dir
|
|
end
|
|
paths
|
|
end
|
|
|
|
def determine_rpath_paths(formula)
|
|
PATH.new(
|
|
*formula&.lib,
|
|
"#{HOMEBREW_PREFIX}/opt/gcc/lib/gcc/current",
|
|
PATH.new(run_time_deps.map { |dep| dep.opt_lib.to_s }).existing,
|
|
"#{HOMEBREW_PREFIX}/lib",
|
|
)
|
|
end
|
|
|
|
sig { returns(T.nilable(String)) }
|
|
def determine_dynamic_linker_path
|
|
path = "#{HOMEBREW_PREFIX}/lib/ld.so"
|
|
return unless File.readable? path
|
|
|
|
path
|
|
end
|
|
end
|