brew/Library/Homebrew/readall.rb
Mike McQuaid 9fca172d03 Fix HOMEBREW_RUBY_WARNINGS="-w"
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00

87 lines
2.3 KiB
Ruby

require "formula"
module Readall
class << self
def valid_ruby_syntax?(ruby_files)
ruby_files_queue = Queue.new
ruby_files.each { |f| ruby_files_queue << f }
failed = false
workers = (0...Hardware::CPU.cores).map do
Thread.new do
Kernel.loop do
begin
# As a side effect, print syntax errors/warnings to `$stderr`.
failed = true if syntax_errors_or_warnings?(ruby_files_queue.deq(true))
rescue ThreadError
break
end
end
end
end
workers.each(&:join)
!failed
end
def valid_aliases?(alias_dir, formula_dir)
return true unless alias_dir.directory?
failed = false
alias_dir.each_child do |f|
if !f.symlink?
onoe "Non-symlink alias: #{f}"
failed = true
elsif !f.file?
onoe "Non-file alias: #{f}"
failed = true
end
if (formula_dir/"#{f.basename}.rb").exist?
onoe "Formula duplicating alias: #{f}"
failed = true
end
end
!failed
end
def valid_formulae?(formulae)
failed = false
formulae.each do |file|
begin
Formulary.factory(file)
rescue Interrupt
raise
rescue Exception => e # rubocop:disable Lint/RescueException
onoe "Invalid formula: #{file}"
puts e
failed = true
end
end
!failed
end
def valid_tap?(tap, options = {})
failed = false
if options[:aliases]
valid_aliases = valid_aliases?(tap.alias_dir, tap.formula_dir)
failed = true unless valid_aliases
end
valid_formulae = valid_formulae?(tap.formula_files)
failed = true unless valid_formulae
!failed
end
private
def syntax_errors_or_warnings?(rb)
# Retrieve messages about syntax errors/warnings printed to `$stderr`, but
# discard a `Syntax OK` printed to `$stdout` (in absence of syntax errors).
messages = Utils.popen_read("#{RUBY_PATH} -c -w #{rb} 2>&1 >/dev/null")
$stderr.print messages
# Only syntax errors result in a non-zero status code. To detect syntax
# warnings we also need to inspect the output to `$stderr`.
!$CHILD_STATUS.success? || !messages.chomp.empty?
end
end
end